[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#985590: marked as done ((pre-approval) unblock: zfs-linux/2.0.3-2)

Your message dated Fri, 2 Apr 2021 22:22:06 +0200
with message-id <31cf2099-45a0-b5b0-8467-91d63f9a9a89@debian.org>
and subject line Re: Bug#985590: (pre-approval) unblock: zfs-linux/2.0.3-2
has caused the Debian Bug report #985590,
regarding (pre-approval) unblock: zfs-linux/2.0.3-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
985590: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985590
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Dear release team,

Please pre-approve unblock package zfs-linux/2.0.3-2.

This revision is mainly consisted of the following enhancements:

1. Cherry-pick of upstream changes after 2.0.3, which is a subset of 2.0.4 with 
   irrelevant linux 5.12 compat and other stuff removed, making it a pure bug
   fix update;
2. Fixed update failure from buster-bpo (#983401);
3. Add new debconf questions, for the cron jobs of pool scrub and trim, with
   translation updates from debian-i18n people.

Regards,
Aron Xu

Attachment: zfs-linux_2.0.3-2.debdiff.gz
Description: application/gzip

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Hi,

On 30-03-2021 10:01, Aron Xu wrote:
> On Tue, Mar 30, 2021 at 4:17 AM Paul Gevers <elbrus@debian.org> wrote:
>>
> [...]
>>
>>> 3. Add new debconf questions, for the cron jobs of pool scrub and trim, with
>>>    translation updates from debian-i18n people.
>>
>> But here, I think there's a serious issue. You seem to be querying the
>> debconf database during cron jobs, but debconf is not a registry. This
>> is not acceptable. Lintian warns about this too:
>> https://lintian.debian.org/tags/debconf-is-not-a-registry.html
>>
>> I suggest you prepare an upload with 1 and 2. I don't feel comfortable
>> with 3, even if you fix the debconf-is-not-a-registry issue.
>>
> 
> I have reverted 3, and attached is the new debdiff.
> 
> Thanks for the comments!

It seems the package was uploaded anyways with the part that I said I
felt uncomfortable about. So, let's close this bug.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
Reply to: