[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#986146: marked as done (unblock: rabbitmq-server/3.8.9-2)

Your message dated Thu, 01 Apr 2021 10:40:26 +0000
with message-id <E1lRukU-0004FK-Op@respighi.debian.org>
and subject line unblock rabbitmq-server
has caused the Debian Bug report #986146,
regarding unblock: rabbitmq-server/3.8.9-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
986146: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986146
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package rabbitmq-server

rabbitmq-server used to need a restart whenever logs where rotated.
That's no longer the case anymore. So the attached debdiff stops
using a sharedscript, making the service survive better to log rotation.

No impact for the users, just a better rabbitmq-server.
Debdiff attached.

Please unblock rabbitmq-server/3.8.9-2

diff -Nru rabbitmq-server-3.8.9/debian/changelog rabbitmq-server-3.8.9/debian/changelog
--- rabbitmq-server-3.8.9/debian/changelog	2020-10-01 09:30:46.000000000 +0200
+++ rabbitmq-server-3.8.9/debian/changelog	2021-03-26 14:24:32.000000000 +0100
@@ -1,3 +1,14 @@
+rabbitmq-server (3.8.9-2) unstable; urgency=medium
+
+  * Do not use the /usr/sbin/rabbitmq-server wrapper in systemd service file
+    (Closes: #947873).
+  * Use logrotate daily instead of weekly, and do not override the number of
+    logs, so we don't keep too much of them.
+  * Do not use a sharedscripts, as rabbitmq-server detects the log rotation
+    by itself (LP: #1921425).
+
+ -- Thomas Goirand <zigo@debian.org>  Fri, 26 Mar 2021 14:24:52 +0100
+
 rabbitmq-server (3.8.9-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru rabbitmq-server-3.8.9/debian/rabbitmq-server.logrotate rabbitmq-server-3.8.9/debian/rabbitmq-server.logrotate
--- rabbitmq-server-3.8.9/debian/rabbitmq-server.logrotate	2020-10-01 09:30:46.000000000 +0200
+++ rabbitmq-server-3.8.9/debian/rabbitmq-server.logrotate	2021-03-26 14:24:32.000000000 +0100
@@ -1,12 +1,7 @@
 /var/log/rabbitmq/*.log {
-        weekly
-        missingok
-        rotate 20
-        compress
-        delaycompress
-        notifempty
-        sharedscripts
-        postrotate
-            /etc/init.d/rabbitmq-server rotate-logs > /dev/null
-        endscript
+	daily
+	missingok
+	compress
+	delaycompress
+	notifempty
 }
diff -Nru rabbitmq-server-3.8.9/debian/rabbitmq-server.service rabbitmq-server-3.8.9/debian/rabbitmq-server.service
--- rabbitmq-server-3.8.9/debian/rabbitmq-server.service	2020-10-01 09:30:46.000000000 +0200
+++ rabbitmq-server-3.8.9/debian/rabbitmq-server.service	2021-03-26 14:24:32.000000000 +0100
@@ -15,8 +15,10 @@
 Restart=on-failure
 RestartSec=10
 WorkingDirectory=/var/lib/rabbitmq
-ExecStart=/usr/sbin/rabbitmq-server
+ExecStart=/usr/lib/rabbitmq/bin/rabbitmq-server
 ExecStop=/usr/sbin/rabbitmqctl stop
+StandardOutput=append:/var/log/rabbitmq/rabbitmq-server.log
+StandardError=append:/var/log/rabbitmq/rabbitmq-server.error.log
 
 [Install]
 WantedBy=multi-user.target

--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: