[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#985590: (pre-approval) unblock: zfs-linux/2.0.3-2



Control: tags -1 moreinfo

Hi Aron

On 20-03-2021 15:04, Aron Xu wrote:
> Please pre-approve unblock package zfs-linux/2.0.3-2.
> 
> This revision is mainly consisted of the following enhancements:
> 
> 1. Cherry-pick of upstream changes after 2.0.3, which is a subset of 2.0.4 with 
>    irrelevant linux 5.12 compat and other stuff removed, making it a pure bug
>    fix update;

This looks OK.

> 2. Fixed update failure from buster-bpo (#983401);

This too.

> 3. Add new debconf questions, for the cron jobs of pool scrub and trim, with
>    translation updates from debian-i18n people.

But here, I think there's a serious issue. You seem to be querying the
debconf database during cron jobs, but debconf is not a registry. This
is not acceptable. Lintian warns about this too:
https://lintian.debian.org/tags/debconf-is-not-a-registry.html

I suggest you prepare an upload with 1 and 2. I don't feel comfortable
with 3, even if you fix the debconf-is-not-a-registry issue.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: