[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#985646: marked as done (unblock: odin/2.0.4-3)

Your message dated Thu, 25 Mar 2021 19:58:19 +0000
with message-id <E1lPW7X-000100-Kh@respighi.debian.org>
and subject line unblock odin
has caused the Debian Bug report #985646,
regarding unblock: odin/2.0.4-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
985646: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985646
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package odin

[ Reason ]
odin/2.0.4-1 is affected by two RC critical bugs in Bullseye,
#985508, and #985577, which are fixed by odin/2.0.4-3 in Sid.

[ Impact ]
Impact of removal of odin in Bullseye would potentially affect
98 installations per popcon reports.  This is an otherwise leaf
package, and wouldn't affect other elements from the archive.

[ Tests ]
  * Built on all release architecture by buildd
  * Went through Salsa CI, only reprotest is failing
  * I ran piuparts --fail-on-broken-symlinks --no-upgrade-test
    to check the package was not affected by #985508 anymore.
  * I manually tested running most programs:
    - I played around with a couple of GUI applications to make
      sure they were not affected by #985577 anymore: no crashes
      observed, but since I don't do magnetic resonance imaging
      in my daily activities, I don't know how much my tests
      covered regular use cases;
    - I tested most command line applications to make sure they
      were not affected by #985577; althought tests didn't go
      way further than --help and --version, these were
      initially sufficient to trigger the bug.

[ Risks ]
Changes have been kept as minimum as I could to fix bugs.  This
is a leaf package, so shouldn't affect other Debian packages.
Furthermore, affected libraries are private to the namespace of
the odin progams, so shouldn't interfere with other packages run
time.

[ Checklist ]
  [*] all changes are documented in the d/changelog
  [*] I reviewed all changes and I approve them
  [*] attach debdiff against the package in testing

[ Other info ]
reprotest failure is due to build flags with file path embedded
in the header file usr/include/tjutils/config.h.  I have some
doubts on the cross-buildability of the package given the use of
DEB_HOST_MULTIARCH where I naively expect DEB_BUILD_MULTIARCH.
But I understand these are out of scope items in hard freeze.


unblock odin/2.0.4-3


Have a nice day,  :)
-- 
Étienne Mollier <etienne.mollier@mailoo.org>
Fingerprint:  8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
Sent from /dev/pts/1, please excuse my verbosity.

diff -Nru odin-2.0.4/debian/changelog odin-2.0.4/debian/changelog
--- odin-2.0.4/debian/changelog	2020-12-15 21:11:56.000000000 +0100
+++ odin-2.0.4/debian/changelog	2021-03-20 13:49:44.000000000 +0100
@@ -1,3 +1,22 @@
+odin (2.0.4-3) unstable; urgency=medium
+
+  * Team upload.
+  * Configure build to target the libdir /usr/lib/$(DEB_HOST_MULTIARCH)/odin,
+    and adjust install scripts to the new staging location: allows executables 
+    provided by packages mitools and odin to find their private shared objects.
+    Closes: #985577
+
+ -- Étienne Mollier <etienne.mollier@mailoo.org>  Sat, 20 Mar 2021 13:49:44 +0100
+
+odin (2.0.4-2) unstable; urgency=medium
+
+  * Team upload.
+  * Added mitools and qtchooser as dependency of libodin-dev; fixes broken
+    symbolic links on libodin-dev installation.
+    Closes: #985508
+
+ -- Étienne Mollier <etienne.mollier@mailoo.org>  Fri, 19 Mar 2021 20:02:31 +0100
+
 odin (2.0.4-1) unstable; urgency=medium
 
   * Team upload.
diff -Nru odin-2.0.4/debian/control odin-2.0.4/debian/control
--- odin-2.0.4/debian/control	2020-12-15 21:11:56.000000000 +0100
+++ odin-2.0.4/debian/control	2021-03-19 19:54:39.000000000 +0100
@@ -65,6 +65,8 @@
 Section: libdevel
 Depends: ${shlibs:Depends},
          ${misc:Depends},
+         mitools,
+         qtchooser,
          sensible-utils
 Description: static libraries and header for ODIN sequences
  This package provides static libraries and headers of the ODIN libraries
diff -Nru odin-2.0.4/debian/libodin-dev.install odin-2.0.4/debian/libodin-dev.install
--- odin-2.0.4/debian/libodin-dev.install	2020-12-15 21:11:56.000000000 +0100
+++ odin-2.0.4/debian/libodin-dev.install	2021-03-20 13:09:27.000000000 +0100
@@ -1,4 +1,4 @@
 #! /usr/bin/dh-exec
-usr/lib/odin/*.a	usr/lib/${DEB_HOST_MULTIARCH}/odin
-usr/lib/odin/*[a-z].so	usr/lib/${DEB_HOST_MULTIARCH}/odin
+usr/lib/${DEB_HOST_MULTIARCH}/odin/*.a	usr/lib/${DEB_HOST_MULTIARCH}/odin
+usr/lib/${DEB_HOST_MULTIARCH}/odin/*[a-z].so	usr/lib/${DEB_HOST_MULTIARCH}/odin
 usr/include
diff -Nru odin-2.0.4/debian/mitools.install odin-2.0.4/debian/mitools.install
--- odin-2.0.4/debian/mitools.install	2020-12-15 21:11:56.000000000 +0100
+++ odin-2.0.4/debian/mitools.install	2021-03-20 13:12:03.000000000 +0100
@@ -1,3 +1,3 @@
 #! /usr/bin/dh-exec
-usr/lib/odin/*-*.so	usr/lib/${DEB_HOST_MULTIARCH}/odin
+usr/lib/${DEB_HOST_MULTIARCH}/odin/*-*.so	usr/lib/${DEB_HOST_MULTIARCH}/odin
 usr/bin/mi*		usr/bin
diff -Nru odin-2.0.4/debian/rules odin-2.0.4/debian/rules
--- odin-2.0.4/debian/rules	2020-12-15 21:11:56.000000000 +0100
+++ odin-2.0.4/debian/rules	2021-03-20 13:29:05.000000000 +0100
@@ -14,7 +14,7 @@
 
 override_dh_auto_configure:
 	dh_auto_configure -- \
-    --libdir="/usr/lib/odin" \
+    --libdir="/usr/lib/$(DEB_HOST_MULTIARCH)/odin" \
     --with-pic \
     --enable-only-standalone-plugin \
     --enable-static \

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Unblocked odin.

--- End Message ---
Reply to: