[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#985490: unblock: flamerobin/0.9.3.6-2



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package flamerobin

Version 0.9.3.6-2 fixes a serious bug in handling dir->symlink and symlink->dir 
migration when the package is upgraded from stable 
(https://bugs.debian.org/985289). Full source debdiff attached.

First I confirmed that the problem is present: removed the package, installed 
stable version (0.9.3~+20160512.c75f8618-2), upgraded to testing version 
(0.9.3.6-1), noted /usr/share/doc/flamerobin/html is still a symlink to 
/usr/share/flamerobin/docs instead of the reverse.

Then I tested whether the new package fixes the problem: removed the package 
again, installed the stable version and upgraded to the proposed version 
(0.9.3.6-2). /usr/share/doc/flamerobin/html now is a directory, and 
/usr/share/flamerobin/docs is a symlink to it. This is the wanted state, and 
this is what happens if the proposed version is installed anew.

I also checked that the small in-built documentation browser still finds its 
docs.


unblock flamerobin/0.9.3.6-2


Thanks,
    dam
diff -Nru flamerobin-0.9.3.6/debian/changelog flamerobin-0.9.3.6/debian/changelog
--- flamerobin-0.9.3.6/debian/changelog	2021-01-11 10:07:02.000000000 +0200
+++ flamerobin-0.9.3.6/debian/changelog	2021-03-19 07:54:27.000000000 +0200
@@ -1,3 +1,25 @@
+flamerobin (0.9.3.6-2) unstable; urgency=medium
+
+  * ensure proper migration from docs symlink to directory and vice versa
+    .
+    In 0.9.3.5-1 /usr/share/flamerobin/docs was moved to
+    /usr/share/doc/flamerobin/html with a symlink at the old location
+    .
+    Old state
+      /usr/share/doc/flamerobin/html -> ../../flamerobin/docs
+      /usr/share/flamerobin/docs -- a directory with HTML files
+    New state
+      /usr/share/doc/flamerobin/html -- a directory with HTML files
+      /usr/share/flamerobin/docs -> ../doc/flamerobin/html
+    .
+    Since dpkg won't do dir<->symlink conversions, add maintscript for the
+    two transitions. Also add Pre-Depends on dpkg 1.17.14 for maintscript
+    support.
+    .
+    Thanks to Andreas Beckmann for reporting (Closes: #985289)
+
+ -- Damyan Ivanov <dmn@debian.org>  Fri, 19 Mar 2021 05:54:27 +0000
+
 flamerobin (0.9.3.6-1) unstable; urgency=medium
 
   * New upstream snapshot release
diff -Nru flamerobin-0.9.3.6/debian/control flamerobin-0.9.3.6/debian/control
--- flamerobin-0.9.3.6/debian/control	2021-01-11 10:02:34.000000000 +0200
+++ flamerobin-0.9.3.6/debian/control	2021-03-19 07:49:24.000000000 +0200
@@ -17,6 +17,7 @@
 
 Package: flamerobin
 Architecture: any
+Pre-Depends: dpkg (>= 1.17.14)
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Suggests: firebird3.0-server
 Description: graphical database administration tool for Firebird DBMS
diff -Nru flamerobin-0.9.3.6/debian/flamerobin.maintscript flamerobin-0.9.3.6/debian/flamerobin.maintscript
--- flamerobin-0.9.3.6/debian/flamerobin.maintscript	1970-01-01 02:00:00.000000000 +0200
+++ flamerobin-0.9.3.6/debian/flamerobin.maintscript	2021-03-19 07:49:24.000000000 +0200
@@ -0,0 +1,3 @@
+symlink_to_dir /usr/share/doc/flamerobin/html ../../flamerobin/docs 0.9.3.4-1
+
+dir_to_symlink /usr/share/flamerobin/docs ../doc/flamerobin/html 0.9.3.4-1

Reply to: