[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#985324: marked as done (unblock: solarwolf/1.5+dfsg1-3)

Your message dated Tue, 16 Mar 2021 08:36:49 +0000
with message-id <E1lM5C5-0006ol-8t@respighi.debian.org>
and subject line unblock solarwolf
has caused the Debian Bug report #985324,
regarding unblock: solarwolf/1.5+dfsg1-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
985324: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985324
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: urbec@debian.org, apo@debian.org

Please unblock package solarwolf

[ Reason ]
The change fixes grave bug #984673 by replacing deprecated (and since python 3.9 removed)
method isAlive() of threading.Thread with its successor is_alive().

[ Impact ]
solarwolf currently fails to start in testing and will be autoremoved on April 04.

[ Tests ]
(manual) With the change can start and play the game, without not.

[ Risks ]
Change is trivial and the recommeded fix in the python 3.9 release notes [1] -
"The isAlive() method of threading.Thread has been removed.
It was deprecated since Python 3.8. Use is_alive() instead."

[1] https://docs.python.org/3/whatsnew/3.9.html

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing


unblock solarwolf/1.5+dfsg1-3

diff -Nru solarwolf-1.5+dfsg1/debian/changelog solarwolf-1.5+dfsg1/debian/changelog
--- solarwolf-1.5+dfsg1/debian/changelog	2020-03-23 06:22:20.000000000 +0700
+++ solarwolf-1.5+dfsg1/debian/changelog	2021-03-15 06:25:59.000000000 +0700
@@ -1,3 +1,11 @@
+solarwolf (1.5+dfsg1-3) unstable; urgency=medium
+
+  * QA upload.
+  * Fix runtime error Thread object has no attribute isAlive.
+    Thanks to Judit Foglszinger for the patch. (Closes: #984673)
+
+ -- Markus Koschany <apo@debian.org>  Mon, 15 Mar 2021 00:25:59 +0100
+
 solarwolf (1.5+dfsg1-2) unstable; urgency=medium
 
   * QA upload.
diff -Nru solarwolf-1.5+dfsg1/debian/patches/replacing-isAlive-with-is_alive.patch solarwolf-1.5+dfsg1/debian/patches/replacing-isAlive-with-is_alive.patch
--- solarwolf-1.5+dfsg1/debian/patches/replacing-isAlive-with-is_alive.patch	1970-01-01 07:00:00.000000000 +0700
+++ solarwolf-1.5+dfsg1/debian/patches/replacing-isAlive-with-is_alive.patch	2021-03-15 06:25:59.000000000 +0700
@@ -0,0 +1,33 @@
+Description: Replacing isAlive with is_alive
+ solarwolf fails to start because of an AttributeError: Thread object
+ has no attribute isAlive. The function was removed in Python 3.9. The patch
+ replaces it with the new one is_alive().
+---
+Bug-Debian: https://bugs.debian.org/984673
+Forwarded: no
+Reviewed-By: Markus Koschany
+Last-Update: 2021-03-12
+
+--- solarwolf-1.5+dfsg1.orig/code/gameinit.py
++++ solarwolf-1.5+dfsg1/code/gameinit.py
+@@ -161,7 +161,7 @@ class GameInit:
+ 
+         now = pygame.time.get_ticks()
+         #we let the screen stay up for at about 1 second
+-        if not self.thread.isAlive():
++        if not self.thread.is_alive():
+             if load_finished_status >= 0:
+                 if now-self.starttime > 1200:
+                     self.quit()
+--- solarwolf-1.5+dfsg1.orig/code/gamenews.py
++++ solarwolf-1.5+dfsg1/code/gamenews.py
+@@ -234,7 +234,7 @@ class GameNews:
+         self.clocks += 1
+         self.cleartext()
+ 
+-        if self.thread and (not self.thread.isAlive() and self.success):
++        if self.thread and (not self.thread.is_alive() and self.success):
+             self.download_finished()
+ 
+         clearme = None
+
diff -Nru solarwolf-1.5+dfsg1/debian/patches/series solarwolf-1.5+dfsg1/debian/patches/series
--- solarwolf-1.5+dfsg1/debian/patches/series	2019-09-29 21:12:23.000000000 +0700
+++ solarwolf-1.5+dfsg1/debian/patches/series	2021-03-15 06:25:59.000000000 +0700
@@ -2,3 +2,4 @@
 music.patch
 spelling.patch
 python3.patch
+replacing-isAlive-with-is_alive.patch

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: