Bug#984595: buster-pu: package samba/2:4.9.5+dfsg-5
On 2021-03-05 15:21:59, Vasyl Gello wrote:
> Package: release.debian.org
> Severity: normal
> Tags: buster
> User: release.debian.org@packages.debian.org
> Usertags: pu
> X-Debbugs-Cc: mattia@debian.org, math.parent@gmail.com
>
> Dear colleagues,
>
> Please accept the proposed update of samba in buster / buster-security
> after the fix closing #984486 gets merged by Mathieu and uploaded to
> stable queue.
>
> [ Reason ]
>
> I encountered the missing header include within libsmbclient-dev
> trying to do a no-change rebuild of ffmpeg 4.3.2 for buster-backports.
FWIW, the relevant version for buster-backports is ffmpeg
7:4.3.2-0+deb11u1 which does not require libsmbclient-dev. So the bug in
samba does not prevent backports of ffmpeg
Cheers
>
> The problem has been reported to Samba upstream by Gentoo maintainers
> two years ago there: https://bugs.gentoo.org/666548 and the only contribution
> I made in re this bug is adapting the patch for Debian's samba source tree:
>
> https://salsa.debian.org/samba-team/samba/-/merge_requests/51
>
> [ Impact ]
>
> ffmpeg >= 4.3.1-8 will FTBFS due to re-added libsmbclient build-dependency
>
> [ Tests ]
>
> Build passes, built package from my unofficial Kodi from Debian repo is
> tested by me & other (several dozen) users.
>
> [ Risks ]
>
> The risk is low because:
>
> * It is a header-only change
> * It has been accepted by upstream 2 years ago
> * I confirmed ffmpeg builds fine with modified samba package
> * Quite many unofficial repo users
>
> [ Checklist ]
> [x] *all* changes are documented in the d/changelog
> [x] I reviewed all changes and I approve them
> [x] attach debdiff against the package in (old)stable
> [x] the issue is verified as fixed in unstable
>
> [ Changes ]
>
> One patch added, debian/patches/fix-timeval.patch that includes
> <time.h> into source3/include/libsmbclient.h
>
> [ Other info ]
>
> Debdiff will be added after MR gets merged.
>
--
Sebastian Ramacher
Reply to: