Bug#983448: marked as done (unblock: gridengine/8.1.9+dfsg-9.1)
Your message dated Thu, 25 Feb 2021 07:44:56 +0200
with message-id <CAM8zJQvehvLFc6n5WX9TOoyS1w6-Jhp3EuDRi5AGkk9A-qMMEg@mail.gmail.com>
and subject line Re: Bug#983448: unblock: gridengine/8.1.9+dfsg-9.1
has caused the Debian Bug report #983448,
regarding unblock: gridengine/8.1.9+dfsg-9.1
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
983448: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983448
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package gridengine
[ Reason ]
gridengine was blocked on a gcc-10 FTBFS bug. I didn't notice this until
someone pointed it out to me in late January, and then I immediately set
out to create an NMU that fixes the issue, which I uploaded to the
DELAYED queue.
When I found out that my timing was off, I uploaded it again to the
regular queue, and did not think about it any more. Only later did I
notice that an upload of a package of the same version to the regular
upload queue does not override the pending upload in the DELAYED queue,
which meant the package entered unstable too late to still enter
testing before the freeze.
[ Impact ]
Since it's out of testing due only to a few missing "extern"
declarations (that caused FTBFS with gcc-10), users depending on
gridengine in buster won't be able to upgrade to bullseye.
[ Tests ]
I installed the gridengine packages on my laptop and confirmed basic
functionality.
[ Risks ]
Patches are very trivial; I only added this patch (plus changelog etc):
Description: Fix FTBFS with g++ 10
Author: Pierre Gruet <pgtdebian@free.fr>
Bug-Debian: https://bugs.debian.org/957310
Forwarded: no
Last-Update: 2020-11-26
--- a/source/libs/japi/drmaa2_list_dict.h
+++ b/source/libs/japi/drmaa2_list_dict.h
@@ -10,7 +10,7 @@
struct _drmaa2_node *next;
} _drmaa2_Node;
-/* static */ struct drmaa2_list_s
+/* static */ extern struct drmaa2_list_s
{
_drmaa2_Node *head;
_drmaa2_Node *tail;
@@ -33,7 +33,7 @@
struct _drmaa2_dictentry_t* next;
} _drmaa2_dictentry_t;
-/* static */ struct drmaa2_dict_s
+/* static */ extern struct drmaa2_dict_s
{
_drmaa2_dictentry_t *head;
_drmaa2_dictentry_t *tail;
diff --git a/source/3rdparty/qmake/make.h b/source/3rdparty/qmake/make.h
index 46d523a4c..87e871bc6 100644
--- a/source/3rdparty/qmake/make.h
+++ b/source/3rdparty/qmake/make.h
@@ -348,7 +348,7 @@ extern int unixy_shell;
#endif
#ifdef SET_STACK_SIZE
# include <sys/resource.h>
-struct rlimit stack_limit;
+extern struct rlimit stack_limit;
#endif
struct floc
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[ ] attach debdiff against the package in testing
(no debdiff against testing, because the package is not currently in
testing)
[ Other info ]
(Anything else the release team should know.)
unblock gridengine/8.1.9+dfsg-9.1
--- End Message ---
--- Begin Message ---
On Wed, 24 Feb 2021 at 13:12, Wouter Verhelst <wouter@debian.org> wrote:
>
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
>
> Please unblock package gridengine
>
> [ Reason ]
> gridengine was blocked on a gcc-10 FTBFS bug. I didn't notice this until
> someone pointed it out to me in late January, and then I immediately set
> out to create an NMU that fixes the issue, which I uploaded to the
> DELAYED queue.
>
> When I found out that my timing was off, I uploaded it again to the
> regular queue, and did not think about it any more. Only later did I
> notice that an upload of a package of the same version to the regular
> upload queue does not override the pending upload in the DELAYED queue,
> which meant the package entered unstable too late to still enter
> testing before the freeze.
>
> [ Impact ]
> Since it's out of testing due only to a few missing "extern"
> declarations (that caused FTBFS with gcc-10), users depending on
> gridengine in buster won't be able to upgrade to bullseye.
>
> [ Tests ]
> I installed the gridengine packages on my laptop and confirmed basic
> functionality.
>
> [ Risks ]
> Patches are very trivial; I only added this patch (plus changelog etc):
>
> Description: Fix FTBFS with g++ 10
> Author: Pierre Gruet <pgtdebian@free.fr>
> Bug-Debian: https://bugs.debian.org/957310
> Forwarded: no
> Last-Update: 2020-11-26
> --- a/source/libs/japi/drmaa2_list_dict.h
> +++ b/source/libs/japi/drmaa2_list_dict.h
> @@ -10,7 +10,7 @@
> struct _drmaa2_node *next;
> } _drmaa2_Node;
>
> -/* static */ struct drmaa2_list_s
> +/* static */ extern struct drmaa2_list_s
> {
> _drmaa2_Node *head;
> _drmaa2_Node *tail;
> @@ -33,7 +33,7 @@
> struct _drmaa2_dictentry_t* next;
> } _drmaa2_dictentry_t;
>
> -/* static */ struct drmaa2_dict_s
> +/* static */ extern struct drmaa2_dict_s
> {
> _drmaa2_dictentry_t *head;
> _drmaa2_dictentry_t *tail;
> diff --git a/source/3rdparty/qmake/make.h b/source/3rdparty/qmake/make.h
> index 46d523a4c..87e871bc6 100644
> --- a/source/3rdparty/qmake/make.h
> +++ b/source/3rdparty/qmake/make.h
> @@ -348,7 +348,7 @@ extern int unixy_shell;
> #endif
> #ifdef SET_STACK_SIZE
> # include <sys/resource.h>
> -struct rlimit stack_limit;
> +extern struct rlimit stack_limit;
> #endif
>
> struct floc
>
> [ Checklist ]
> [x] all changes are documented in the d/changelog
> [x] I reviewed all changes and I approve them
> [ ] attach debdiff against the package in testing
>
> (no debdiff against testing, because the package is not currently in
> testing)
>
> [ Other info ]
> (Anything else the release team should know.)
>
> unblock gridengine/8.1.9+dfsg-9.1
>
Unblocked, thanks.
--- End Message ---
Reply to: