[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#980133: marked as done (buster-pu: package libdbd-csv-perl/0.5300-1+deb10u1)



Your message dated Sat, 06 Feb 2021 10:39:26 +0000
with message-id <6425525e38201ecf9a2d3e0f1e63c0d3b08e0fc0.camel@adam-barratt.org.uk>
and subject line Closing p-u bugs for updates in 10.8
has caused the Debian Bug report #980133,
regarding buster-pu: package libdbd-csv-perl/0.5300-1+deb10u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
980133: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980133
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: carnil@debian.org,yadd@debian.org,elbrus@debian.org

[ Reason ]

After the fixes to libdbi-perl (pending for the point release) to
address #972180 / CVE-2014-10402, libdbd-csv-perl showed autopkgtest
failures as reported by Paul Gevers.

For unstable this was back when the CVE was addressed reported as
#974134.

[ Impact ]

libdbd-csv-perl would have test failures in t/11_dsnlist.t.

[ Tests ]

Full build for libdbd-csv-perl  with the upstream patch applied and
builded and tested with the libdbi-perl/1.642-1+deb10u2 version which
pending for the buster point release.

[ Risks ]

Should be, as the update fixes just the broken test and this fix was
in unstable for a while.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]

Apply upstream changes to t/11_dsnlist.t to work with the
CVE-2014-10402 fixes applied to libdbi-perl.

[ Other info ]

None

Regards,
Salvatore
diff -Nru libdbd-csv-perl-0.5300/debian/changelog libdbd-csv-perl-0.5300/debian/changelog
--- libdbd-csv-perl-0.5300/debian/changelog	2018-05-22 06:46:21.000000000 +0200
+++ libdbd-csv-perl-0.5300/debian/changelog	2021-01-14 22:56:01.000000000 +0100
@@ -1,3 +1,12 @@
+libdbd-csv-perl (0.5300-1+deb10u1) buster; urgency=medium
+
+  * Team upload.
+
+  [ Dominic Hargreaves ]
+  * Fix test failure with libdbi-perl 1.642-1+deb10u2 (Closes: #974134)
+
+ -- Salvatore Bonaccorso <carnil@debian.org>  Thu, 14 Jan 2021 22:56:01 +0100
+
 libdbd-csv-perl (0.5300-1) unstable; urgency=medium
 
   * Import upstream version 0.53
diff -Nru libdbd-csv-perl-0.5300/debian/patches/0001-f_dir-should-exist.patch libdbd-csv-perl-0.5300/debian/patches/0001-f_dir-should-exist.patch
--- libdbd-csv-perl-0.5300/debian/patches/0001-f_dir-should-exist.patch	1970-01-01 01:00:00.000000000 +0100
+++ libdbd-csv-perl-0.5300/debian/patches/0001-f_dir-should-exist.patch	2021-01-14 22:56:01.000000000 +0100
@@ -0,0 +1,38 @@
+From 88c3ca044a3881eab62d6d2d38490351fd421386 Mon Sep 17 00:00:00 2001
+From: "H.Merijn Brand - Tux" <linux@tux.freedom.nl>
+Date: Wed, 28 Oct 2020 15:56:53 +0100
+Subject: [PATCH] f_dir should exist
+
+From a CVE fix in DBI-1.644 / DBD::File-0.45
+---
+ t/11_dsnlist.t | 12 +++++++++++-
+ 1 file changed, 11 insertions(+), 1 deletion(-)
+
+diff --git a/t/11_dsnlist.t b/t/11_dsnlist.t
+index 8370976..3e97d45 100644
+--- a/t/11_dsnlist.t
++++ b/t/11_dsnlist.t
+@@ -24,9 +24,19 @@ ok (@dsn >= 2,					"more than one");
+ ok ($dbh->disconnect,				"disconnect");
+ 
+ # Try different DSN's
+-foreach my $d (qw( . example lib t )) {
++foreach my $d (qw( . examples lib t )) {
+     ok (my $dns = Connect ("dbi:CSV:f_dir=$d"),	"use $d as f_dir");
+     ok ($dbh->disconnect,			"disconnect");
+     }
+ 
++if ($DBD::File::VERSION ge "0.45") {
++    my @err;
++    is (eval {
++	local $SIG{__WARN__} = sub { push @err => @_ };
++	local $SIG{__DIE__}  = sub { push @err => @_ };
++	Connect ("dbi:CSV:f_dir=d/non/exist/here");
++	}, undef, "f_dir = nonexting dir");
++    like ("@err", qr{d/non/exist/here}, "Error caught");
++    }
++
+ done_testing ();
+-- 
+2.20.1
+
diff -Nru libdbd-csv-perl-0.5300/debian/patches/series libdbd-csv-perl-0.5300/debian/patches/series
--- libdbd-csv-perl-0.5300/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ libdbd-csv-perl-0.5300/debian/patches/series	2021-01-14 22:56:01.000000000 +0100
@@ -0,0 +1 @@
+0001-f_dir-should-exist.patch

--- End Message ---
--- Begin Message ---
Package: release.debian.org
Version: 10.8

Hi,

Each of the updates referenced by these bugs was included in today's
10.8 point release.

Regards,

Adam

--- End Message ---

Reply to: