Bug#968723: buster-pu: package incron/0.5.12-1+deb10u1
Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian.org@packages.debian.org
Usertags: pu
Hi,
I'd like to upload incron/0.5.12-1+deb10u1 to buster to fix #930526.
Incron creates a lot zombies processes and make the whole system
unstable.
The fix is pretty trivial (one line) and the patch has been taken from
upstream:
https://github.com/ar-/incron/pull/42/commits/196975d26fd04176a1c877fa3c404efd8103c9c2
Also see https://bugzilla.redhat.com/show_bug.cgi?id=1656939 and
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930526 for further
information.
The debdiff is attached.
Thanks,
diff -Nru incron-0.5.12/debian/changelog incron-0.5.12/debian/changelog
--- incron-0.5.12/debian/changelog 2019-02-19 02:44:46.000000000 +0000
+++ incron-0.5.12/debian/changelog 2019-12-02 22:20:07.000000000 +0000
@@ -1,3 +1,9 @@
+incron (0.5.12-1+deb10u1) buster; urgency=medium
+
+ * Add a patch to fix cleanup of zombie processes (Closes: #930526)
+
+ -- Emmanuel Bouthenot <kolter@debian.org> Mon, 02 Dec 2019 22:20:07 +0000
+
incron (0.5.12-1) unstable; urgency=medium
* New upstream release (Closes: #860199)
diff -Nru incron-0.5.12/debian/patches/02_prevent_zombies.patch incron-0.5.12/debian/patches/02_prevent_zombies.patch
--- incron-0.5.12/debian/patches/02_prevent_zombies.patch 1970-01-01 00:00:00.000000000 +0000
+++ incron-0.5.12/debian/patches/02_prevent_zombies.patch 2019-11-22 13:48:34.000000000 +0000
@@ -0,0 +1,28 @@
+Description: Prevent zombies
+Author: Mikhail Teterin <Mikhail.Teterin@Refinery29.com> (UnitedMarsupials on github)
+Forwarded: no
+Last-Update: 2019-11-12
+Origin: https://github.com/ar-/incron/pull/42 -> https://github.com/ar-/incron/pull/42/commits/196975d26fd04176a1c877fa3c404efd8103c9c2
+Bug-Debian: https://bugs.debian.org/930526
+
+From 196975d26fd04176a1c877fa3c404efd8103c9c2 Mon Sep 17 00:00:00 2001
+From: Mikhail T <Mikhail.Teterin@Refinery29.com>
+Date: Mon, 30 Oct 2017 14:15:03 -0400
+Subject: [PATCH 2/2] Rework the zombie prevention
+
+---
+ icd-main.cpp | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/icd-main.cpp b/icd-main.cpp
+index aef4d70..1e4d07f 100644
+--- a/icd-main.cpp
++++ b/icd-main.cpp
+@@ -104,6 +104,7 @@ void on_signal(int signo)
+ g_fFinish = true;
+ break;
+ case SIGCHLD:
++ do {} while (waitpid((pid_t)-1, 0, WNOHANG) > 0); /* Prevent zombies */
+ // first empty pipe (to prevent internal buffer overflow)
+ do {} while (read(g_cldPipe[0], g_cldPipeBuf, CHILD_PIPE_BUF_LEN) > 0);
+
diff -Nru incron-0.5.12/debian/patches/series incron-0.5.12/debian/patches/series
--- incron-0.5.12/debian/patches/series 2019-02-19 02:44:46.000000000 +0000
+++ incron-0.5.12/debian/patches/series 2019-11-22 13:48:34.000000000 +0000
@@ -1 +1,2 @@
01_manpages_typos
+02_prevent_zombies.patch
Reply to: