Bug#944538: buster-pu: package ganeti-instance-debootstrap/0.16-6.1

[Antoine Beaupré <anarcat@debian.org>]

On 2020-04-26 15:45:02, Julien Cristau wrote:
> On Fri, Feb 07, 2020 at 05:21:21PM -0500, Antoine Beaupré wrote:
>> [sorry for the dupe, hit send by mistake :(]
>> 
>> On 2019-11-24 12:13:20, Antoine Beaupré wrote:
>> > On 2019-11-23 18:34:25, Julien Cristau wrote:
>> >> I'm a bit uneasy about a blanket "include all", to be honest.  It's
>> >> probably harmless since it's all coming straight out of debootstrap, but
>> >> I'd have been happier with something like "include security.*" if that's
>> >> what we expect to see.
>> >
>> > What kind of problems would you expect with including too many ACLs?
>> 
>> I'm still curious to hear what kind of problems you expect here. I've
>> been running this patch in production for months now and would really
>> like to see this land in buster (and hopefully stretch next).
>> 
> I don't know, that's kind of the point.  For changes in stable I tend to
> err on the side of "if there's no demonstrated need for a change then it
> shouldn't be done".  Things like "because why not" tend to be red flags.

I don't know what to say here. I'm not familiar with the security.* flag
you are refering to, and I do not know whether it will fix my bug. I
also do not know if there are other similar bugs lurking that we just
haven't found yet, exactly about this.

It seems to me we should have the most faithful archive and recovery
when we do a snapshot. This is what this patch does.

You bring up the concern of "include all" yet you also explicitely say
that it's "probably harmless". So I'm truly confused as to why we're
still blocking on this. I understand we want to be conservative in
stable, but this is not like I'm introducing a 1000-line long patch
here.

I would argue that restricting the number of extended attributes is
*more* likely to create bugs than the opposite.

I will also mention that this has landed in buster ages ago, and no ill
effects were found there.

A.

-- 
Use for yourself little but give to others much.
                       - Albert Einstein