[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#956534: stretch-pu: package php-horde-form/2.0.15-1+deb9u2



On Sun, Apr 12, 2020 at 09:27:50AM -0400, Roberto C. Sanchez wrote:
> Package: release.debian.org
> Severity: normal
> Tags: stretch
> User: release.debian.org@packages.debian.org
> Usertags: pu
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> Please find attached a proposed debdiff for php-horde-form.  The change
> fixes CVE-2020-8866, which the security team has classified as <no-dsa>,
> deeming it a minor issue which can be fixed via a point release.  I have
> prepared this update in coordination with the security team.  May I have
> permission to upload to stretch-proposed-updates?
> 
Here is the patch.

-- 
Roberto C. Sánchez
diff -Nru php-horde-form-2.0.15/debian/changelog php-horde-form-2.0.15/debian/changelog
--- php-horde-form-2.0.15/debian/changelog	2019-06-16 07:47:48.000000000 -0400
+++ php-horde-form-2.0.15/debian/changelog	2020-03-24 13:54:47.000000000 -0400
@@ -1,3 +1,14 @@
+php-horde-form (2.0.15-1+deb9u2) stretch; urgency=high
+
+  * Fix CVE-2020-8866:
+    The Horde Application Framework contained a remote code execution
+    vulnerability. An authenticated remote attacker could use this flaw to
+    upload arbitrary content to an arbitrary writable location on the server
+    and potentially execute code in the context of the web server user.
+    (Closes: #955020)
+
+ -- Roberto C. Sanchez <roberto@debian.org>  Tue, 24 Mar 2020 13:54:47 -0400
+
 php-horde-form (2.0.15-1+deb9u1) stretch-security; urgency=high
 
   * Non-maintainer upload by the Security Team.
diff -Nru php-horde-form-2.0.15/debian/patches/0002-SECURITY-Prevent-ability-to-specify-temporary-filename.patch php-horde-form-2.0.15/debian/patches/0002-SECURITY-Prevent-ability-to-specify-temporary-filename.patch
--- php-horde-form-2.0.15/debian/patches/0002-SECURITY-Prevent-ability-to-specify-temporary-filename.patch	1969-12-31 19:00:00.000000000 -0500
+++ php-horde-form-2.0.15/debian/patches/0002-SECURITY-Prevent-ability-to-specify-temporary-filename.patch	2020-03-24 13:54:47.000000000 -0400
@@ -0,0 +1,35 @@
+From 35d382cc3a0482c07d0c2272cac89a340922e0a6 Mon Sep 17 00:00:00 2001
+From: Michael J Rubinsky <mrubinsk@horde.org>
+Date: Sun, 1 Mar 2020 14:46:49 -0500
+Subject: [PATCH] SECURITY: Prevent ability to specify temporary filename.
+
+Origin: https://github.com/horde/Form/commit/35d382cc3a0482c07d0c2272cac89a340922e0a6
+---
+ lib/Horde/Form/Type.php | 11 +++++------
+ 1 file changed, 5 insertions(+), 6 deletions(-)
+
+diff --git a/Horde_Form-2.0.15/lib/Horde/Form/Type.php b/Horde_Form-2.0.15/lib/Horde/Form/Type.php
+index f1e8157..e302d8d 100644
+--- a/Horde_Form-2.0.15/lib/Horde/Form/Type.php
++++ b/Horde_Form-2.0.15/lib/Horde/Form/Type.php
+@@ -1200,12 +1200,11 @@ class Horde_Form_Type_image extends Horde_Form_Type {
+             if (!empty($upload['hash'])) {
+                 $upload['img'] = $session->get('horde', 'form/' . $upload['hash']);
+                 $session->remove('horde', 'form/' . $upload['hash']);
+-            }
+-
+-            /* Get the temp file if already one uploaded, otherwise create a
+-             * new temporary file. */
+-            if (!empty($upload['img']['file'])) {
+-                $tmp_file = Horde::getTempDir() . '/' . basename($upload['img']['file']);
++                if (!empty($upload['img']['file'])) {
++                    $tmp_file = Horde::getTempDir() . '/' . basename($upload['img']['file']);
++                } else {
++                    $tmp_file = Horde::getTempFile('Horde', false);
++                }
+             } else {
+                 $tmp_file = Horde::getTempFile('Horde', false);
+             }
+-- 
+2.20.1
+
diff -Nru php-horde-form-2.0.15/debian/patches/series php-horde-form-2.0.15/debian/patches/series
--- php-horde-form-2.0.15/debian/patches/series	2019-06-16 07:46:47.000000000 -0400
+++ php-horde-form-2.0.15/debian/patches/series	2020-03-24 13:54:47.000000000 -0400
@@ -1 +1,2 @@
 0001-SECURITY-prevent-directory-traversal-vulnerability.patch
+0002-SECURITY-Prevent-ability-to-specify-temporary-filename.patch

Attachment: signature.asc
Description: PGP signature


Reply to: