Bug#953246: buster-pu: package openvswitch/2.10.0+2018.08.28+git.8ca7c82b7d+ds1-12+deb10u1
On 3/6/20 8:20 PM, Adam D. Barratt wrote:
> Control: tags -1 + confimred
>
> On Fri, 2020-03-06 at 14:15 +0100, Thomas Goirand wrote:
>> We experienced (in production) a bug in OVS which lead to ovs-
>> vswitchd being killed, leading to network downtime in our OpenStack
>> environment.
>> Attached is the fix. I wish to upload this update to Buster.
>
> That looks OK, but:
>
>> On top of this upstream fix, a small typo fix in ifupdown.sh.
>>
>
> --- openvswitch-2.10.0+2018.08.28+git.8ca7c82b7d+ds1/debian/ifupdown.sh 2019-06-24 08:53:33.000000000 +0200
> +++ openvswitch-2.10.0+2018.08.28+git.8ca7c82b7d+ds1/debian/ifupdown.sh 2019-09-19 14:40:49.000000000 +0200
> @@ -103,10 +103,10 @@
> ifdown --allow="${IFACE}" ${IF_OVS_PORTS}
> fi
>
> - ovs_vsctl -- --if-exists del-br "${IFACE}"
> + ovs-vsctl -- --if-exists del-br "${IFACE}"
> ;;
> OVSPort|OVSIntPort|OVSBond|OVSPatchPort|OVSTunnel)
> - ovs_vsctl -- --if-exists del-port "${IF_OVS_BRIDGE}" "${IFACE}"
> + ovs-vsctl -- --if-exists del-port "${IF_OVS_BRIDGE}" "${IFACE}"
>
> As far as I can see, the corresponding script in unstable is still full
> of calls to "ovs_vsctl" (admittedly, not the two list above):
>
> $ grep -c ovs_vsctl openvswitch-2.11.0+2019.06.25+git.9ebe795035+ds1/debian/ifupdown.sh
> 8
> $ grep -c ovs-vsctl openvswitch-2.11.0+2019.06.25+git.9ebe795035+ds1/debian/ifupdown.sh
> 4
>
> Feel free to go ahead with the proposed change, but you may want to
> consider fixing the remainder in unstable and then stable at some
> point.
>
> Regards,
>
> Adam
Hi Adam,
Thanks for the update review.
In fact, ovs_vsctl exists in this script, it's just a wrapper, but where
I added a thing, it really is ovs-vsctl that I wanted to call (ie:
without the timeout wrapper).
Uploaded...
Cheers,
Thomas Goirand (zigo)
Reply to: