[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#972694: marked as done (buster-pu: package node-object-path/0.11.4-2+deb10u1)

Your message dated Sat, 05 Dec 2020 11:02:00 +0000
with message-id <b70f86aac27195271a9b5212c7acc936da6ff100.camel@adam-barratt.org.uk>
and subject line Closing bugs for updates in 10.7 point release
has caused the Debian Bug report #972694,
regarding buster-pu: package node-object-path/0.11.4-2+deb10u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
972694: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972694
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian.org@packages.debian.org
Usertags: pu

[ Reason ]
node-object-path is vulnerable to a prototype pollution (CVE-2020-15256)

[ Impact ]
Little prototype vulnerability available

[ Tests ]
Upstream test change seems to big to be included here (see link in
patch).

[ Risks ]
Low risk, patch just adds a check on prototype

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
Just a new security check

diff --git a/debian/changelog b/debian/changelog
index f85777e..da6bfd9 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+node-object-path (0.11.4-2+deb10u1) buster; urgency=medium
+
+  * Team upload
+  * Fix prototype pollution in set() (Closes: CVE-2020-15256)
+
+ -- Xavier Guimard <yadd@debian.org>  Thu, 22 Oct 2020 18:38:10 +0200
+
 node-object-path (0.11.4-2) unstable; urgency=medium
 
   * Update Vcs fields for migration to https://salsa.debian.org/
diff --git a/debian/patches/CVE-2020-15256.diff b/debian/patches/CVE-2020-15256.diff
new file mode 100644
index 0000000..97ee479
--- /dev/null
+++ b/debian/patches/CVE-2020-15256.diff
@@ -0,0 +1,21 @@
+Description: Fix prototype pollution in set()
+Author: Mario Casciaro <mariocasciaro@gmail.com>
+Origin: upstream, https://github.com/mariocasciaro/object-path/commit/2be3354c6
+Bug: https://github.com/mariocasciaro/object-path/security/advisories/GHSA-cwx2-736x-mf6w
+Forwarded: not-needed
+Reviewed-By: Xavier Guimard <yadd@debian.org>
+Last-Update: 2020-10-22
+
+--- a/index.js
++++ b/index.js
+@@ -105,6 +105,10 @@
+       }
+       var currentPath = path[0];
+       var currentValue = getShallowProperty(obj, currentPath);
++      if (options.includeInheritedProps && (currentPath === '__proto__' ||
++        (currentPath === 'constructor' && typeof currentValue === 'function'))) {
++        throw new Error('For security reasons, object\'s magic properties cannot be set')
++      }
+       if (path.length === 1) {
+         if (currentValue === void 0 || !doNotReplace) {
+           obj[currentPath] = value;
diff --git a/debian/patches/series b/debian/patches/series
index f99effd..f80fc45 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 port-to-chai4.patch
+CVE-2020-15256.diff

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 10.7

Hi,

Each of the updates referenced by these bugs was included in this
morning's buster 10.7 point release.

Regards,

Adam

--- End Message ---
Reply to: