Bug#973736: buster-pu: package pulseaudio/12.2-4+deb10u2
Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: carnil@debian.org,fsateler@debian.org
Hi SRM, hi Felipe
[ Reason ]
pulseaudio's deamon.conf uses the (for that version of upstream) the
default of yes for flat-volumes. The flat-volumes value enables to
'flat' volumes, the sink volume equal the maximum of the volumes of
the inputs connected to it. But this can cause quite some surprised
and problems and can hurt ears depending on e.g. headphones values.
So some distributions have changed that already in past
and upstream did as well in later versions.
In unstable the change was done in the 13.0-3 upload.
[ Impact ]
So far users probably stumpling over the problem have changed away
form the default in their configuration.
[ Tests ]
I did test that the behaviour changed accordingly.
[ Risks ]
Low, the default value for flat-volume is changed to the one already
cherry-picked a while back in unstable and which represents as well
the default to which upstream switched.
[ Checklist ]
[x] *all* changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in (old)stable
[x] the issue is verified as fixed in unstable
[ Changes ]
Changes the default value for flat-volumes.
Is this okay to have backported to buster?
Regards,
Salvatore
diff -Nru pulseaudio-12.2/debian/changelog pulseaudio-12.2/debian/changelog
--- pulseaudio-12.2/debian/changelog 2019-08-15 17:21:19.000000000 +0200
+++ pulseaudio-12.2/debian/changelog 2020-11-04 08:56:04.000000000 +0100
@@ -1,3 +1,13 @@
+pulseaudio (12.2-4+deb10u2) buster; urgency=medium
+
+ * Non-maintainer upload.
+
+ [ Felipe Sateler ]
+ * Pick upstream patch disabling flat-volumes by default.
+ (Closes: #837637, #541538)
+
+ -- Salvatore Bonaccorso <carnil@debian.org> Wed, 04 Nov 2020 08:56:04 +0100
+
pulseaudio (12.2-4+deb10u1) buster; urgency=medium
* Pick upstream patch fixing mute state restoring (Closes: #913102)
diff -Nru pulseaudio-12.2/debian/patches/daemon-conf-disable-flat-volumes-by-default.patch pulseaudio-12.2/debian/patches/daemon-conf-disable-flat-volumes-by-default.patch
--- pulseaudio-12.2/debian/patches/daemon-conf-disable-flat-volumes-by-default.patch 1970-01-01 01:00:00.000000000 +0100
+++ pulseaudio-12.2/debian/patches/daemon-conf-disable-flat-volumes-by-default.patch 2020-11-04 08:56:04.000000000 +0100
@@ -0,0 +1,57 @@
+From: Tanu Kaskinen <tanuk@iki.fi>
+Date: Mon, 23 Sep 2019 07:48:48 +0300
+Subject: daemon-conf: disable flat-volumes by default
+
+Almost all distributions patch the configuration to disable
+flat-volumes, because users tend to find the concept confusing (and it
+also causes nasty surprises when some application pushes the volume to
+100%). Let's remove the need for patching and disable the feature by
+default.
+
+Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/691
+(cherry picked from commit ba73faa4c05717d74fbfd17e8175731e60d8841d)
+---
+ man/pulse-daemon.conf.5.xml.in | 2 +-
+ src/daemon/daemon-conf.c | 2 +-
+ src/daemon/daemon.conf.in | 2 +-
+ 3 files changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/man/pulse-daemon.conf.5.xml.in b/man/pulse-daemon.conf.5.xml.in
+index f49fa9b..1436126 100644
+--- a/man/pulse-daemon.conf.5.xml.in
++++ b/man/pulse-daemon.conf.5.xml.in
+@@ -237,7 +237,7 @@ License along with PulseAudio; if not, see <http://www.gnu.org/licenses/>.
+ <p><opt>flat-volumes=</opt> Enable 'flat' volumes, i.e. where
+ possible let the sink volume equal the maximum of the volumes of
+ the inputs connected to it. Takes a boolean argument, defaults
+- to <opt>yes</opt>.</p>
++ to <opt>no</opt>.</p>
+ </option>
+
+ </section>
+diff --git a/src/daemon/daemon-conf.c b/src/daemon/daemon-conf.c
+index 33cf7a7..e74b4ba 100644
+--- a/src/daemon/daemon-conf.c
++++ b/src/daemon/daemon-conf.c
+@@ -68,7 +68,7 @@ static const pa_daemon_conf default_conf = {
+ .realtime_priority = 5, /* Half of JACK's default rtprio */
+ .disallow_module_loading = false,
+ .disallow_exit = false,
+- .flat_volumes = true,
++ .flat_volumes = false,
+ .exit_idle_time = 20,
+ .scache_idle_time = 20,
+ .script_commands = NULL,
+diff --git a/src/daemon/daemon.conf.in b/src/daemon/daemon.conf.in
+index a955523..480608e 100644
+--- a/src/daemon/daemon.conf.in
++++ b/src/daemon/daemon.conf.in
+@@ -60,7 +60,7 @@ ifelse(@HAVE_DBUS@, 1, [dnl
+ ; enable-lfe-remixing = no
+ ; lfe-crossover-freq = 0
+
+-; flat-volumes = yes
++; flat-volumes = no
+
+ ifelse(@HAVE_SYS_RESOURCE_H@, 1, [dnl
+ ; rlimit-fsize = -1
diff -Nru pulseaudio-12.2/debian/patches/series pulseaudio-12.2/debian/patches/series
--- pulseaudio-12.2/debian/patches/series 2019-08-15 17:21:19.000000000 +0200
+++ pulseaudio-12.2/debian/patches/series 2020-11-04 08:56:04.000000000 +0100
@@ -3,3 +3,4 @@
alsa-mixer-Add-support-for-2018-Arctis-7.patch
Don-t-compile-with-ffast-math.patch
sink-source-Don-t-change-suspend-cause-when-unlinking.patch
+daemon-conf-disable-flat-volumes-by-default.patch
Reply to: