[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#946704: marked as done (stretch-pu: package php-horde/5.2.13+debian0-1+deb9u1)

Your message dated Sat, 08 Feb 2020 14:23:35 +0000
with message-id <a894a0233c2d264936953d7a69507573c4a5742a.camel@adam-barratt.org.uk>
and subject line Closing bugs included in 9.12
has caused the Debian Bug report #946704,
regarding stretch-pu: package php-horde/5.2.13+debian0-1+deb9u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
946704: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946704
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian.org@packages.debian.org
Usertags: pu

Please find attached a proposed debdiff for php-horde.  The change fixes
CVE-2019-12095, which the security team has classified as <no-dsa>,
deeming it a minor issue which can be fixed via a point release.  May I
have permission to upload to stretch-proposed-updates?

-- System Information:
Debian Release: 10.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-6-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru php-horde-5.2.13+debian0/debian/changelog php-horde-5.2.13+debian0/debian/changelog
--- php-horde-5.2.13+debian0/debian/changelog	2016-12-18 16:01:07.000000000 -0500
+++ php-horde-5.2.13+debian0/debian/changelog	2019-12-13 21:10:06.000000000 -0500
@@ -1,3 +1,9 @@
+php-horde (5.2.13+debian0-1+deb9u1) stretch; urgency=high
+
+  * Fix CVE-2019-12095: Stored XSS vuln in the Horde Cloud Block.
+
+ -- Roberto C. Sanchez <roberto@debian.org>  Fri, 13 Dec 2019 21:10:06 -0500
+
 php-horde (5.2.13+debian0-1) unstable; urgency=medium
 
   * New upstream version 5.2.13+debian0
diff -Nru php-horde-5.2.13+debian0/debian/patches/0002-CVE-2019-12095-Fix-XSS-vuln-in-the-Horde-Cloud-Block.patch php-horde-5.2.13+debian0/debian/patches/0002-CVE-2019-12095-Fix-XSS-vuln-in-the-Horde-Cloud-Block.patch
--- php-horde-5.2.13+debian0/debian/patches/0002-CVE-2019-12095-Fix-XSS-vuln-in-the-Horde-Cloud-Block.patch	1969-12-31 19:00:00.000000000 -0500
+++ php-horde-5.2.13+debian0/debian/patches/0002-CVE-2019-12095-Fix-XSS-vuln-in-the-Horde-Cloud-Block.patch	2019-12-13 21:10:06.000000000 -0500
@@ -0,0 +1,50 @@
+From 81a7b53973506856db67e7f0b0263be29528aa75 Mon Sep 17 00:00:00 2001
+From: Michael J Rubinsky <mrubinsk@horde.org>
+Date: Sat, 20 Apr 2019 17:34:41 -0400
+Subject: [PATCH] Fix XSS vuln in the Horde Cloud Block.
+
+---
+ horde-5.2.13/lib/Block/Cloud.php              | 6 +++++-
+ horde-5.2.13/services/portal/cloud_search.php | 2 +-
+ 2 files changed, 6 insertions(+), 2 deletions(-)
+
+diff --git a/horde-5.2.13/lib/Block/Cloud.php b/horde-5.2.13/lib/Block/Cloud.php
+index 92a44255..9df5bf3c 100644
+--- a/horde-5.2.13/lib/Block/Cloud.php
++++ b/horde-5.2.13/lib/Block/Cloud.php
+@@ -13,6 +13,10 @@ class Horde_Block_Cloud extends Horde_Core_Block
+         $this->_name = _("Tag Cloud");
+     }
+ 
++    protected function _escapeJs($string)
++    {
++        return str_replace("\n", '\n', str_replace('"', '\"', addcslashes(str_replace("\r", '', (string)$string), "\0..\37'\\")));
++    }
+     /**
+      */
+     protected function _content()
+@@ -21,7 +25,7 @@ class Horde_Block_Cloud extends Horde_Core_Block
+         foreach ($this->_getTags() as $tag) {
+             $cloud->addElement(
+                 $tag['tag_name'], '#', $tag['count'], null,
+-                'doSearch(\'' . $tag['tag_name'] . '\'); return false;');
++                'doSearch(\'' . htmlspecialchars($this->_escapeJs($tag['tag_name'])) . '\'); return false;');
+         }
+ 
+         Horde::startBuffer();
+diff --git a/horde-5.2.13/services/portal/cloud_search.php b/horde-5.2.13/services/portal/cloud_search.php
+index d72da96e..0d44b5a5 100644
+--- a/horde-5.2.13/services/portal/cloud_search.php
++++ b/horde-5.2.13/services/portal/cloud_search.php
+@@ -43,7 +43,7 @@ foreach ($results as $result) {
+     echo '<li class="linedRow"><span style="width:50%"> ' .
+          (empty($result['icon']) ? Horde_Themes_Image::tag(Horde_Themes::img($result['app'] . '.png', array('app' => $result['app'])), array('alt' => $result['app'])) : '') .
+          Horde::link($result['view_url'], '', '', '', '', '', '', array('style' => 'margin:4px')) .
+-         (empty($result['icon']) ? $result['title'] : '<img src="' . $result['icon'] . '" />') .
++         (empty($result['icon']) ? htmlspecialchars($result['title']) : '<img src="' . $result['icon'] . '" />') .
+          '</a></span><span style="width:50%;font-style:italic;">' . $result['desc'] . '</span></li>';
+ }
+ echo '</ul>';
+-- 
+2.20.1
+
diff -Nru php-horde-5.2.13+debian0/debian/patches/series php-horde-5.2.13+debian0/debian/patches/series
--- php-horde-5.2.13+debian0/debian/patches/series	2016-12-18 16:01:07.000000000 -0500
+++ php-horde-5.2.13+debian0/debian/patches/series	2019-12-13 21:10:06.000000000 -0500
@@ -1 +1,2 @@
 0001-Fix-rewrite-base.patch
+0002-CVE-2019-12095-Fix-XSS-vuln-in-the-Horde-Cloud-Block.patch

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 9.12

Hi,

Each of the uploads referred to by these bugs was included in today's
oldstable point release.

Regards,

Adam

--- End Message ---
Reply to: