[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7



On Mon, Jun 24, 2019 at 09:08:07PM +0200, Paul Gevers wrote:
[...]
> > The bug is not from upstream. Previously a file was removed from
> > upstream tarball, named engine/pkg/chrootarchive/archive_test.go, which
> > has an important init func:
[...]
> Are you saying this file is only needed for testing? This file isn't
> needed for docker.io itself? Why was it stripped in the first place?
> 

All files with _test.go suffix are for tests in Go.
The maintainer commented in debian/clean:

## Privileged tests:
...
engine/pkg/chrootarchive/archive_test.go

> > Well, after adding this func back, the tests run and the host doesn't
> > crash.
> > 
> > However the tests still can't pass in schroot, the log says:
> 
> [...]
> 
> > Short version: these tests need privileged permission.
> 
> And your schroot doesn't provide those. How about any better container?
> How about buildds?
> 

You can have privileged permission in container if you give it such
permission, like SYS_ADMIN permission, or in docker --privileged.

But none of buildds is allowed. It's too dangerous. Only VM is suitable
for such tests.

-- 
Shengjing Zhu

Attachment: signature.asc
Description: PGP signature


Reply to: