[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#930392: marked as done (unblock: ibus-sunpinyin/2.0.3+git20181120-4)

Your message dated Sat, 15 Jun 2019 11:27:33 +0000
with message-id <E1hc6qL-0004Ny-Av@respighi.debian.org>
and subject line unblock ibus-sunpinyin
has caused the Debian Bug report #930392,
regarding unblock: ibus-sunpinyin/2.0.3+git20181120-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
930392: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930392
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-CC: debian-input-method@lists.debian.org idaobing@gmail.com

Please unblock ibus-sunpinyin 2.0.3+git20181120-4. This upload fixes 
https://bugs.debian.org/929078 , which caused crash when the user is trying to
save settings for this input method.

The full debdiff is pasted below. Please let me know if there are any issues.

Regards,
Boyuan Yang

------------

diff -Nru ibus-sunpinyin-2.0.3+git20181120/debian/changelog ibus-sunpinyin-
2.0.3+git20181120/debian/changelog
--- ibus-sunpinyin-2.0.3+git20181120/debian/changelog   2018-11-20
15:38:43.000000000 -0500
+++ ibus-sunpinyin-2.0.3+git20181120/debian/changelog   2019-06-11
13:40:06.000000000 -0400
@@ -1,3 +1,29 @@
+ibus-sunpinyin (2.0.3+git20181120-4) unstable; urgency=medium
+
+  * Team upload.
+  * debian/patches/0003-Fix-upstream-issue-85: Rework again on the
+    patch to fix issues introduced in the previous uploads. (really
+    really closes: #929078).
+
+ -- Boyuan Yang <byang@debian.org>  Tue, 11 Jun 2019 13:40:06 -0400
+
+ibus-sunpinyin (2.0.3+git20181120-3) unstable; urgency=high
+
+  * Team upload.
+  * debian/patches/0003-Fix-upstream-issue-85: Rework on the patch
+    to fix issues introduced in the previous upload. (really
+    closes: #929078).
+
+ -- Boyuan Yang <byang@debian.org>  Tue, 11 Jun 2019 12:07:21 -0400
+
+ibus-sunpinyin (2.0.3+git20181120-2) unstable; urgency=high
+
+  * Team upload.
+  * debian/patches: Cherry-pick upstream patch to fix crashing
+    when trying to save user settings. (Closes: #929078)
+
+ -- Boyuan Yang <byang@debian.org>  Mon, 10 Jun 2019 12:41:17 -0400
+
 ibus-sunpinyin (2.0.3+git20181120-1) unstable; urgency=medium
 
   * Team upload.
diff -Nru ibus-sunpinyin-2.0.3+git20181120/debian/patches/0003-Fix-upstream-
issue-85-the-config-value-is-glib.Varia.patch ibus-sunpinyin-
2.0.3+git20181120/debian/patches/0003-Fix-upstream-issue-85-the-config-value-
is-glib.Varia.patch
--- ibus-sunpinyin-2.0.3+git20181120/debian/patches/0003-Fix-upstream-issue-
85-the-config-value-is-glib.Varia.patch     1969-12-31 19:00:00.000000000
-0500
+++ ibus-sunpinyin-2.0.3+git20181120/debian/patches/0003-Fix-upstream-issue-
85-the-config-value-is-glib.Varia.patch     2019-06-11 13:40:02.000000000
-0400
@@ -0,0 +1,64 @@
+From: Boyuan Yang <byang@debian.org>
+Date: Tue, 11 Jun 2019 12:06:51 -0400
+Subject: Fix upstream issue 85: the config value is glib.Variant
+
+Bug-Debian: https://bugs.debian.org/929078
+Forwarded: https://github.com/sunpinyin/sunpinyin/issues/85
+Applied-Upstream: https://github.com/sunpinyin/sunpinyin/pull/86
+Signed-off-by: LI Daobing <lidaobing@gmail.com>
+Signed-off-by: Boyuan Yang <byang@debian.org>
+Last-Update: 2019-06-11
+---
+ setup/main.py | 19 +++++++++++++++----
+ 1 file changed, 15 insertions(+), 4 deletions(-)
+
+diff --git a/setup/main.py b/setup/main.py
+index e20a3a5..aaa4a7d 100644
+--- a/setup/main.py
++++ b/setup/main.py
+@@ -39,10 +39,13 @@ import os
+ from os import path
+ try:
+     import gtk
++    import glib
+ except ImportError:
+     from gi import require_version as gi_require_version
+     gi_require_version('Gtk', '3.0')
++    gi_require_version('GLib', '2.0')
+     from gi.repository import Gtk as gtk
++    from gi.repository import GLib as glib
+ try:
+     import ibus
+ except ImportError:
+@@ -69,19 +72,27 @@ class Option(object):
+     it is used to synchronize the configuration with setting on user
interface
+     """
+     config = ibus.Bus().get_config()
+-    
++
++    __wrappers = {
++            type(True): glib.Variant.new_boolean,
++            type(1): glib.Variant.new_int32,
++            type('str'): glib.Variant.new_string,
++            type([]): glib.Variant.new_strv,
++    }
++
+     def __init__(self, name, default):
+         self.name = name
+         self.default = default
++        self.__wrap = self.__wrappers[type(self.default)]
+     
+     def read(self):
+         section, key = self.__get_config_name()
+-        return self.config.get_value(section, key, self.default)
++        wrapped = self.config.get_value(section, key)
++        return self.default if wrapped is None else wrapped.unpack()
+ 
+     def write(self, v):
+         section, key = self.__get_config_name()
+-        return self.config.set_value(section, key, type(self.default)(v))
+-
++        return self.config.set_value(section, key, self.__wrap(v))
+    
+     def __get_config_name(self):
+         keys = self.name.rsplit(SEPARATOR ,1)
diff -Nru ibus-sunpinyin-2.0.3+git20181120/debian/patches/series ibus-
sunpinyin-2.0.3+git20181120/debian/patches/series
--- ibus-sunpinyin-2.0.3+git20181120/debian/patches/series      2018-11-20
15:37:17.000000000 -0500
+++ ibus-sunpinyin-2.0.3+git20181120/debian/patches/series      2019-06-11
13:40:02.000000000 -0400
@@ -1,2 +1,3 @@
 libexecdir.patch
 0003-setup-ibus-setup-sunpinyin.in-Use-python3-explicitly.patch
+0003-Fix-upstream-issue-85-the-config-value-is-glib.Varia.patch

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
--- Begin Message --- 
Unblocked ibus-sunpinyin.

--- End Message ---
Reply to: