[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#930324: unblock: nageru/1.8.4-2



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package nageru

It contains a fix for an RC bug that is only seen with recent
versions of Mesa (but buster's Mesa is new enough). The fix
is a trivial backport from upstream git (I wrote it myself).

diff -Nru nageru-1.8.4/debian/patches/fix-mesa-glsl-cache-crashes.diff nageru-1.8.4/debian/patches/fix-mesa-glsl-cache-crashes.diff
--- nageru-1.8.4/debian/patches/fix-mesa-glsl-cache-crashes.diff	1970-01-01 01:00:00.000000000 +0100
+++ nageru-1.8.4/debian/patches/fix-mesa-glsl-cache-crashes.diff	2019-06-10 16:16:54.000000000 +0200
@@ -0,0 +1,26 @@
+Index: nageru-1.8.4/shared/context.cpp
+===================================================================
+--- nageru-1.8.4.orig/shared/context.cpp
++++ nageru-1.8.4/shared/context.cpp
+@@ -50,7 +50,20 @@ QOpenGLContext *create_context(const QSu
+ {
+ 	QOpenGLContext *context = new QOpenGLContext;
+ 	context->setShareContext(global_share_widget->context()->contextHandle());
+-	context->setFormat(surface->format());
++
++	// Qt has a bug (QTBUG-76299) where, when using EGL, the surface ignores
++	// the requested OpenGL context version and just becomes 2.0. Mesa honors
++	// this and gives us a 3.0 compatibility context, but then has a bug related
++	// to its shader cache (Mesa bug #110872) that causes spurious linker failures
++	// when we need to re-link a Movit shader in the same context. However,
++	// the surface itself doesn't use the OpenGL version in its format for anything,
++	// so we can just override it and get a proper context.
++	QSurfaceFormat fmt = surface->format();
++	fmt.setProfile(QSurfaceFormat::CoreProfile);
++	fmt.setMajorVersion(4);
++	fmt.setMinorVersion(5);
++	context->setFormat(fmt);
++
+ 	context->create();
+ 	return context;
+ }
diff -Nru nageru-1.8.4/debian/patches/series nageru-1.8.4/debian/patches/series
--- nageru-1.8.4/debian/patches/series	2018-12-30 20:11:40.000000000 +0100
+++ nageru-1.8.4/debian/patches/series	2019-06-10 16:15:00.000000000 +0200
@@ -1 +1,2 @@
 prefix-usr.diff
+fix-mesa-glsl-cache-crashes.diff

unblock nageru/1.8.4-2

-- System Information:
Debian Release: 10.0
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.1.2 (SMP w/40 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8), LANGUAGE=en_NO:en_US:en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)


Reply to: