[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#930158: marked as done (unblock: mailman-suite/0+20180916-8)



Your message dated Sat, 08 Jun 2019 09:53:00 +0000
with message-id <3f82282c-eb38-52f4-b347-b90eac7a0ee6@thykier.net>
and subject line Re: Bug#930158: unblock: mailman-suite/0+20180916-8
has caused the Debian Bug report #930158,
regarding unblock: mailman-suite/0+20180916-8
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
930158: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930158
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package mailman-suite

This upload fixes two bugs in mailman-suite with very small and
non-intrusive changes:

* #930133: The postinst script ran systemctl even on non-systemd systems
  during upgrade.
* #924629: Switch from ruby-sass to sassc. The upstream default was to
  use sassc anyway and ruby-sass became obsolete and abandoned
  recently[1]. Therefore, this change is security-relevant.

The debdiff is attached.

unblock mailman-suite/0+20180916-8

Thanks a lot for considering the unblock request.

Cheers
 jonas

[1] https://sass-lang.com/ruby-sass

-- System Information:
Debian Release: 10.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru mailman-suite-0+20180916/debian/changelog mailman-suite-0+20180916/debian/changelog
--- mailman-suite-0+20180916/debian/changelog	2019-03-12 13:07:32.000000000 +0100
+++ mailman-suite-0+20180916/debian/changelog	2019-06-07 20:03:29.000000000 +0200
@@ -1,4 +1,16 @@
-mailman-suite (0+20180916-7) unstable; urgency=medium
+mailman-suite (0+20180916-8) unstable; urgency=critical
+
+  * d/mailman3-web.postinst:
+    - Run 'systemctl daemon-reload' just if systemd is installed.
+      (Closes: #930133)
+  * d/control, d/patches/0001_settings_py.patch:
+    - Switch back from ruby-sass to sassc. Ruby-sass became unmaintained
+      and abandoned recently. Thanks to Christian Ehrhardt for bugreport
+      and patch. (Closes: #924629)
+
+ -- Jonas Meurer <jonas@freesources.org>  Fri, 07 Jun 2019 20:03:29 +0200
+
+mailman-suite (0+20180916-7) unstable; urgency=critical
 
   * d/templates, d/po/*.po, d/mailman3-web.{config,postinst}:
     - Remove the whole logic to configure django site domain and name via
@@ -7,7 +19,7 @@
   * d/mailman3-web-postinst:
     - Fix logic to run init_django at install and update_django at upgrade.
 
- -- Jonas Meurer <jonas@freesources.org>  Tue, 12 Mar 2019 13:07:32 +0100
+ -- Jonas Meurer <jonas@freesources.org>  Tue, 12 Mar 2019 13:20:15 +0100
 
 mailman-suite (0+20180916-6) unstable; urgency=medium
 
diff -Nru mailman-suite-0+20180916/debian/control mailman-suite-0+20180916/debian/control
--- mailman-suite-0+20180916/debian/control	2019-03-12 13:07:32.000000000 +0100
+++ mailman-suite-0+20180916/debian/control	2019-06-07 20:03:29.000000000 +0200
@@ -21,7 +21,7 @@
          python3-django-postorius,
          python3-psycopg2 | python3-mysqldb,
          python3-whoosh,
-         ruby-sass,
+         sassc,
          ucf,
          uwsgi,
          uwsgi-plugin-python3,
diff -Nru mailman-suite-0+20180916/debian/mailman3-web.postinst mailman-suite-0+20180916/debian/mailman3-web.postinst
--- mailman-suite-0+20180916/debian/mailman3-web.postinst	2019-03-12 13:07:32.000000000 +0100
+++ mailman-suite-0+20180916/debian/mailman3-web.postinst	2019-06-07 20:03:29.000000000 +0200
@@ -226,8 +226,8 @@
 
     # Remove superfluous systemd mailman3-web-qcluster service unit file
     if [ ! -z "$2" ] && dpkg --compare-versions "$2" le "0+20180916-4~"; then
-        systemctl --system daemon-reload >/dev/null || true
         if [ -d /run/systemd/system ]; then
+            systemctl --system daemon-reload >/dev/null || true
             deb-systemd-invoke stop 'mailman3-web-qcluster.service' >/dev/null || true
         fi
         deb-systemd-helper purge 'mailman3-web-qcluster.service' >/dev/null || true
diff -Nru mailman-suite-0+20180916/debian/patches/0001_settings_py.patch mailman-suite-0+20180916/debian/patches/0001_settings_py.patch
--- mailman-suite-0+20180916/debian/patches/0001_settings_py.patch	2019-03-12 13:07:32.000000000 +0100
+++ mailman-suite-0+20180916/debian/patches/0001_settings_py.patch	2019-06-07 20:03:29.000000000 +0200
@@ -12,7 +12,6 @@
 * Adjust 'DEFAULT_FROM_EMAIL' and 'SERVER_EMAIL'.
 * Use smtp email backend per default to send mails.
 * Set 'ACCOUNT_DEFAULT_HTTP_PROTOCOL' to 'https'.
-* Use 'sass' instead of 'sassc' as CSS precompiler.
 * Change logging level for most logging channels to 'INFO'.
 * Set queue polling inteval vor django-q cluster to 5 seconds (defaults
   to 0.2 seconds) to decrease the database load.
@@ -199,17 +198,6 @@
  }
  
  
-@@ -359,8 +351,8 @@ SOCIALACCOUNT_PROVIDERS = {
- #
- COMPRESS_PRECOMPILERS = (
-    ('text/less', 'lessc {infile} {outfile}'),
--   ('text/x-scss', 'sassc -t compressed {infile} {outfile}'),
--   ('text/x-sass', 'sassc -t compressed {infile} {outfile}'),
-+   ('text/x-scss', 'sass -t compressed {infile} {outfile}'),
-+   ('text/x-sass', 'sass -t compressed {infile} {outfile}'),
- )
- # On a production setup, setting COMPRESS_OFFLINE to True will bring a
- # significant performance improvement, as CSS files will not need to be
 @@ -379,7 +371,7 @@ COMPRESS_PRECOMPILERS = (
  HAYSTACK_CONNECTIONS = {
      'default': {

--- End Message ---
--- Begin Message ---
Jonas Meurer:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package mailman-suite
> 
> This upload fixes two bugs in mailman-suite with very small and
> non-intrusive changes:
> 
> * #930133: The postinst script ran systemctl even on non-systemd systems
>   during upgrade.
> * #924629: Switch from ruby-sass to sassc. The upstream default was to
>   use sassc anyway and ruby-sass became obsolete and abandoned
>   recently[1]. Therefore, this change is security-relevant.
> 
> The debdiff is attached.
> 
> unblock mailman-suite/0+20180916-8
> 
> Thanks a lot for considering the unblock request.
> 
> Cheers
>  jonas
> 
> [1] https://sass-lang.com/ruby-sass
> 
> [...]

Unblocked, thanks.
~Niels

--- End Message ---

Reply to: