[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#929342: unblock: aqemu/0.9.2-2.2



Control: tag -1 moreinfo

Hi,

On Wed, May 22, 2019 at 09:49:33AM +0530, Abhijith PA wrote:
> I reported a RC bug (#927126) against aqemu. Though its actual
> maintainer is not active for years, a debian contributor (Alexis
> Murzeau) fixed and filed a RFS(#929180) for a NMU. I've tested the
> package and uploaded to the unstable.
> 
> diff:
> https://salsa.debian.org/amurzeau-guest/aqemu/commit/5ce9cf29186a1f5d6ddcd8994351161de5ec76a7.diff

>From that diff:

+@@ -761,37 +749,37 @@
+
+ void Network_Widget::on_TB_Help_clicked()
+ {
+-	// -net nic[,vlan=n][,macaddr=addr][,model=type][,name=name]
++	// -net nic[,macaddr=addr][,model=type][,name=name]
+ 	if( ui.CB_Network_Type->currentText() == "nic" )
+-		QMessageBox::information( this, tr("nic"), tr("-net nic[,vlan=n][,macaddr=addr][,model=type][,name=name] \nCreate a new Network Interface Card and connect it to VLAN n (n = 0 is the default). The NIC is an ne2k_pci by default on the PC target. Optionally, the MAC address can be changed to addr and a name can be assigned for use in monitor commands. If no \'-net\' option is specified, a single NIC is created. Qemu can emulate several different models of network card. Valid values for type are i82551, i82557b, i82559er, ne2k_pci, ne2k_isa, pcnet, rtl8139, e1000, smc91c111, lance and mcf_fec. Not all devices are supported on all targets. Use -net nic,model=? for a list of available devices for your target.") );
++		QMessageBox::information( this, tr("nic"), tr("-net nic[,macaddr=addr][,model=type][,name=name] \nCreate a new Network Interface Card and connect it to Virtual LAN n (n = 0 is the default). The NIC is an ne2k_pci by default on the PC target. Optionally, the MAC address can be changed to addr and a name can be assigned for use in monitor commands. If no \'-net\' option is specified, a single NIC is created. Qemu can emulate several different models of network card. Valid values for type are i82551, i82557b, i82559er, ne2k_pci, ne2k_isa, pcnet, rtl8139, e1000, smc91c111, lance and mcf_fec. Not all devices are supported on all targets. Use -net nic,model=? for a list of available devices for your target.") );

This might benefit from another read; it seems to remove the vlan parameter
but still refer to it in the text? It's worth checking through for any
other similar instances.

Thanks,

-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51


Reply to: