[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#925203: marked as done (unblock: bpftrace/0.9-1)



Your message dated Thu, 9 May 2019 13:52:48 +0200
with message-id <a3a80dd9-ebbf-9d31-2975-9b1ceb59e35f@debian.org>
and subject line Re: unblock: bpftrace/0.9-1
has caused the Debian Bug report #925203,
regarding unblock: bpftrace/0.9-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
925203: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925203
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Please unblock package bpftrace

Upstream told me 0.9 is the first release where the API (to write
bpftrace code snippets) has been stabilized, so scripts and docs will
stop breaking. For example, there was the introduction of "elapsed"
variable to record the time since the beginning of the execution. Or
the use of the `struct` keyword (like in C) when casting. Without
these changes, scripts written by the community may not work on Debian
without adaptation. It would therefore be helpful we include this
release in the next Debian.

The package was never in a stable release. It entered testing the
first time a couple of months ago. It is a leaf package.

Here is the diffstat (full diff is too big).

#v+
 CHANGELOG.md                                                                   |  126 ++
 CMakeLists.txt                                                                 |   40
 INSTALL.md                                                                     |    5
 README.md                                                                      |   39
 cmake/FindLibBcc.cmake                                                         |   12
 debian/changelog                                                               |    7
 debian/patches/0001-Prevent-empty-trigger-functions-to-be-optimized-away.patch |   27
 debian/patches/0002-Detect-kernel-headers-even-if-they-are-splitted-into.patch |  174 ---
 debian/patches/series                                                          |    2
 docker/build.sh                                                                |    1
 docs/internals_development.md                                                  |    4
 docs/reference_guide.md                                                        |  541 +++++++---
 man/man8/bpftrace.8                                                            |   10
 src/CMakeLists.txt                                                             |    4
 src/arch/CMakeLists.txt                                                        |    6
 src/arch/aarch64.cpp                                                           |   92 +
 src/ast/ast.cpp                                                                |    8
 src/ast/ast.h                                                                  |   19
 src/ast/codegen_llvm.cpp                                                       |   80 +
 src/ast/codegen_llvm.h                                                         |    2
 src/ast/irbuilderbpf.cpp                                                       |   66 -
 src/ast/irbuilderbpf.h                                                         |    4
 src/ast/printer.cpp                                                            |    6
 src/ast/printer.h                                                              |    1
 src/ast/semantic_analyser.cpp                                                  |  255 +++-
 src/ast/semantic_analyser.h                                                    |   10
 src/attached_probe.cpp                                                         |   40
 src/bpforc.h                                                                   |    8
 src/bpftrace.cpp                                                               |  116 --
 src/bpftrace.h                                                                 |   18
 src/clang_parser.cpp                                                           |   58 -
 src/fake_map.cpp                                                               |   11
 src/fake_map.h                                                                 |    1
 src/lexer.l                                                                    |   30
 src/list.cpp                                                                   |   49
 src/list.h                                                                     |    3
 src/main.cpp                                                                   |   65 -
 src/map.cpp                                                                    |   64 -
 src/map.h                                                                      |    3
 src/mapkey.cpp                                                                 |   31
 src/parser.yy                                                                  |   84 -
 src/struct.h                                                                   |    4
 src/tracepoint_format_parser.cpp                                               |   99 +
 src/tracepoint_format_parser.h                                                 |  109 +-
 src/triggers.h                                                                 |    4
 src/types.cpp                                                                  |    5
 src/types.h                                                                    |   52
 src/utils-inl.h                                                                |    8
 src/utils.cpp                                                                  |  106 +
 src/utils.h                                                                    |   37
 tests/CMakeLists.txt                                                           |    5
 tests/bpftrace.cpp                                                             |   76 -
 tests/clang_parser.cpp                                                         |  140 +-
 tests/codegen.cpp                                                              |    5
 tests/codegen/args_multiple_tracepoints.cpp                                    |  242 ++++
 tests/codegen/builtin_elapsed.cpp                                              |   24
 tests/codegen/builtin_probe_wild.cpp                                           |    2
 tests/codegen/call_cgroup.cpp                                                  |    4
 tests/codegen/call_kstack.cpp                                                  |  120 ++
 tests/codegen/call_ustack.cpp                                                  |  126 ++
 tests/codegen/general.cpp                                                      |   14
 tests/codegen/map_key_probe.cpp                                                |   96 +
 tests/codegen/string_equal_comparison.cpp                                      |   74 -
 tests/codegen/string_not_equal_comparison.cpp                                  |   74 -
 tests/codegen/variable_undeclared.cpp                                          |   43
 tests/parser.cpp                                                               |   68 +
 tests/probe.cpp                                                                |    2
 tests/runtime/builtin                                                          |   26
 tests/runtime/call                                                             |   36
 tests/runtime/other                                                            |   10
 tests/runtime/probe                                                            |   33
 tests/runtime/variable                                                         |    4
 tests/semantic_analyser.cpp                                                    |   25
 tests/utils.cpp                                                                |   19
 tools/biosnoop.bt                                                              |    8
 tools/dcsnoop.bt                                                               |    9
 tools/execsnoop.bt                                                             |    9
 tools/mdflush.bt                                                               |    3
 tools/oomkill.bt                                                               |    2
 tools/runqlen.bt                                                               |    4
 tools/tcpaccept.bt                                                             |    2
 tools/tcpconnect.bt                                                            |    2
 tools/tcpdrop.bt                                                               |   41
 tools/tcpretrans.bt                                                            |   39
 84 files changed, 2846 insertions(+), 1087 deletions(-)
#v-

On Debian side, except removing the two patches implemented upstream,
there is nothing else than the update of debian/changelog.

#v+
diff -Nru bpftrace-0.8+git60-gccac69c2239b/debian/changelog bpftrace-0.9/debian/changelog
- --- bpftrace-0.8+git60-gccac69c2239b/debian/changelog   2019-02-22 15:10:27.000000000 +0100
+++ bpftrace-0.9/debian/changelog       2019-03-16 19:07:56.000000000 +0100
@@ -1,3 +1,10 @@
+bpftrace (0.9-1) unstable; urgency=medium
+
+  * New upstream release.
+  * d/patches: drop all patches, applied upstream.
+
+ -- Vincent Bernat <bernat@debian.org>  Sat, 16 Mar 2019 19:07:56 +0100
+
 bpftrace (0.8+git60-gccac69c2239b-2) unstable; urgency=medium

   * d/patches: add patch to avoid optimizing away BEGIN/END trigger
#v-

Thanks!

unblock bpftrace/0.9-1

- -- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (101, 'experimental-debug'), (101, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-4-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8), LANGUAGE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCAAwFiEErvI0h2bzccaJpzYAlaQv6DU1JfkFAlyTSM8SHGJlcm5hdEBk
ZWJpYW4ub3JnAAoJEJWkL+g1NSX5iqMP+waMJ63uJ+1hXvhjIR0QXyggRkzfBRSF
9lEPnzQtl48ZbDgf8t8F5/zZPQecbTjh1apFUJMXoJ9HrBA/r86p0PD2fGaCtA1d
6vK48ULEKvxY1q+bWPYLMermnh4v6Nngp141pIVyrY/ZUaDFxJpc2pIKNuNLbuU7
q+gh2kih7K6KDBEYlyYbvsfD08oWH4nG15LzFJT2rfvRG1ehrJDa9/nqDdsGmgKq
uj4x3TgI5V9udS2wTzA4XAvWYIDZzrS0PBI+B2o3jISsSTu2fhJnPxOcQmlvvOK/
FicA9PgHQ+3Og60UCtlRoNEGYkPj5/jyd9bEqS+gBnzhWt7UU9+/PdQ4e2QuoBrl
NtTvAu7aVdB9doP8kc4Ojm7quipJhkx3ChLQPHTgEyEPpzgjLNIVQl/Dex5Z6OG7
U49jaEimSAw5gbfm6ofr36cr9E1JMgZ2U7ATI7DAF1GqYCBven6o6b+dfjdTpGm9
ccK6XigQRpuTCSiAU6tFHKb+2WnY9e1p3eXCrLIXT8aVBvw4v/McHy9euIqW2X8d
MGiDP7IqG3nrLDB1HFmv/ThrHvfJbb/OEUwTlUGv5FTW6X1JPqTuczjsb83qllll
ItSIOQIhzIMh0Vouzwuu4Qth9L1nOofdAPouLO3qxkkrE3lhBKHh5lopdSxzya64
qmNnDPSy/Ake
=r8cq
-----END PGP SIGNATURE-----

--- End Message ---
--- Begin Message ---
Hi Vincent,

On 09-05-2019 12:17, Vincent Bernat wrote:
>  ❦  9 mai 2019 10:28 +02, Paul Gevers <elbrus@debian.org>:
> 
>> I fear you're not going to like my mail, sorry.
> 
> No problem!

Good to hear. Thanks for understanding.

[...]

>> Indeed. At this stage of the release, we are very reluctant to let new
>> upstream versions into buster. Therefor I don't want to unblock this
>> request. However, given the statements above, should we then be shipping
>> bpftrace as all in buster? In my opinion, this is material for
>> bullseye.
> 
> I'll ask upstream what he thinks of that. It's still an amazing tool to
> have.

It means that I now close this bug. If you think the package should
*not* be in buster, please file an RC bug against your package. In that
case you may want to ping us to remove it.

Paul

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---

Reply to: