[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#928496: marked as done (unblock: haveged/1.9.1-7)

Your message dated Mon, 06 May 2019 20:10:00 +0000
with message-id <d808f408-074a-ec52-d289-7e8d7fdb9332@thykier.net>
and subject line Re: Bug#928496: unblock: haveged/1.9.1-7
has caused the Debian Bug report #928496,
regarding unblock: haveged/1.9.1-7
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
928496: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=928496
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi,

Please review the haveged udeb addition that I've implemented to fix
entropy starvation issues in d-i. There are other changes in d-i
components to leverage this addition (in rootskel and debian-installer)
that I'm fine with vetting myself since they're clearly under the
installer team umbrella (unless you instruct otherwise).

haveged isn't directly maintained by us and even if the maintainer
gave me carte blanche[1], I'd be more content with a review from the
release team.

 1. https://bugs.debian.org/927376#10


Changelog excerpt (full source debdiff attached):

,---
| haveged (1.9.1-7) unstable; urgency=medium
| 
|   [ Cyril Brulebois ]
|   * Add haveged-udeb, for use from the Debian Installer (See: #923675,
|     Closes: #927376).
|   * Bundle the daemon and the library in haveged-udeb, since the daemon
|     is the only user of the libhavege.so.1 SONAME.
| 
|   [ Ondřej Nový ]
|   * d/control: Set Vcs-* to salsa.debian.org
| 
|  -- Cyril Brulebois <kibi@debian.org>  Fri, 19 Apr 2019 18:29:05 +0200
`---


If that looks fine, feel free to:

  unblock haveged/1.9.1-7
  unblock-udeb haveged/1.9.1-7


Thanks for your time!


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

diff -Nru haveged-1.9.1/debian/changelog haveged-1.9.1/debian/changelog
--- haveged-1.9.1/debian/changelog	2017-07-17 16:05:45.000000000 +0000
+++ haveged-1.9.1/debian/changelog	2019-04-19 16:29:05.000000000 +0000
@@ -1,3 +1,16 @@
+haveged (1.9.1-7) unstable; urgency=medium
+
+  [ Cyril Brulebois ]
+  * Add haveged-udeb, for use from the Debian Installer (See: #923675,
+    Closes: #927376).
+  * Bundle the daemon and the library in haveged-udeb, since the daemon
+    is the only user of the libhavege.so.1 SONAME.
+
+  [ Ondřej Nový ]
+  * d/control: Set Vcs-* to salsa.debian.org
+
+ -- Cyril Brulebois <kibi@debian.org>  Fri, 19 Apr 2019 18:29:05 +0200
+
 haveged (1.9.1-6) unstable; urgency=high
 
   * Start haveged.service after systemd-tmpfiles-setup.service has been run.
diff -Nru haveged-1.9.1/debian/control haveged-1.9.1/debian/control
--- haveged-1.9.1/debian/control	2017-07-17 15:42:46.000000000 +0000
+++ haveged-1.9.1/debian/control	2019-04-18 16:32:42.000000000 +0000
@@ -5,8 +5,8 @@
 Build-Depends: debhelper (>= 9), dh-apparmor, dh-autoreconf, dh-systemd
 Standards-Version: 3.9.8
 Homepage: http://issihosts.com/haveged/
-Vcs-Git: https://alioth.debian.org/anonscm/git/collab-maint/haveged.git
-Vcs-Browser: https://anonscm.debian.org/gitweb/?p=collab-maint/haveged.git
+Vcs-Git: https://salsa.debian.org/debian/haveged.git
+Vcs-Browser: https://salsa.debian.org/debian/haveged
 
 Package: haveged
 Architecture: linux-any
@@ -71,3 +71,11 @@
  http://www.irisa.fr/caps/projects/hipsor/
  .
  This package contains the development files.
+
+Package: haveged-udeb
+Package-Type: udeb
+Section: debian-installer
+Architecture: linux-any
+Depends: ${shlibs:Depends}
+Description: Linux entropy source using the HAVEGE algorithm -- udeb
+ This package is for use in the Debian Installer.
diff -Nru haveged-1.9.1/debian/haveged-udeb.install haveged-1.9.1/debian/haveged-udeb.install
--- haveged-1.9.1/debian/haveged-udeb.install	1970-01-01 00:00:00.000000000 +0000
+++ haveged-1.9.1/debian/haveged-udeb.install	2019-04-16 22:25:12.000000000 +0000
@@ -0,0 +1,2 @@
+usr/sbin/haveged
+usr/lib/*/libhavege.so.*
diff -Nru haveged-1.9.1/debian/shlibs.local haveged-1.9.1/debian/shlibs.local
--- haveged-1.9.1/debian/shlibs.local	1970-01-01 00:00:00.000000000 +0000
+++ haveged-1.9.1/debian/shlibs.local	2019-04-16 22:45:49.000000000 +0000
@@ -0,0 +1,4 @@
+# No need to ship a separate libhavege1-udeb, so bundle the daemon and
+# the library in the same udeb (haveged-udeb), and let shlibs:Depends
+# computation know where libhavege.so.1 is shipped:
+udeb: libhavege 1 haveged-udeb

--- End Message ---
--- Begin Message --- 
Cyril Brulebois:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Hi,
> 
> Please review the haveged udeb addition that I've implemented to fix
> entropy starvation issues in d-i. There are other changes in d-i
> components to leverage this addition (in rootskel and debian-installer)
> that I'm fine with vetting myself since they're clearly under the
> installer team umbrella (unless you instruct otherwise).
> 
> haveged isn't directly maintained by us and even if the maintainer
> gave me carte blanche[1], I'd be more content with a review from the
> release team.
> 
> [...]
> 
> If that looks fine, feel free to:
> 
>   unblock haveged/1.9.1-7
>   unblock-udeb haveged/1.9.1-7
> 
> 
> Thanks for your time!
> 
> 
> Cheers,
> 

Unblocked, thanks.
~Niels

--- End Message ---
Reply to: