[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#941468: marked as done (buster-pu: package plasma-applet-redshift-control/1.0.18-2+deb10u1)

Your message dated Sat, 16 Nov 2019 10:08:47 +0000
with message-id <83c9ffab6f08361485f70dda4733a7a24aeec09b.camel@adam-barratt.org.uk>
and subject line Closing bugs for 10.2 point release fixes
has caused the Debian Bug report #941468,
regarding buster-pu: package plasma-applet-redshift-control/1.0.18-2+deb10u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
941468: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=941468
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian.org@packages.debian.org
Usertags: pu

The redshift plasma applet doesn't work correctly in buster due to a wrong use
of `redshift` arguments; see #910901 "plasma-applet-redshift-control: Mouse
wheel only reduces color temperature, in either direction".

This was fixed with the exact same patch in unstable; and the debdiff is
attached.

Thanks for considering!

Cheers,
	OdyX

diff -Nru plasma-applet-redshift-control-1.0.18/debian/changelog plasma-applet-redshift-control-1.0.18/debian/changelog
--- plasma-applet-redshift-control-1.0.18/debian/changelog	2018-02-22 07:16:23.000000000 +0100
+++ plasma-applet-redshift-control-1.0.18/debian/changelog	2019-10-01 09:26:56.000000000 +0200
@@ -1,3 +1,10 @@
+plasma-applet-redshift-control (1.0.18-2+deb10u1) buster; urgency=medium
+
+  * Import upstream-submitted patch to fix manual mode for redshift
+    >= 1.12 (Closes: #910901)
+
+ -- Didier Raboud <odyx@debian.org>  Tue, 01 Oct 2019 09:26:56 +0200
+
 plasma-applet-redshift-control (1.0.18-2) unstable; urgency=medium
 
   * Team upload.
diff -Nru plasma-applet-redshift-control-1.0.18/debian/.gitattributes plasma-applet-redshift-control-1.0.18/debian/.gitattributes
--- plasma-applet-redshift-control-1.0.18/debian/.gitattributes	1970-01-01 01:00:00.000000000 +0100
+++ plasma-applet-redshift-control-1.0.18/debian/.gitattributes	2019-10-01 09:26:56.000000000 +0200
@@ -0,0 +1 @@
+changelog merge=dpkg-mergechangelogs
diff -Nru plasma-applet-redshift-control-1.0.18/debian/patches/fix-manual-mode-for-redshift-1.12.patch plasma-applet-redshift-control-1.0.18/debian/patches/fix-manual-mode-for-redshift-1.12.patch
--- plasma-applet-redshift-control-1.0.18/debian/patches/fix-manual-mode-for-redshift-1.12.patch	1970-01-01 01:00:00.000000000 +0100
+++ plasma-applet-redshift-control-1.0.18/debian/patches/fix-manual-mode-for-redshift-1.12.patch	2019-10-01 09:26:56.000000000 +0200
@@ -0,0 +1,58 @@
+Description: Redshift version >= 1.12 requires the -P option to clear the existing gamma ramps for one-shot mode. Without it the screen gets darker and darker until it is impossible to see anything.
+
+Quoting from the redshift 1.12 manual page:
+
+    -O TEMP One-shot manual mode (set color temperature). Use this with the -P option to clear the existing gamma ramps before applying the new color temperature.
+    -P Reset existing gamma ramps before applying new color effect.
+
+This is a cherry-pick from the fix submitted upstream at https://phabricator.kde.org/D23330 
+
+Author: Melvin Vermeeren <mail@mel.vin>
+Bug: https://bugs.kde.org/show_bug.cgi?id=395641
+Bug-Debian: https://bugs.debian.org/910901
+Last-Update: 2019-09-28
+
+--- a/package/contents/ui/CompactRepresentation.qml
++++ b/package/contents/ui/CompactRepresentation.qml
+@@ -48,6 +48,8 @@
+     property color redshiftColour: '#ff3c0b'
+     property color brightnessColour: '#39a2ee'
+ 
++    property string versionString: 'N/A'
++
+     PlasmaCore.IconItem {
+         id: customIcon
+         anchors.fill: parent
+@@ -136,7 +138,11 @@
+                     }
+                 }
+             }
+-            redshiftDS.connectedSources.push(redshiftOneTimeCommand)
++            if (parseFloat(versionString) >= 1.12) {
++                redshiftDS.connectedSources.push(redshiftOneTimeCommand + " -P")
++            } else {
++                redshiftDS.connectedSources.push(redshiftOneTimeCommand)
++            }
+         }
+ 
+         onClicked: {
+@@ -169,4 +175,19 @@
+         }
+     }
+ 
++    PlasmaCore.DataSource {
++        id: getOptionsDS
++        engine: 'executable'
++
++        connectedSources: ['redshift -V']
++
++        onNewData: {
++            connectedSources.length = 0
++            if (data['exit code'] > 0) {
++                print('Error running redshift with command: ' + sourceName + '   ...stderr: ' + data.stderr)
++                return
++            }
++            versionString = data.stdout.split(' ')[1]
++        }
++    }
+ }
diff -Nru plasma-applet-redshift-control-1.0.18/debian/patches/series plasma-applet-redshift-control-1.0.18/debian/patches/series
--- plasma-applet-redshift-control-1.0.18/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ plasma-applet-redshift-control-1.0.18/debian/patches/series	2019-10-01 09:26:56.000000000 +0200
@@ -0,0 +1 @@
+fix-manual-mode-for-redshift-1.12.patch

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 10.2

Hi,

The fixes referenced by these bugs were included in today's 10.2 stable
point release.

Regards,

Adam

--- End Message ---
Reply to: