Bug#939738: buster-pu: package aegisub/3.2.2+dfsg-4+deb10u1
Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian.org@packages.debian.org
Usertags: pu
Hello,
I am requesting permission to upload aegisub to buster-pu. This new
version adds a build dependency (libhunspell-dev) to fix a SEGV and a
patch to fix a crash when picking a spell language from a position bigger
than 100 in the languages list. Both problems were reported in #935724.
A debdiff is attached.
Thanks,
Aniol
diff -Nru aegisub-3.2.2+dfsg/debian/changelog aegisub-3.2.2+dfsg/debian/changelog
--- aegisub-3.2.2+dfsg/debian/changelog 2018-12-20 16:40:35.000000000 +0100
+++ aegisub-3.2.2+dfsg/debian/changelog 2019-09-05 11:29:42.000000000 +0200
@@ -1,3 +1,11 @@
+aegisub (3.2.2+dfsg-4+deb10u1) buster; urgency=medium
+
+ * Add libhunspell-dev to Build-Depends (fixes SEGV).
+ * Apply patch provided in #935724.
+ * Closes: #935724.
+
+ -- Aniol Marti <amarti@caliu.cat> Thu, 05 Sep 2019 09:29:42 +0000
+
aegisub (3.2.2+dfsg-4) unstable; urgency=medium
[ Gunnar Wolf ]
diff -Nru aegisub-3.2.2+dfsg/debian/control aegisub-3.2.2+dfsg/debian/control
--- aegisub-3.2.2+dfsg/debian/control 2018-12-17 19:00:20.000000000 +0100
+++ aegisub-3.2.2+dfsg/debian/control 2019-09-05 11:29:42.000000000 +0200
@@ -26,7 +26,8 @@
libluajit-5.1-common,
libluajit-5.1-dev,
liblua5.1-0-dev,
- libasound2-dev
+ libasound2-dev,
+ libhunspell-dev
Standards-Version: 4.2.1
Homepage: http://www.aegisub.org/
Vcs-Git: https://salsa.debian.org/debian/aegisub.git
diff -Nru aegisub-3.2.2+dfsg/debian/patches/fix-crash-spell-language.patch aegisub-3.2.2+dfsg/debian/patches/fix-crash-spell-language.patch
--- aegisub-3.2.2+dfsg/debian/patches/fix-crash-spell-language.patch 1970-01-01 01:00:00.000000000 +0100
+++ aegisub-3.2.2+dfsg/debian/patches/fix-crash-spell-language.patch 2019-09-05 11:29:42.000000000 +0200
@@ -0,0 +1,49 @@
+From 4200b85fb49f43168941d717a3cd325bd8c6c4a3 Mon Sep 17 00:00:00 2001
+From: scx <scx.mail@gmail.com>
+Date: Sun, 1 Sep 2019 23:40:47 +0200
+Subject: [PATCH] Fix crashing when picking language
+
+Aegisub crashes immediately after selecting any language
+from the end of the list (above the 100th position).
+This is because it can support no more than 100 languages.
+This patch extends this limit up to 1000 languages (locales).
+
+Fixes Aegisub/Aegisub#131
+---
+ src/subs_edit_ctrl.cpp | 8 ++++++--
+ 1 file changed, 6 insertions(+), 2 deletions(-)
+
+diff --git a/src/subs_edit_ctrl.cpp b/src/subs_edit_ctrl.cpp
+index 1a87c147c..d41cd24d0 100644
+--- a/src/subs_edit_ctrl.cpp
++++ b/src/subs_edit_ctrl.cpp
+@@ -56,6 +56,10 @@
+ #include <wx/menu.h>
+ #include <wx/settings.h>
+
++// Maximum number of languages (locales)
++// It should be above 100 (at least 242) and probably not more than 1000
++#define LANGS_MAX 1000
++
+ /// Event ids
+ enum {
+ EDIT_MENU_SPLIT_PRESERVE = 1400,
+@@ -73,7 +77,7 @@ enum {
+ EDIT_MENU_THESAURUS_SUGS,
+ EDIT_MENU_DIC_LANGUAGE = 1600,
+ EDIT_MENU_DIC_LANGS,
+- EDIT_MENU_THES_LANGUAGE = 1700,
++ EDIT_MENU_THES_LANGUAGE = EDIT_MENU_DIC_LANGUAGE + LANGS_MAX,
+ EDIT_MENU_THES_LANGS
+ };
+
+@@ -196,7 +200,7 @@ BEGIN_EVENT_TABLE(SubsTextEditCtrl,wxStyledTextCtrl)
+ EVT_MENU_RANGE(EDIT_MENU_SUGGESTIONS,EDIT_MENU_THESAURUS-1,SubsTextEditCtrl::OnUseSuggestion)
+ EVT_MENU_RANGE(EDIT_MENU_THESAURUS_SUGS,EDIT_MENU_DIC_LANGUAGE-1,SubsTextEditCtrl::OnUseSuggestion)
+ EVT_MENU_RANGE(EDIT_MENU_DIC_LANGS,EDIT_MENU_THES_LANGUAGE-1,SubsTextEditCtrl::OnSetDicLanguage)
+- EVT_MENU_RANGE(EDIT_MENU_THES_LANGS,EDIT_MENU_THES_LANGS+100,SubsTextEditCtrl::OnSetThesLanguage)
++ EVT_MENU_RANGE(EDIT_MENU_THES_LANGS,EDIT_MENU_THES_LANGS+LANGS_MAX,SubsTextEditCtrl::OnSetThesLanguage)
+ END_EVENT_TABLE()
+
+ void SubsTextEditCtrl::OnLoseFocus(wxFocusEvent &event) {
+
diff -Nru aegisub-3.2.2+dfsg/debian/patches/series aegisub-3.2.2+dfsg/debian/patches/series
--- aegisub-3.2.2+dfsg/debian/patches/series 2018-12-17 19:00:20.000000000 +0100
+++ aegisub-3.2.2+dfsg/debian/patches/series 2019-09-05 11:29:42.000000000 +0200
@@ -14,3 +14,4 @@
add-icu-prefix.patch
simplify-version.patch
add-keywords-desktop.patch
+fix-crash-spell-language.patch
Reply to: