Bug#935809: Re: buster-pu: package fdroidserver_1.1.4-1~deb10u1
Control: tags -1 + moreinfo
Your report did not make it to debian-release due to the large size of
the attachment. I had to download the mbox from the BTS is order to
reply, which makes me quite surprised to see that you already decided
to upload the package.
On Mon, 2019-08-26 at 14:54 +0200, Hans-Christoph Steiner wrote:
> I have been working on polishing this package for buster since March,
> but I didn't make the freeze cutoff. I'm part of upstream, and we
> did
> our Debian/buster bug fix work in our stable 1.1.x branch, so the
> changes are mostly in the upstream source tarball.
>
> The debdiff is long, but the actual code changes are quite short.
If the changes are short, why were they not made in time for buster?
> What
> makes the debdiff long is the cruft that were removed upstream in the
> source tarball due to a cleanup (see diffstat).
Are you really saying that what looks from the diff like dropping all
localisation support is cruft cleanup? I feel like I may be missing
something.
In any case, cleaning up cruft by removing 60K lines of files from your
source package is generally not the sort of thing that would be
expected in a stable update.
> The next largest block of changes is fixes to the test suite to work
> properly on Debian/buster.
> The remaining changes are compatibility fixes related to:
>
> 929905: incompatible with upstream's data repository
[...]
> ### 1.1.4 (2019-08-15)
>
> * include bitcoin validation regex required by fdroiddata
As someone who knows nothing about fdroiddata, you may have to explain
why this is actually a problem. This is the sort of information that
should be in the request. To be honest, I'd have expected your upstream
diff and changelog to have included more information than that one
line.
Please provide a diff that only includes the non-"cruft" changes, so
there's a chance of us knowing what you're actually changing.
Regards,
Adam
Reply to: