Hi there Simon,
thanks for the detailed investigation.
Le samedi, 24 août 2019, 11.52:53 h CEST Simon McVittie a écrit :
> On Fri, 23 Aug 2019 at 18:35:59 +0200, Didier 'OdyX' Raboud wrote:
> > I have uploaded win32-loader to buster to fix the out-of-sync archive
> > keys, but it has now repeatedly failed to build from source on the buster
> > buildds:
> >
> > https://buildd.debian.org/status/logs.php?pkg=win32-loader&ver=0.9.4%2Bdeb
> > 10u1
> >
> > I can't reproduce this in a local buster schroot, so I'm slightly at loss.
>
> I can reproduce this by trying to rebuild 0.9.4 in sbuild (a buster
> schroot created with sbuild-createchroot, hosted on a buster VM, using
> vectis[1]) if that's any help? Presumably there is some difference
> between your buster schroot and the one sbuild would use. See below
> for a full package list.
Yep. The difference I finally found was that the buildds use LANG=C.UTF-8 and
LC_ALL=C.UTF-8 whereas mine was not enforcing these (and so I was building
with LC_ALL=POSIX).
By fixing this, I could reproducibly fail to build win32-loader :-)
> > Unable to convert processed string "نوشتن ممکن نیست: " to codepage 1256
>
> That string appears to be part of the Farsi (fa) translation of nsis,
> found in "Contrib/Language files/Farsi.nlf" in nsis_3.04-1. It is indeed
> not possible to convert it to Windows codepage 1256: (…)
>
> (I don't know whether converting this string to CP1256 is an appropriate
> thing to be doing.)
>
> If that's the problem, maybe it would be possible to work around this by
> adjusting or disabling the Farsi translation, or by replacing the use of
> CP1256 with UTF-16 or something?
Hrm. For a stable upload, this seems to be enough to let the build go through:
--- a/debian/rules
+++ b/debian/rules
@@ -24,6 +24,10 @@ BUILT_USING_LIST := $(shell set -e; \
NSIS_VERSION := $(shell dpkg-query -f='$${Version}' -W nsis )
+# A non-UTF-8 locale is needed for the NSIS build to convert some language
strings
+LC_ALL := POSIX
+export LC_ALL
+
%:
dh $@
Any idea of a more targeted fix?
@Adam: I assume I need to bump the version number and upload again, right?
(debdiff attached)
Cheers,
OdyXdiff -Nru win32-loader-0.9.4+deb10u1/debian/changelog win32-loader-0.9.4+deb10u2/debian/changelog
--- win32-loader-0.9.4+deb10u1/debian/changelog 2019-08-16 08:53:00.000000000 +0200
+++ win32-loader-0.9.4+deb10u2/debian/changelog 2019-08-24 18:44:18.000000000 +0200
@@ -1,3 +1,9 @@
+win32-loader (0.9.4+deb10u2) buster; urgency=medium
+
+ * Fix stable FTBFS through enforcing LC_ALL=POSIX
+
+ -- Didier Raboud <odyx@debian.org> Sat, 24 Aug 2019 18:44:18 +0200
+
win32-loader (0.9.4+deb10u1) buster; urgency=medium
* Rebuild in stable to embed the latest debian-archive-keyring
diff -Nru win32-loader-0.9.4+deb10u1/debian/rules win32-loader-0.9.4+deb10u2/debian/rules
--- win32-loader-0.9.4+deb10u1/debian/rules 2019-08-16 08:53:00.000000000 +0200
+++ win32-loader-0.9.4+deb10u2/debian/rules 2019-08-24 18:44:18.000000000 +0200
@@ -24,6 +24,10 @@
NSIS_VERSION := $(shell dpkg-query -f='$${Version}' -W nsis )
+# A non-UTF-8 locale is needed for the NSIS build to convert some language strings
+LC_ALL := POSIX
+export LC_ALL
+
%:
dh $@
Attachment:
signature.asc
Description: This is a digitally signed message part.