Bug#931198: unblock: warzone2100/3.2.1-4
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package warzone2100
A segmentation fault was discovered in warzone2100 when someone tries
to host a new multiplayer game. It would be great if we still could get this
into Buster. This is Debian bug #930942.
Regards,
Markus
unblock warzone2100/3.2.1-4
-- System Information:
Debian Release: 10.0
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.9.0-9-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect
diff -Nru warzone2100-3.2.1/debian/changelog warzone2100-3.2.1/debian/changelog
--- warzone2100-3.2.1/debian/changelog 2018-02-24 00:51:59.000000000 +0100
+++ warzone2100-3.2.1/debian/changelog 2019-06-26 06:49:41.000000000 +0200
@@ -1,3 +1,13 @@
+warzone2100 (3.2.1-4) unstable; urgency=medium
+
+ * Team upload.
+ * Move the package to salsa.debian.org.
+ * Fix segmentation fault upon multiplayer "Start Hosting Game"
+ Thanks to Phil Morrell for the report and Bernhard Übelacker for the patch.
+ (Closes: #930942)
+
+ -- Markus Koschany <apo@debian.org> Wed, 26 Jun 2019 06:49:41 +0200
+
warzone2100 (3.2.1-3) unstable; urgency=medium
* Team upload.
diff -Nru warzone2100-3.2.1/debian/control warzone2100-3.2.1/debian/control
--- warzone2100-3.2.1/debian/control 2018-02-24 00:51:59.000000000 +0100
+++ warzone2100-3.2.1/debian/control 2019-06-26 06:49:41.000000000 +0200
@@ -41,8 +41,8 @@
zip
Standards-Version: 4.1.3
Homepage: http://www.wz2100.net/
-Vcs-Svn: svn://anonscm.debian.org/pkg-games/packages/trunk/warzone2100/
-Vcs-Browser: https://anonscm.debian.org/viewvc/pkg-games/packages/trunk/warzone2100/
+Vcs-Git: https://salsa.debian.org/games-team/warzone2100.git
+Vcs-Browser: https://salsa.debian.org/games-team/warzone2100
Package: warzone2100
Architecture: any
diff -Nru warzone2100-3.2.1/debian/patches/0001-Avoid-calling-EC_KEY_dup-with-null-pointer.patch warzone2100-3.2.1/debian/patches/0001-Avoid-calling-EC_KEY_dup-with-null-pointer.patch
--- warzone2100-3.2.1/debian/patches/0001-Avoid-calling-EC_KEY_dup-with-null-pointer.patch 1970-01-01 01:00:00.000000000 +0100
+++ warzone2100-3.2.1/debian/patches/0001-Avoid-calling-EC_KEY_dup-with-null-pointer.patch 2019-06-26 06:49:41.000000000 +0200
@@ -0,0 +1,30 @@
+Description: Avoid calling EC_KEY_dup with null pointer
+
+Author: Bernhard Übelacker <bernhardu@mailbox.org>
+Bug-Debian: https://bugs.debian.org/930942
+Forwarded: no
+Last-Update: 2019-06-24
+
+--- warzone2100-3.2.1.orig/lib/framework/crc.cpp
++++ warzone2100-3.2.1/lib/framework/crc.cpp
+@@ -245,7 +245,9 @@ EcKey::EcKey()
+
+ EcKey::EcKey(EcKey const &b)
+ {
+- vKey = (void *)EC_KEY_dup((EC_KEY *)b.vKey);
++ vKey = nullptr;
++ if (!b.empty())
++ vKey = (void *)EC_KEY_dup((EC_KEY *)b.vKey);
+ }
+
+ EcKey::EcKey(EcKey &&b)
+@@ -262,7 +264,8 @@ EcKey::~EcKey()
+ EcKey &EcKey::operator =(EcKey const &b)
+ {
+ clear();
+- vKey = (void *)EC_KEY_dup((EC_KEY *)b.vKey);
++ if (!b.empty())
++ vKey = (void *)EC_KEY_dup((EC_KEY *)b.vKey);
+ return *this;
+ }
+
diff -Nru warzone2100-3.2.1/debian/patches/series warzone2100-3.2.1/debian/patches/series
--- warzone2100-3.2.1/debian/patches/series 2018-02-24 00:51:59.000000000 +0100
+++ warzone2100-3.2.1/debian/patches/series 2019-06-26 06:49:41.000000000 +0200
@@ -8,3 +8,4 @@
quickstartguide.patch
openssl-1.1.patch
miniupnpc-api.patch
+0001-Avoid-calling-EC_KEY_dup-with-null-pointer.patch
Reply to: