[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#931040: marked as done (unblock: musescore/2.3.2+dfsg2-7)

Your message dated Thu, 27 Jun 2019 11:12:12 +0200
with message-id <a40535fb-a6a9-5f29-2442-8d240bc2bb11@debian.org>
and subject line Re: Bug#931040: unblock: musescore/2.3.2+dfsg2-7
has caused the Debian Bug report #931040,
regarding unblock: musescore/2.3.2+dfsg2-7
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
931040: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=931040
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package musescore

I’ve found out, from Sunday’s dev chat discussion, that MuseScore
connects to upstream’s webserver on startup (#931021), and we
generally don’t like applications to phone home without explicit
permission.

I’ve tested this with systrace and verified both the fix and the
affected versions. Please unblock if you agree this is RC.

(including a git diff, but I confirmed it’s identical to debdiff)

--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+musescore (2.3.2+dfsg2-7) unstable; urgency=high
+
+  * Disable webkit functionality (Closes: #931021)
+
+ -- Thorsten Glaser <tg@mirbsd.de>  Mon, 24 Jun 2019 18:07:46 +0200
+
 musescore (2.3.2+dfsg2-6) unstable; urgency=medium
 
   * Workaround for DEP 5 syntax in a complex case
--- a/debian/control
+++ b/debian/control
@@ -28,7 +28,6 @@ Build-Depends: cmake,
                libpulse-dev,
                libqt5opengl5-dev,
                libqt5svg5-dev,
-               libqt5webkit5-dev,
                libqt5xmlpatterns5-dev,
                libsndfile1-dev (>= 1.0.25),
                portaudio19-dev,
--- a/debian/rules
+++ b/debian/rules
@@ -37,6 +37,9 @@ ifneq (linux,${DEB_HOST_ARCH_OS})
 CMAKE_DEFS+=	-DBUILD_PORTMIDI=OFF
 endif
 
+# disable phoning home
+CMAKE_DEFS+=	-DBUILD_WEBKIT=OFF
+
 override_dh_auto_configure:
 	dh_auto_configure -- ${CMAKE_DEFS}
 


unblock musescore/2.3.2+dfsg2-7

-- System Information:
Debian Release: 10.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8)
Shell: /bin/sh linked to /bin/lksh
Init: sysvinit (via /sbin/init)

--- End Message ---
--- Begin Message --- 
Hi Thorsten,

On 25-06-2019 03:10, Thorsten Glaser wrote:
> I’ve found out, from Sunday’s dev chat discussion, that MuseScore
> connects to upstream’s webserver on startup (#931021), and we
> generally don’t like applications to phone home without explicit
> permission.
> 
> I’ve tested this with systrace and verified both the fix and the
> affected versions. Please unblock if you agree this is RC.

Although the bug you fix is important to us, its report and the solution
came too late. The change can't get the required exposure to see if
there are no regression.

I propose you go for a stable release update in the first point release.

Paul

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
Reply to: