Bug#931062: unblock: ionit/0.3.2+really0.2.1-2
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package ionit
The ionit.service fix for bug #919690 introduced a systemd dependency
loop. systemd will break the loop at a (random?) place which can make
boot behave incorrectly.
I fixed the dependency loop in ionit 0.3.2+really0.2.1-2. A debdiff is
attached.
unblock ionit/0.3.2+really0.2.1-2
--
Benjamin Drung
System Developer
Debian & Ubuntu Developer
1&1 IONOS Cloud GmbH | Greifswalder Str. 207 | 10405 Berlin | Germany
E-mail: benjamin.drung@cloud.ionos.com | Web: www.ionos.de
Head Office: Berlin, Germany
District Court Berlin Charlottenburg, Registration number: HRB 125506 B
Executive Management: Christoph Steffens, Matthias Steinberg, Achim
Weiss
Member of United Internet
diff -Nru ionit-0.3.2+really0.2.1/debian/changelog ionit-0.3.2+really0.2.1/debian/changelog
--- ionit-0.3.2+really0.2.1/debian/changelog 2019-06-20 15:36:08.000000000 +0200
+++ ionit-0.3.2+really0.2.1/debian/changelog 2019-06-25 13:18:08.000000000 +0200
@@ -1,3 +1,10 @@
+ionit (0.3.2+really0.2.1-2) unstable; urgency=medium
+
+ * Drop After=local-fs.target from ionit.service to break dependency loop
+ (Closes: #931060)
+
+ -- Benjamin Drung <benjamin.drung@cloud.ionos.com> Tue, 25 Jun 2019 13:18:08 +0200
+
ionit (0.3.2+really0.2.1-1) unstable; urgency=medium
* Run ionit.service before systemd-modules-load.service
diff -Nru ionit-0.3.2+really0.2.1/debian/patches/Drop-After-local-fs.target-from-ionit.service.patch ionit-0.3.2+really0.2.1/debian/patches/Drop-After-local-fs.target-from-ionit.service.patch
--- ionit-0.3.2+really0.2.1/debian/patches/Drop-After-local-fs.target-from-ionit.service.patch 1970-01-01 01:00:00.000000000 +0100
+++ ionit-0.3.2+really0.2.1/debian/patches/Drop-After-local-fs.target-from-ionit.service.patch 2019-06-25 13:16:16.000000000 +0200
@@ -0,0 +1,45 @@
+From ce7c305312bb68319784e2d693955297138c273a Mon Sep 17 00:00:00 2001
+From: Benjamin Drung <benjamin.drung@cloud.ionos.com>
+Date: Tue, 25 Jun 2019 12:00:24 +0200
+Subject: [PATCH] Drop After=local-fs.target from ionit.service
+
+Letting `ionit.service` run before `systemd-udev-trigger.service`
+introduces a dependency loop:
+
+```
+systemd[1]: systemd-udev-trigger.service: Found ordering cycle on ionit.service/start
+systemd[1]: systemd-udev-trigger.service: Found dependency on local-fs.target/start
+systemd[1]: systemd-udev-trigger.service: Found dependency on local-fs-pre.target/start
+systemd[1]: systemd-udev-trigger.service: Found dependency on multipathd.service/start
+```
+
+`systemd-udev-trigger.service` runs before `multipathd.service` which
+runs before `local-fs-pre.target` which runs before `local-fs.target`.
+`ionit.service` wants to run before `systemd-udev-trigger.service` but
+after `local-fs.target`.
+
+Therefore drop `After=local-fs.target` from `ionit.service` to break the
+dependency loop. `/etc` and `/usr` is probably mounted inside the initrd
+already.
+
+Bug-Debian: https://bugs.debian.org/931060
+Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
+---
+ ionit.service | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/ionit.service b/ionit.service
+index 8f56106..4c4e1c8 100644
+--- a/ionit.service
++++ b/ionit.service
+@@ -2,7 +2,6 @@
+ Description=Render configuration files from Jinja templates
+ Documentation=man:ionit(1)
+ DefaultDependencies=no
+-After=local-fs.target
+ Before=ferm.service network-pre.target openibd.service shutdown.target sysinit.target systemd-modules-load.service systemd-udev-trigger.service
+ Wants=network-pre.target
+ RequiresMountsFor=/usr
+--
+2.20.1
+
diff -Nru ionit-0.3.2+really0.2.1/debian/patches/series ionit-0.3.2+really0.2.1/debian/patches/series
--- ionit-0.3.2+really0.2.1/debian/patches/series 2019-06-20 13:54:04.000000000 +0200
+++ ionit-0.3.2+really0.2.1/debian/patches/series 2019-06-25 13:16:39.000000000 +0200
@@ -1,2 +1,3 @@
Run-ionit.service-before-systemd-modules-load.service.patch
Run-ionit.service-before-systemd-udev-trigger.service.patch
+Drop-After-local-fs.target-from-ionit.service.patch
Reply to: