[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#927980: marked as done (unblock: librsvg/2.44.10-2.1 (pre-approval))

Your message dated Sun, 28 Apr 2019 19:45:00 +0000
with message-id <6931e64f-7b0b-dc24-f8f5-e44667d404b4@thykier.net>
and subject line Re: Bug#927980: unblock: librsvg/2.44.10-2.1 (pre-approval)
has caused the Debian Bug report #927980,
regarding unblock: librsvg/2.44.10-2.1 (pre-approval)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
927980: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=927980
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-CC: pkg-gnome-maintainers@lists.alioth.debian.org
927886@bugs.debian.org

Hello all,

I have prepared an NMU to fix bug https://bugs.debian.org/927886 .
This bug in librsvg caused deepin-image-viewer to crash on startup.
The patch is picked
from upstream git trunk. The full debdiff is pasted in this mail.

I have confirmed that deepin-image-viewer will no longer crash with this patch.

The upload hasn't been made yet. Please let me know if it looks okay
to you and I'll upload the NMU later.

--
Thanks,
Boyuan Yang

diff -Nru librsvg-2.44.10/debian/changelog librsvg-2.44.10/debian/changelog
--- librsvg-2.44.10/debian/changelog    2019-04-11 04:29:30.000000000 -0400
+++ librsvg-2.44.10/debian/changelog    2019-04-25 15:55:18.000000000 -0400
@@ -1,3 +1,12 @@
+librsvg (2.44.10-2.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * debian/patches/keep-positive-radii.patch: backport an upstream fix for
+    an assertion error where radii should always be positive
+    (Closes: #927886)
+
+ -- Boyuan Yang <byang@debian.org>  Thu, 25 Apr 2019 15:55:18 -0400
+
 librsvg (2.44.10-2) unstable; urgency=medium

   * debian/patches/typenum-i386-ftbfs.patch: backport an upstream fix for a
diff -Nru librsvg-2.44.10/debian/patches/keep-positive-radii.patch
librsvg-2.44.10/debian/patches/keep-positive-radii.patch
--- librsvg-2.44.10/debian/patches/keep-positive-radii.patch
1969-12-31 19:00:00.000000000 -0500
+++ librsvg-2.44.10/debian/patches/keep-positive-radii.patch
2019-04-25 15:52:27.000000000 -0400
@@ -0,0 +1,33 @@
+From: Federico Mena Quintero <federico@gnome.org>
+Date: Sat, 29 Dec 2018 12:32:08 -0600
+Subject: Morphology needs positive radii even after the transformation
+
+This is the same pattern as in gaussian_blur.rs; the paffine
+transformation can leave us with negative radii, so take their
+absolute value after the transformation.
+
+This fixes assertion error (crashing) when nagative r takes place.
+
+Forwarded: https://gitlab.gnome.org/GNOME/librsvg/issues/395
+Applied-Upstream:
https://gitlab.gnome.org/GNOME/librsvg/commit/4ef7f198fceb8fb4a544f4768174af5b11fc9bcc
+Bug-Debian: https://bugs.debian.org/927886
+Signed-off-by: Boyuan Yang <byang@debian.org>
+---
+ rsvg_internals/src/filters/morphology.rs | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/rsvg_internals/src/filters/morphology.rs
b/rsvg_internals/src/filters/morphology.rs
+index 60fbcef..7de1a0d 100644
+--- a/rsvg_internals/src/filters/morphology.rs
++++ b/rsvg_internals/src/filters/morphology.rs
+@@ -95,6 +95,10 @@ impl Filter for Morphology {
+         let (rx, ry) = self.radius.get();
+         let (rx, ry) = ctx.paffine().transform_distance(rx, ry);
+
++        // The radii can become negative here due to the transform.
++        let rx = rx.abs();
++        let ry = ry.abs();
++
+         let operator = self.operator.get();
+
+         let mut output_surface = ImageSurface::create(
diff -Nru librsvg-2.44.10/debian/patches/series
librsvg-2.44.10/debian/patches/series
--- librsvg-2.44.10/debian/patches/series    2019-04-11 04:29:30.000000000 -0400
+++ librsvg-2.44.10/debian/patches/series    2019-04-25 15:54:21.000000000 -0400
@@ -1,3 +1,4 @@
 10_rsvg-gz.patch
 typenum-i386-ftbfs.patch
 i386-rounding-errors.patch
+keep-positive-radii.patch

--- End Message ---
--- Begin Message --- 
Niels Thykier:
> Control: tags -1 moreinfo confirmed
> 
> Boyuan Yang:
>> Package: release.debian.org
>> Severity: normal
>> User: release.debian.org@packages.debian.org
>> Usertags: unblock
>> X-Debbugs-CC: pkg-gnome-maintainers@lists.alioth.debian.org
>> 927886@bugs.debian.org
>>
>> Hello all,
>>
>> I have prepared an NMU to fix bug https://bugs.debian.org/927886 .
>> This bug in librsvg caused deepin-image-viewer to crash on startup.
>> The patch is picked
>> from upstream git trunk. The full debdiff is pasted in this mail.
>>
>> I have confirmed that deepin-image-viewer will no longer crash with this patch.
>>
>> The upload hasn't been made yet. Please let me know if it looks okay
>> to you and I'll upload the NMU later.
>>
>> --
>> Thanks,
>> Boyuan Yang
>>
>> [...]
> 
> Please go ahead with the upload and remove the moreinfo tag when the
> upload is in unstable and ready to be unblocked.
> 
> Thanks,
> ~Niels
> 

I saw the upload and have now unblocked it pre-emptively.

If there are any issues with the upload, please reopen the bug and let
me know.

Thanks,
~Niels

--- End Message ---
Reply to: