[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#927958: [pre-a] unblock: utf8proc/2.3.0-1



Hi,

Here are some incremental updates to 2.3.0-1 following the last mail:

+  * Patch: update unicode-data version strings to 12.1.0

Upstream code hard-coded unicode-data version in the code. I need to
patch those string literals.

+  * Patch: Upstream didn't bump minor version in build system and header.

Upstream forgot to bump "MINOR" from 2 to 3 in the build system.

+  * Install the newly-added pkgconfig file. (Closes: #927260)

a very simple pkg-config file.

On Sat, Apr 27, 2019 at 02:38:44AM +0000, Mo Zhou wrote:
> control: tags -1 -moreinfo
> 
> Hi,
> 
> Debdiff has been attached. The patch is enormously large (3MB) but
> 99.9% of the content is automatically generated from unicode-data.
> See my extremely detailed comments to diffstat below:
> 
> On Fri, Apr 26, 2019 at 06:58:00PM +0000, Niels Thykier wrote:
> > Please include a full debdiff of the changes.  The link to a master
> > branch with no clear marking of start/end commits makes it too time
> > consuming for us to evaluate the request.
> 
> Dch:
>   * New upstream version 2.3.0
>   * Bump unicode-data requirement to (>= 12.1) && (<< 12.2).
>   * Refresh use-unicode-data.patch; Remove pass-hardening-flags.patch (merged).
>   * Patch: update utf8proc_data.c against unicode-data 12.1.0~pre1.
>   * Add a new symbol.
> 
> diffstat for utf8proc-2.2.0 utf8proc-2.3.0
> 
>  .travis.yml                                  |   19 
>  CMakeLists.txt                               |   14 
> 
> | we use Makefile and don't use cmake for the debian package.
> 
>  MANIFEST                                     |    2 
>  Makefile                                     |   38 
> 
> | upstream merged Debian's patch. most changes are due to it.
> 
>  NEWS.md                                      |  106 
>  README.md                                    |    4 
>  bench/Makefile                               |    3 
> 
> | again, makefile change due to merging Debian patch.
> 
>  data/Makefile                                |   23 
> 
> | again, makefile change due to merging Debian patch.
> 
>  data/charwidths.jl                           |  119 
> 
> | this is not used in the build process.
> 
>  debian/changelog                             |   10 
>  debian/control                               |    4 
> 
> | I need to bump unicode-data requirement
> 
>  debian/libutf8proc2.symbols                  |    1 
> 
> | + utf8proc_unicode_version@Base 2.3.0
> | harmless symbol addition.
> 
>  debian/patches/pass-hardening-flags.patch    |   69 
> 
> | removed. merged by upstream.
> 
>  debian/patches/series                        |    2 
>  debian/patches/unicode-data-12.1.0pre1.patch | 8979 ++++++++++++++++
> 
> | utf8proc_data.c is automatically generated from unicode-data (= 12.0)
> | I have to update the file against unicode-data (= 12.1) in unstable.
> | The change is 100% auto-generated.
> 
>  debian/patches/use-unicode-data.patch        |   25 
> 
> | rebased.
> 
>  libutf8proc.pc.in                            |   10 
> 
> | this pkgconfig file is newly added. Still not installed in debian package.
> 
>  test/graphemetest.c                          |   22 
> 
> | space trimming and just one more test case
> 
>  test/misc.c                                  |    4 
> 
> | just one more assertion
> 
>  utf8proc.c                                   |   22 
> 
> | Simpler character-width computation, and the new symbol:
> |
> |+UTF8PROC_DLLEXPORT const char *utf8proc_unicode_version(void) {
> |+  return "12.0.0";
> |+}
> |
> | Well, I should patch it to "12.1.0" after sending this mail.
> 
>  utf8proc.h                                   |    8 
> 
> | comment updates and the prototype for the new symbol
> 
>  utf8proc_data.c                              |14444 +++++++++++++--------------
> 
> | 100% auto-generated from unicode-data 12.1.0~pre1 (unstable)
> 
>  22 files changed, 16417 insertions(+), 7511 deletions(-)
> 


Reply to: