[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#927096: marked as done (unblock: redmine/4.0.1-2)



Your message dated Tue, 23 Apr 2019 12:23:41 +0200
with message-id <20190423102338.jsdrqvv2tdddxx2o@debian.org>
and subject line Re: redmine/4.0.1-2
has caused the Debian Bug report #927096,
regarding unblock: redmine/4.0.1-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
927096: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=927096
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-CC: Lucas Kanashiro <kanashiro@debian.org>


Quack,

This is a follow-up on #923256. RC bugs were discovered and are now fixed (debdiff attached).

Please,
  unblock redmine/4.0.1-2

Regards.
\_o<

--
Marc Dequènes
diff -Nru redmine-4.0.1/debian/changelog redmine-4.0.1/debian/changelog
--- redmine-4.0.1/debian/changelog	2019-02-18 22:03:45.000000000 +0900
+++ redmine-4.0.1/debian/changelog	2019-04-15 12:47:36.000000000 +0900
@@ -1,3 +1,16 @@
+redmine (4.0.1-2) unstable; urgency=medium
+
+  * fix use_system_jquery_libs.patch (Closes: #923891):
+    + avoid loading libs multiple times
+    + correct event loading for JQuery 3
+  * conflicts with incompatible plugins (Closes: #923843):
+    + redmine-plugin-pretend: unmaintained, no replacement
+    + redmine-plugin-recaptcha: unmaintained, another fork may work
+    + redmine-plugin-local-avatars: unmaintained, pending PR may work,
+        see #924110
+
+ -- Marc Dequènes (Duck) <Duck@DuckCorp.org>  Mon, 15 Apr 2019 12:47:36 +0900
+
 redmine (4.0.1-1) unstable; urgency=medium
 
   [ Marc Dequènes (Duck) ]
diff -Nru redmine-4.0.1/debian/control redmine-4.0.1/debian/control
--- redmine-4.0.1/debian/control	2019-02-18 22:03:45.000000000 +0900
+++ redmine-4.0.1/debian/control	2019-04-15 12:45:55.000000000 +0900
@@ -78,6 +78,9 @@
          ${misc:Depends}
 Breaks: redmine-plugin-botsfilter (<=1.02-2),
         redmine-plugin-recaptcha (<=0.1.0+git20121018)
+Conflicts: redmine-plugin-pretend (<= 0.0.2+git20130821-4),
+           redmine-plugin-recaptcha (<= 0.1.0+git20121018-3),
+           redmine-plugin-local-avatars (<= 1.0.1-1)
 Recommends: passenger
 Suggests: bzr,
           cvs,
diff -Nru redmine-4.0.1/debian/patches/use_system_jquery_libs.patch redmine-4.0.1/debian/patches/use_system_jquery_libs.patch
--- redmine-4.0.1/debian/patches/use_system_jquery_libs.patch	2019-02-18 22:03:45.000000000 +0900
+++ redmine-4.0.1/debian/patches/use_system_jquery_libs.patch	2019-04-15 12:45:55.000000000 +0900
@@ -1,15 +1,14 @@
-Index: redmine/app/helpers/application_helper.rb
-===================================================================
---- redmine.orig/app/helpers/application_helper.rb
-+++ redmine/app/helpers/application_helper.rb
-@@ -1502,7 +1502,9 @@ module ApplicationHelper
+--- a/app/helpers/application_helper.rb
++++ b/app/helpers/application_helper.rb
+@@ -1502,9 +1502,9 @@
  
    # Returns the javascript tags that are included in the html layout head
    def javascript_heads
 -    tags = javascript_include_tag('jquery-1.11.1-ui-1.11.0-ujs-4.3.1', 'application', 'responsive')
-+    tags = javascript_include_tag('jquery.min.js', 'application', 'responsive')
-+    tags << javascript_include_tag('jquery_ujs.js', 'application', 'responsive')
-+    tags << javascript_include_tag('jquery-ui.min.js', 'application', 'responsive')
++    tags = javascript_include_tag('jquery.min.js', 'jquery-ui.min.js', 'jquery_ujs.js', 'application', 'responsive')
      unless User.current.pref.warn_on_leaving_unsaved == '0'
-       tags << "\n".html_safe + javascript_tag("$(window).load(function(){ warnLeavingUnsaved('#{escape_javascript l(:text_warn_on_leaving_unsaved)}'); });")
+-      tags << "\n".html_safe + javascript_tag("$(window).load(function(){ warnLeavingUnsaved('#{escape_javascript l(:text_warn_on_leaving_unsaved)}'); });")
++      tags << "\n".html_safe + javascript_tag("$(window).on('load', function(){ warnLeavingUnsaved('#{escape_javascript l(:text_warn_on_leaving_unsaved)}'); });")
      end
+     tags
+   end

--- End Message ---
--- Begin Message ---
Hi,

On Mon, Apr 15, 2019 at 01:52:15PM +0900, Marc Dequènes (duck) wrote:
> This is a follow-up on #923256. RC bugs were discovered and are now fixed
> (debdiff attached).
> 
> Please,
>   unblock redmine/4.0.1-2

We don't accept new packages into testing at this point.

Even if we did, the change from 3.4.6 to 4.0.1 probably wouldn't be
appropriate either.

Sorry.

Ivo

--- End Message ---

Reply to: