Bug#927777: unblock: alsa-utils/1.1.8-2
Package: release.debian.org
Severity: normal
Tags: d-i confirmed
User: release.debian.org@packages.debian.org
Usertags: unblock
Hi,
I am filing an unblock for alsa-utils as it has a fixed RC bug and
needs a d-i ack.
alsa-utils (1.1.8-2) unstable; urgency=medium
* Introduce Fix-alsactl-to-restore-config.patch. Don't rely on undocumented
/etc/alsa/state-daemon.conf to start alsa-state.service. alsa-restore.service
now will have an error code 99 the first time it runs. But after an reload of
the service or just a reboot both services will run smoothly.
[closes: #925455]
-- Elimar Riesebieter <riesebie@lxtec.de> Sat, 30 Mar 2019 10:18:40 +0100
unblock alsa-utils/1.1.8-2
Thanks,
~Niels
Base version: alsa-utils_1.1.8-1 from testing
Target version: alsa-utils_1.1.8-2 from unstable
Hints in place:
==> freeze
# These udebs need to be put in one of the lists:
block-udeb alsa-utils
Excuses:
alsa-utils (1.1.8-1 to 1.1.8-2)
Migration status: BLOCKED: Needs an approval (either due to a freeze, the source suite or a manual hint)
Maintainer: Debian ALSA Maintainers
13 days old (needed 5 days)
Updating alsa-utils fixes old bugs: #925455
Piuparts tested OK - https://piuparts.debian.org/sid/source/a/alsa-utils.html
Not touching package due to block-udeb request by freeze (please contact the d-i release manager if an update is needed)
Not touching package due to block request by freeze (please contact debian-release if update is needed)
Filter applied (not reflected in the diffstat):
filterdiff -x **/*.po -x **/*.pot
changelog | 10 ++++++
patches/Fix-alsactl-to-restore-config.patch | 46 ++++++++++++++++++++++++++++
patches/series | 1
3 files changed, 57 insertions(+)
gpgv: unknown type of key resource 'trustedkeys.kbx'
gpgv: keyblock resource '/home/nthykier/.gnupg/trustedkeys.kbx': General error
gpgv: Signature made 2019-02-11T12:43:26 UTC
gpgv: using RSA key E8175486C02929837C286A1625502F6FCBE3CB04
gpgv: issuer "jordi@mallach.net"
gpgv: Can't check signature: No public key
dpkg-source: warning: failed to verify signature on /tmp/tmpy1szi6bf/alsa-utils_1.1.8-1.dsc
gpgv: unknown type of key resource 'trustedkeys.kbx'
gpgv: keyblock resource '/home/nthykier/.gnupg/trustedkeys.kbx': General error
gpgv: Signature made 2019-04-09T16:08:42 UTC
gpgv: using RSA key D1E1316E93A760A8104D85FABB3A68018649AA06
gpgv: Can't check signature: No public key
dpkg-source: warning: failed to verify signature on /tmp/tmpy1szi6bf/alsa-utils_1.1.8-2.dsc
diff -Nru alsa-utils-1.1.8/debian/changelog alsa-utils-1.1.8/debian/changelog
--- alsa-utils-1.1.8/debian/changelog 2019-01-27 18:55:15.000000000 +0000
+++ alsa-utils-1.1.8/debian/changelog 2019-03-30 09:18:40.000000000 +0000
@@ -1,3 +1,13 @@
+alsa-utils (1.1.8-2) unstable; urgency=medium
+
+ * Introduce Fix-alsactl-to-restore-config.patch. Don't rely on undocumented
+ /etc/alsa/state-daemon.conf to start alsa-state.service. alsa-restore.service
+ now will have an error code 99 the first time it runs. But after an reload of
+ the service or just a reboot both services will run smoothly.
+ [closes: #925455]
+
+ -- Elimar Riesebieter <riesebie@lxtec.de> Sat, 30 Mar 2019 10:18:40 +0100
+
alsa-utils (1.1.8-1) unstable; urgency=medium
* New upstream release.
diff -Nru alsa-utils-1.1.8/debian/patches/Fix-alsactl-to-restore-config.patch alsa-utils-1.1.8/debian/patches/Fix-alsactl-to-restore-config.patch
--- alsa-utils-1.1.8/debian/patches/Fix-alsactl-to-restore-config.patch 1970-01-01 00:00:00.000000000 +0000
+++ alsa-utils-1.1.8/debian/patches/Fix-alsactl-to-restore-config.patch 2019-03-30 09:18:40.000000000 +0000
@@ -0,0 +1,46 @@
+From 6198e81500938a1e0f5e9d8f58c4e45dec2ee6b3 Mon Sep 17 00:00:00 2001
+From: Elimar Riesebieter <riesebie@lxtec.de>
+Date: Sat, 30 Mar 2019 10:07:46 +0100
+Subject: [PATCH] Fix-alsactl-to-restore-config.
+
+---
+ alsactl/alsa-restore.service.in | 2 +-
+ alsactl/alsa-state.service.in | 5 +++--
+ 2 files changed, 4 insertions(+), 3 deletions(-)
+
+diff --git a/alsactl/alsa-restore.service.in b/alsactl/alsa-restore.service.in
+index 38ffea7..74b9290 100644
+--- a/alsactl/alsa-restore.service.in
++++ b/alsactl/alsa-restore.service.in
+@@ -8,7 +8,7 @@ Description=Save/Restore Sound Card State
+ Documentation=man:alsactl(1)
+ ConditionPathExists=!@daemonswitch@
+ ConditionPathExistsGlob=/dev/snd/control*
+-ConditionPathExists=@asoundrcfile@
++After=alsa-state.service
+
+ [Service]
+ Type=oneshot
+diff --git a/alsactl/alsa-state.service.in b/alsactl/alsa-state.service.in
+index a3c6e49..f631cc3 100644
+--- a/alsactl/alsa-state.service.in
++++ b/alsactl/alsa-state.service.in
+@@ -1,4 +1,4 @@
+-#
++
+ # Note that two different ALSA card state management schemes exist and they
+ # can be switched using a file exist check - /etc/alsa/state-daemon.conf .
+ #
+@@ -6,7 +6,8 @@
+ [Unit]
+ Description=Manage Sound Card State (restore and store)
+ Documentation=man:alsactl(1)
+-ConditionPathExists=@daemonswitch@
++ConditionPathExists=!@daemonswitch@
++After=sysinit.target
+
+ [Service]
+ Type=simple
+--
+2.20.1
+
diff -Nru alsa-utils-1.1.8/debian/patches/series alsa-utils-1.1.8/debian/patches/series
--- alsa-utils-1.1.8/debian/patches/series 2019-01-27 18:55:15.000000000 +0000
+++ alsa-utils-1.1.8/debian/patches/series 2019-03-30 09:18:40.000000000 +0000
@@ -3,3 +3,4 @@
spellfixes.patch
systemd_Documentation_key.patch
do-not-check-for-sys-kernel-uevent_helper.patch
+Fix-alsactl-to-restore-config.patch
Hints needed:
unblock alsa-utils/1.1.8-2
# XXXX: Confirm with d-i RM
unblock-udeb alsa-utils/1.1.8-2
Reply to: