[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#927434: marked as done (unblock: network-manager-applet/1.8.20-1.1 (pre-approval))

Your message dated Sun, 21 Apr 2019 16:17:00 +0000
with message-id <1ac67892-747f-6461-4ca7-738be05947d7@thykier.net>
and subject line Re: Bug#927434: unblock: network-manager-applet/1.8.20-1.1 (pre-approval)
has caused the Debian Bug report #927434,
regarding unblock: network-manager-applet/1.8.20-1.1 (pre-approval)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
927434: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=927434
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-CC: biebl@debian.org pkg-utopia-maintainers@lists.alioth.debian.org

This is a pre-approval for NMU that would fix https://bugs.debian.org/926328 .

The one-liner patch is taken from commits in upstream git trunk.

I haven't make any upload yet. Michael, please let me know if this
patch looks okay for you. I can open a Merge Request for this NMU on
Salsa if necessary.

The full debdiff is pasted here.

--
Thanks,
Boyuan Yang

diff -Nru network-manager-applet-1.8.20/debian/changelog
network-manager-applet-1.8.20/debian/changelog
--- network-manager-applet-1.8.20/debian/changelog    2019-02-26
12:47:42.000000000 -0500
+++ network-manager-applet-1.8.20/debian/changelog    2019-04-19
13:27:26.000000000 -0400
@@ -1,3 +1,11 @@
+network-manager-applet (1.8.20-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix crash on creating custom Wi-Fi connection in wifi-dialog.
+    (Closes: #926328)
+
+ -- Boyuan Yang <byang@debian.org>  Fri, 19 Apr 2019 13:27:26 -0400
+
 network-manager-applet (1.8.20-1) unstable; urgency=medium

   * New upstream version 1.8.20
diff -Nru network-manager-applet-1.8.20/debian/patches/Fix-double-free-crashing-in-wifi-dialog.patch
network-manager-applet-1.8.20/debian/patches/Fix-double-free-crashing-in-wifi-dialog.patch
--- network-manager-applet-1.8.20/debian/patches/Fix-double-free-crashing-in-wifi-dialog.patch
   1969-12-31 19:00:00.000000000 -0500
+++ network-manager-applet-1.8.20/debian/patches/Fix-double-free-crashing-in-wifi-dialog.patch
   2019-04-19 12:50:27.000000000 -0400
@@ -0,0 +1,31 @@
+From: Boyuan Yang <byang@debian.org>
+Date: Fri, 19 Apr 2019 12:27:33 -0400
+Subject: Fix double-free crashing in wifi-dialog
+
+The nm-applet tool would crash every time a Wi-Fi connection
+is created manually. This patch fixes this problem.
+
+This issue will be fixed in the upcoming network-manager-applet
+1.8.22 release.
+
+Applied-Upstream:
https://gitlab.gnome.org/GNOME/network-manager-applet/commit/b4c365b136e25e69c3550a9984f8f3cbec4bc073
+Forwarded: https://gitlab.gnome.org/GNOME/network-manager-applet/issues/43
+Bug-Debian: https://bugs.debian.org/926328
+Signed-off-by: Boyuan Yang <byang@debian.org>
+---
+ src/libnma/nma-wifi-dialog.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/libnma/nma-wifi-dialog.c b/src/libnma/nma-wifi-dialog.c
+index 009bf44..a90b20d 100644
+--- a/src/libnma/nma-wifi-dialog.c
++++ b/src/libnma/nma-wifi-dialog.c
+@@ -1260,7 +1260,7 @@ nma_wifi_dialog_get_connection (NMAWifiDialog *self,
+         s_wireless = (NMSettingWireless *) nm_setting_wireless_new ();
+         ssid = validate_dialog_ssid (self);
+         g_object_set (s_wireless, NM_SETTING_WIRELESS_SSID, ssid, NULL);
+-        g_free (ssid);
++        g_bytes_unref (ssid);
+
+         if (priv->operation == OP_CREATE_ADHOC) {
+             NMSetting *s_ip4;
diff -Nru network-manager-applet-1.8.20/debian/patches/series
network-manager-applet-1.8.20/debian/patches/series
--- network-manager-applet-1.8.20/debian/patches/series    2019-02-26
12:47:42.000000000 -0500
+++ network-manager-applet-1.8.20/debian/patches/series    2019-04-19
12:50:27.000000000 -0400
@@ -1,2 +1,3 @@
 Allow-creation-of-connections-without-admin-privileges.patch
 Force-online-state-with-unmanaged-devices.patch
+Fix-double-free-crashing-in-wifi-dialog.patch

--- End Message ---
--- Begin Message --- 
Boyuan Yang:
> Control: tags -1 - moreinfo
> 
> Niels Thykier <niels@thykier.net> 于2019年4月20日周六 上午2:22写道：
>>
>> Control: tags -1 confirmed moreinfo
>>
>> Boyuan Yang:
>>> Package: release.debian.org
>>> Severity: normal
>>> User: release.debian.org@packages.debian.org
>>> Usertags: unblock
>>> X-Debbugs-CC: biebl@debian.org pkg-utopia-maintainers@lists.alioth.debian.org
>>>
>>> This is a pre-approval for NMU that would fix https://bugs.debian.org/926328 .
>>>
>>> The one-liner patch is taken from commits in upstream git trunk.
>>>
>>> I haven't make any upload yet. Michael, please let me know if this
>>> patch looks okay for you. I can open a Merge Request for this NMU on
>>> Salsa if necessary.
>>>
>>> The full debdiff is pasted here.
>> Hi,
>>
>> From a release team PoV, the change looks fine.
>>
>> Please remove the moreinfo tag when the upload is in sid and ready to be
>> unblocked.
> 
> Thanks. I have made the upload and believe that this upload is ready
> to be unblocked.
> 
> --
> Regards,
> Boyuan Yang
> 

Unblocked, thanks.
~Niels

--- End Message ---
Reply to: