Bug#927156: unblock: parted/3.2-25

[Colin Watson <cjwatson@debian.org>]

Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock parted 3.2-25: there was an arithmetic error in its
handling of extended partitions, which was often in practice masked by
higher-level tools but could be triggered in some circumstances such as
by gnome-disks, leading to disturbing results like apparently-vanishing
partitions.  The patch is pretty clear if you look at a little more
context: one branch of an if/else block multiplied by the device's
sector size while the other didn't, which was obviously wrong.

diff -Nru parted-3.2/debian/.git-dpm parted-3.2/debian/.git-dpm
--- parted-3.2/debian/.git-dpm	2018-10-22 11:26:47.000000000 +0100
+++ parted-3.2/debian/.git-dpm	2019-04-15 15:21:54.000000000 +0100
@@ -1,6 +1,6 @@
 # see git-dpm(1) from git-dpm package
-4e3c21b5b25c90ece1b197243a422663053bbc42
-4e3c21b5b25c90ece1b197243a422663053bbc42
+f82a0f5d3d12e7125572518294bb296465786422
+f82a0f5d3d12e7125572518294bb296465786422
 a3803540db7f12359a111d6449159b91032c253f
 a3803540db7f12359a111d6449159b91032c253f
 parted_3.2.orig.tar.xz
diff -Nru parted-3.2/debian/changelog parted-3.2/debian/changelog
--- parted-3.2/debian/changelog	2019-01-12 16:45:45.000000000 +0000
+++ parted-3.2/debian/changelog	2019-04-15 15:38:11.000000000 +0100
@@ -1,3 +1,11 @@
+parted (3.2-25) unstable; urgency=medium
+
+  * Cherry-pick from upstream:
+    - libparted: BLKPG_RESIZE_PARTITION uses bytes, not sectors (closes:
+      #926735, LP: #1641308).
+
+ -- Colin Watson <cjwatson@debian.org>  Mon, 15 Apr 2019 15:38:11 +0100
+
 parted (3.2-24) unstable; urgency=medium
 
   * Set Rules-Requires-Root: no.
diff -Nru parted-3.2/debian/patches/blkpg-resize-partition-uses-bytes.patch parted-3.2/debian/patches/blkpg-resize-partition-uses-bytes.patch
--- parted-3.2/debian/patches/blkpg-resize-partition-uses-bytes.patch	1970-01-01 01:00:00.000000000 +0100
+++ parted-3.2/debian/patches/blkpg-resize-partition-uses-bytes.patch	2019-04-15 15:21:54.000000000 +0100
@@ -0,0 +1,36 @@
+From f82a0f5d3d12e7125572518294bb296465786422 Mon Sep 17 00:00:00 2001
+From: "Brian C. Lane" <bcl@redhat.com>
+Date: Fri, 5 Jun 2015 14:40:00 -0700
+Subject: libparted: BLKPG_RESIZE_PARTITION uses bytes, not sectors (#1135493)
+
+This results in the extended partition vanishing after adding another
+partition.
+
+Resolves: rhbz#1135493
+
+Bug-Debian: https://bugs.debian.org/926735
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1641308
+Origin: upstream, https://git.savannah.gnu.org/cgit/parted.git/commit/?id=c6dc6e5d0f49a26242d2b28622514814a53d92e1
+Last-Update: 2019-04-15
+
+Patch-Name: blkpg-resize-partition-uses-bytes.patch
+---
+ libparted/arch/linux.c | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
+index 3bd2878d..f85bee80 100644
+--- a/libparted/arch/linux.c
++++ b/libparted/arch/linux.c
+@@ -2583,7 +2583,10 @@ static int _blkpg_resize_partition (PedDisk* disk, const PedPartition *part)
+                                 if (walk->geom.start == part->geom.start+1)
+                                         linux_part.length = 1;
+                         }
+-                } else linux_part.length = 1;
++                } else {
++                        linux_part.length = 1;
++                }
++                linux_part.length *= disk->dev->sector_size;
+         }
+         else
+                 linux_part.length = part->geom.length * disk->dev->sector_size;
diff -Nru parted-3.2/debian/patches/series parted-3.2/debian/patches/series
--- parted-3.2/debian/patches/series	2018-10-22 11:26:47.000000000 +0100
+++ parted-3.2/debian/patches/series	2019-04-15 15:21:54.000000000 +0100
@@ -29,3 +29,4 @@
 fat-resize-retain-boot-code.patch
 sysmacros-for-major-minor.patch
 nvme-model-names-from-sysfs.patch
+blkpg-resize-partition-uses-bytes.patch

unblock parted/3.2-25

-- 
Colin Watson                                       [cjwatson@debian.org]