Bug#926907: unblock: python-django-casclient/1.2.0-2.2
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package python-django-casclient
As explained in bug #926350 [1], python-django-casclient is broken when used
with Django versions >= 1.10, due to Django middleware API changes. Since
Buster will ship with Django 1.11, python-django-casclient is useless in its
current state.
The patch to fix the issue was obtained from upstream [2]. The source
debdiff between the version in testing/unstable and the fixed version I
would like to upload (via unstable) is attached.
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926350
[2] https://github.com/kstateome/django-cas/pull/64
unblock python-django-casclient/1.2.0-2.2
-- System Information:
Debian Release: 9.8
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-debug'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru python-django-casclient-1.2.0/debian/changelog python-django-casclient-1.2.0/debian/changelog
--- python-django-casclient-1.2.0/debian/changelog 2018-09-22 05:04:25.000000000 -0400
+++ python-django-casclient-1.2.0/debian/changelog 2019-04-03 17:26:47.000000000 -0400
@@ -1,3 +1,10 @@
+python-django-casclient (1.2.0-2.2) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Apply django 1.10 middleware fix from upstream (Closes: #926350)
+
+ -- William Blough <bblough@debian.org> Wed, 03 Apr 2019 17:26:47 -0400
+
python-django-casclient (1.2.0-2.1) unstable; urgency=medium
* Non-maintainer upload.
diff -Nru python-django-casclient-1.2.0/debian/patches/django_110_middleware_fix python-django-casclient-1.2.0/debian/patches/django_110_middleware_fix
--- python-django-casclient-1.2.0/debian/patches/django_110_middleware_fix 1969-12-31 19:00:00.000000000 -0500
+++ python-django-casclient-1.2.0/debian/patches/django_110_middleware_fix 2019-04-03 17:26:47.000000000 -0400
@@ -0,0 +1,41 @@
+Description: Fix middleware to be compatible with Django 1.10
+Origin: upstream, https://patch-diff.githubusercontent.com/raw/kstateome/django-cas/pull/64.diff
+Last-Update: 2019-04-11
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/cas/middleware.py
++++ b/cas/middleware.py
+@@ -5,6 +5,15 @@ try:
+ except ImportError:
+ from urllib.parse import urlencode
+
++
++MIDDLEWARE_BASE = None
++
++try:
++ from django.utils.deprecation import MiddlewareMixin
++ MIDDLEWARE_BASE = MiddlewareMixin
++except ImportError:
++ MIDDLEWARE_BASE = object
++
+ from django.conf import settings
+ from django.contrib.auth import REDIRECT_FIELD_NAME
+ from django.contrib.auth import logout as do_logout
+@@ -19,7 +28,7 @@ from cas.views import login as cas_login
+ __all__ = ['CASMiddleware']
+
+
+-class CASMiddleware(object):
++class CASMiddleware(MIDDLEWARE_BASE):
+ """
+ Middleware that allows CAS authentication on admin pages
+ """
+@@ -81,7 +90,7 @@ class CASMiddleware(object):
+ return None
+
+
+-class ProxyMiddleware(object):
++class ProxyMiddleware(MIDDLEWARE_BASE):
+
+ # Middleware used to "fake" the django app that it lives at the Proxy Domain
+ def process_request(self, request):
diff -Nru python-django-casclient-1.2.0/debian/patches/series python-django-casclient-1.2.0/debian/patches/series
--- python-django-casclient-1.2.0/debian/patches/series 1969-12-31 19:00:00.000000000 -0500
+++ python-django-casclient-1.2.0/debian/patches/series 2019-04-03 17:26:47.000000000 -0400
@@ -0,0 +1 @@
+django_110_middleware_fix
Reply to: