Bug#926495: unblock: gnome-gmail/2.6-1
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package gnome-gmail
This version contains a minimal change that resolves the serious bug against
Buster - #926487.
A recent Gmail update is unable to properly process upload MIME-encoded
messages that do not include a message body.The latest gnome-gmail
resolves the
issue by taking more effort for messages to be well formed - to always
include
a message body, and to drop the "To:" header if otherwise blank.
Debdiff attached.
unblock gnome-gmail/2.6-1
-- System Information:
Debian Release: buster/sid
APT prefers unstable
APT policy: (700, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.19.0-4-amd64 (SMP w/6 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru gnome-gmail-2.5.6/debian/changelog gnome-gmail-2.6/debian/changelog
--- gnome-gmail-2.5.6/debian/changelog 2018-10-09 13:38:04.000000000 -0400
+++ gnome-gmail-2.6/debian/changelog 2019-04-05 21:18:19.000000000 -0400
@@ -1,3 +1,9 @@
+gnome-gmail (2.6-1) unstable; urgency=medium
+
+ * Fix Gmail bug - bad message if no body (Closes: 926487).
+
+ -- David Steele <steele@debian.org> Fri, 05 Apr 2019 21:18:19 -0400
+
gnome-gmail (2.5.6-1) unstable; urgency=medium
* Fix bug in setup.py distutils.
diff -Nru gnome-gmail-2.5.6/gnome-gmail.appdata.xml.in gnome-gmail-2.6/gnome-gmail.appdata.xml.in
--- gnome-gmail-2.5.6/gnome-gmail.appdata.xml.in 2018-10-09 11:22:57.000000000 -0400
+++ gnome-gmail-2.6/gnome-gmail.appdata.xml.in 2019-04-05 21:22:56.000000000 -0400
@@ -51,6 +51,7 @@
</screenshots>
<releases>
<!-- Get timestamp with 'date +%s' -->
+ <release version="2.6" timestamp="1554505039"></release>
<release version="2.5.6" timestamp="1539120762"></release>
<release version="2.5.5" timestamp="1539034362"></release>
<release version="2.5.4" timestamp="1514349302"></release>
diff -Nru gnome-gmail-2.5.6/gnomegmail.py gnome-gmail-2.6/gnomegmail.py
--- gnome-gmail-2.5.6/gnomegmail.py 2018-10-09 11:22:57.000000000 -0400
+++ gnome-gmail-2.6/gnomegmail.py 2019-04-05 21:22:56.000000000 -0400
@@ -569,7 +569,8 @@
qsdict = urllib.parse.parse_qs(query_string)
- qsdict['to'] = [address]
+ if address:
+ qsdict['to'] = [address]
if 'attachment' in qsdict:
qsdict['attach'] = qsdict['attachment']
@@ -587,6 +588,9 @@
if 'su' in qsdict:
outdict["subject"] = outdict["su"]
+ if "body" not in qsdict:
+ outdict["body"] = " "
+
return(outdict)
def simple_gmail_url(self):
diff -Nru gnome-gmail-2.5.6/setup.py gnome-gmail-2.6/setup.py
--- gnome-gmail-2.5.6/setup.py 2018-10-09 11:22:57.000000000 -0400
+++ gnome-gmail-2.6/setup.py 2019-04-05 21:22:56.000000000 -0400
@@ -129,7 +129,7 @@
setup(
name='gnome-gmail',
- version='2.5.6',
+ version='2.6',
description='support for Gmail as the preferred GNOME email application',
author='David Steele',
author_email='dsteele@gmail.com',
diff -Nru gnome-gmail-2.5.6/test/test_body.py gnome-gmail-2.6/test/test_body.py
--- gnome-gmail-2.5.6/test/test_body.py 2018-10-09 11:22:57.000000000 -0400
+++ gnome-gmail-2.6/test/test_body.py 2019-04-05 21:22:56.000000000 -0400
@@ -107,8 +107,8 @@
@pytest.mark.parametrize("mailto, needs_api", (
- ("mailto:joe";, False),
- ("mailto:joe?subject=hi";, False),
+ ("mailto:joe";, True),
+ ("mailto:joe?subject=hi";, True),
("mailto:joe?body=%20";, True),
("mailto:joe?attach=file";, True),
("mailto:joe?attachment=file";, True),
Reply to: