[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#926206: marked as done (unblock: espeakup/1:0.80-14)

Your message dated Tue, 02 Apr 2019 05:40:00 +0000
with message-id <995e0ca3-0130-3638-8da7-513322431e02@thykier.net>
and subject line Re: Bug#926206: unblock: espeakup/1:0.80-14
has caused the Debian Bug report #926206,
regarding unblock: espeakup/1:0.80-14
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
926206: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926206
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hello,

Please unblock package espeakup: as reported in Bug#925973, the current
version of espeakup would stop it on preinst and start it on postinst.
For a screen reader for blind users this is really bad because if
anything goes wrong in between, the user is left without a screen
reader. We should thus pass --restart-after-upgrade to dh_systemd_start
to just restart the screen reader after successful upgrade.

Cc-ing kibi because of the udeb: this doesn't have any effect on the
udeb.

unblock espeakup/1:0.80-14

Thanks!

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.0.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_CRAP, TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
il y a 10 catégories de personnes dans le monde : ceux qui comprennent le
binaire, et ceux qui ne le comprennent pas

diff -Nru espeakup-0.80/debian/changelog espeakup-0.80/debian/changelog
--- espeakup-0.80/debian/changelog	2019-02-20 15:44:59.000000000 +0100
+++ espeakup-0.80/debian/changelog	2019-03-29 17:03:23.000000000 +0100
@@ -1,3 +1,9 @@
+espeakup (1:0.80-14) unstable; urgency=medium
+
+  * rules: Restart espeakup after upgrade (Closes: Bug#925973).
+
+ -- Samuel Thibault <sthibault@debian.org>  Fri, 29 Mar 2019 17:03:23 +0100
+
 espeakup (1:0.80-13) unstable; urgency=medium
 
   * debian/espeakup.finish-install: Fix writing down card id.
diff -Nru espeakup-0.80/debian/rules espeakup-0.80/debian/rules
--- espeakup-0.80/debian/rules	2019-01-01 17:07:20.000000000 +0100
+++ espeakup-0.80/debian/rules	2019-03-29 17:03:23.000000000 +0100
@@ -41,3 +41,6 @@
 override_dh_gencontrol:
 	echo 'espeak-ng:Version=$(ESPEAK_NG_VERSION)' >> debian/espeakup-udeb.substvars
 	dh_gencontrol
+
+override_dh_systemd_start:
+	dh_systemd_start --restart-after-upgrade

--- End Message ---
--- Begin Message --- 
Samuel Thibault:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Hello,
> 
> Please unblock package espeakup: as reported in Bug#925973, the current
> version of espeakup would stop it on preinst and start it on postinst.
> For a screen reader for blind users this is really bad because if
> anything goes wrong in between, the user is left without a screen
> reader. We should thus pass --restart-after-upgrade to dh_systemd_start
> to just restart the screen reader after successful upgrade.
> 
> Cc-ing kibi because of the udeb: this doesn't have any effect on the
> udeb.
> 
> unblock espeakup/1:0.80-14
> 
> Thanks!
> 
> [...]
> 

Unblocked by ivodd, thanks.
~Niels

--- End Message ---
Reply to: