[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#926002: marked as done (unblock: zeromq3/4.3.1-4)

Your message dated Sun, 31 Mar 2019 08:36:00 +0000
with message-id <b47cacab-6c37-3efc-82af-37ebc97869dc@thykier.net>
and subject line Re: Bug#926002: unblock: zeromq3/4.3.1-4
has caused the Debian Bug report #926002,
regarding unblock: zeromq3/4.3.1-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
926002: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926002
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi Release Team,

Unfortunately upstream of zeromq3 broke GSSAPI detection[1] in the
configure phase. It went undetected and now zeromq3 for Buster doesn't
have GSSAPI support and this is a regression since Stretch.

Luca Boccassi who is not just our fellow DD but also upstream fixed it
with a small patch. Full debdiff is attached. Please let it migrate to
Buster and have the same functionality available that's in Stretch.

Thanks for consideration,
Laszlo/GCS
[1] https://bugs.debian.org/925914

diff -Nru zeromq3-4.3.1/debian/changelog zeromq3-4.3.1/debian/changelog
--- zeromq3-4.3.1/debian/changelog	2019-01-26 12:49:45.000000000 +0000
+++ zeromq3-4.3.1/debian/changelog	2019-03-28 16:37:09.000000000 +0000
@@ -1,3 +1,10 @@
+zeromq3 (4.3.1-4) unstable; urgency=medium
+
+  [ Luca Boccassi <bluca@debian.org> ]
+  * Fix GSSAPI support build (closes: #925914).
+
+ -- Laszlo Boszormenyi (GCS) <gcs@debian.org>  Thu, 28 Mar 2019 16:37:09 +0000
+
 zeromq3 (4.3.1-3) unstable; urgency=medium
 
   [ Luca Boccassi <bluca@debian.org> ]
diff -Nru zeromq3-4.3.1/debian/patches/gssapi_pkgconfig.patch zeromq3-4.3.1/debian/patches/gssapi_pkgconfig.patch
--- zeromq3-4.3.1/debian/patches/gssapi_pkgconfig.patch	1970-01-01 00:00:00.000000000 +0000
+++ zeromq3-4.3.1/debian/patches/gssapi_pkgconfig.patch	2019-03-28 16:37:09.000000000 +0000
@@ -0,0 +1,30 @@
+Author: Luca Boccassi <bluca@debian.org>
+Description: gssapi pkg-config check in configure.ac does not work
+ correctly enable the definition in platform.hpp so that the
+ gssapi support is actually built in if requested and available.
+Origin: https://github.com/zeromq/libzmq/pull/3361
+--- a/configure.ac
++++ b/configure.ac
+@@ -472,16 +472,20 @@
+ # conditionally require libgssapi_krb5
+ if test "x$require_libgssapi_krb5_ext" != "xno"; then
+     PKG_CHECK_MODULES([gssapi_krb5], [krb5-gssapi], [
++        have_gssapi_library="yes"
+         PKGCFG_NAMES_PRIVATE="$PKGCFG_NAMES_PRIVATE krb5-gssapi"
+     ], [
+         AC_CHECK_HEADERS(gssapi/gssapi_generic.h)
+         AC_SEARCH_LIBS([gss_init_sec_context], [gssapi_krb5 gssapi],
+-            AC_DEFINE(HAVE_LIBGSSAPI_KRB5, [1], [Enabled GSSAPI security]),
++            have_gssapi_library="yes",
+             AC_MSG_ERROR(libgssapi_krb5 is needed for GSSAPI security))
+         PKGCFG_LIBS_PRIVATE="$PKGCFG_LIBS_PRIVATE -lgssapi_krb5"
+     ])
+ fi
+-AM_CONDITIONAL(BUILD_GSSAPI, test "x$require_libgssapi_krb5_ext" != "xno")
++if test "x$have_gssapi_library" = "xyes"; then
++    AC_DEFINE(HAVE_LIBGSSAPI_KRB5, [1], [Enabled GSSAPI security])
++fi
++AM_CONDITIONAL(BUILD_GSSAPI, test "x$have_gssapi_library" = "xyes")
+ 
+ # Select curve encryption library, defaults to tweetnacl
+ # To use libsodium instead, use --with-libsodium (must be installed)
diff -Nru zeromq3-4.3.1/debian/patches/series zeromq3-4.3.1/debian/patches/series
--- zeromq3-4.3.1/debian/patches/series	2019-01-26 12:49:45.000000000 +0000
+++ zeromq3-4.3.1/debian/patches/series	2019-03-28 16:37:09.000000000 +0000
@@ -3,3 +3,4 @@
 test_hardcoded_ipc_path.patch
 ppc64_atomic_intrinsics.patch
 test_pair_ipc_hurd.patch
+gssapi_pkgconfig.patch

--- End Message ---
--- Begin Message --- 
Laszlo Boszormenyi (GCS):
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Hi Release Team,
> 
> Unfortunately upstream of zeromq3 broke GSSAPI detection[1] in the
> configure phase. It went undetected and now zeromq3 for Buster doesn't
> have GSSAPI support and this is a regression since Stretch.
> 
> Luca Boccassi who is not just our fellow DD but also upstream fixed it
> with a small patch. Full debdiff is attached. Please let it migrate to
> Buster and have the same functionality available that's in Stretch.
> 
> Thanks for consideration,
> Laszlo/GCS
> [1] https://bugs.debian.org/925914
> 

Unblocked, thanks.
~Niels

--- End Message ---
Reply to: