[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#924627: unblock: node-formidable/1.2.1-2



Please unblock package node-formidable

> node-formidable hasn't been updated for years. Testing version isn't
> compatible with our nodejs but this was not seen since there was no
> real tests (see https://bugs.debian.org/924589).
>
> I upgraded it and added full tests (build and autopkgtest).
>
> node-formidable reverse dependencies:
>  - node-superagent:
>    +- node-supertest (no reverse dependencies)
>
> node-formidable bug does not affect these packages since the failing
> functions are not used in it, that's why I decrease bug severity to
> important. I tested the 2 reverse dependencies with both old and new
> node-formidable with success (sbuild and autopkgtest).
>
> debdiff is big since I embedded some node modules (only for tests,
> they are not installed). Upstream changes are not so big. I updated
> also debian/* files and added examples (and tests of course).
>
> I think it's low risky to update node-formidable. However I leave you
> appreciate if it is opportune.


Hi all,

when enabling upstream test in 1.2.1-1, it fails only under debci LXC
environment. After many tries, I fixed this in 1.2.1-2 (was a test loop:
test/run.js tried to test itself). So all tests are OK now. If you think
it is opportune to unblock node-formidable, please unblock version 1.2.1-2

Cheers,
Xavier


Reply to: