[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#925902: marked as done (unblock: cnvkit/0.9.5-3)

Your message dated Thu, 28 Mar 2019 12:22:01 +0100
with message-id <e6c92e29-6a11-e8f2-fbf9-9595dc241bdf@debian.org>
and subject line Re: Bug#925902: unblock: cnvkit/0.9.5-3
has caused the Debian Bug report #925902,
regarding unblock: cnvkit/0.9.5-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
925902: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925902
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Severity: normal
Usertags: unblock


This upload fixes bug #925568 about build reproducibility (failing). It simply add a small patch to fix the issue adds a metadata entry.
Waiting for a *go* to upload package to unstable.

Thanks
Olivier

debdiff result =>

debian@ccf6b68dd723:/opt/debian/build-area$ debdiff cnvkit_0.9.5-2.dsc cnvkit_0.9.5-3.dsc
dpkg-source: warning: extracting unsigned source package (/opt/debian/build-area/cnvkit_0.9.5-3.dsc)
diff -Nru cnvkit-0.9.5/debian/changelog cnvkit-0.9.5/debian/changelog
--- cnvkit-0.9.5/debian/changelog 2019-01-06 12:12:46.000000000 +0000
+++ cnvkit-0.9.5/debian/changelog 2019-03-27 08:00:39.000000000 +0000
@@ -1,3 +1,10 @@
+cnvkit (0.9.5-3) unstable; urgency=medium
+
+  * Fix buster rebuilds (Closes: #925568)
+    d/patches/controldir.patch
+
+ -- Olivier Sallou <osallou@debian.org>  Wed, 27 Mar 2019 08:00:39 +0000
+
 cnvkit (0.9.5-2) unstable; urgency=medium
 
   [ Jelmer Vernooij ]
diff -Nru cnvkit-0.9.5/debian/patches/controldir cnvkit-0.9.5/debian/patches/controldir
--- cnvkit-0.9.5/debian/patches/controldir 1970-01-01 00:00:00.000000000 +0000
+++ cnvkit-0.9.5/debian/patches/controldir 2019-03-27 08:00:39.000000000 +0000
@@ -0,0 +1,21 @@
+Subject: do not create dir if it exists
+Description: command tries to create an output dir during tests, even if it
+ already exists, raising an error. Skip creation if already present
+Author: Olivier Sallou <osallou@debian.org>
+Bug: 925568
+Forwaded: no
+Last-Updated: 2019-03-27
+--- a/cnvlib/commands.py
++++ b/cnvlib/commands.py
+@@ -1365,8 +1365,9 @@
+                             'anti' if 'antitarget' in fname else ''))
+         if args.output_dir:
+             if not os.path.isdir(args.output_dir):
+-                os.mkdir(args.output_dir)
+-                logging.info("Created directory %s", args.output_dir)
++                if not os.path.exists(args.output_dir):
++                    os.mkdir(args.output_dir)
++                    logging.info("Created directory %s", args.output_dir)
+             outfname = os.path.join(args.output_dir, outfname)
+         tabio.write(garr, outfname)
+ 
diff -Nru cnvkit-0.9.5/debian/patches/series cnvkit-0.9.5/debian/patches/series
--- cnvkit-0.9.5/debian/patches/series 2019-01-06 09:41:24.000000000 +0000
+++ cnvkit-0.9.5/debian/patches/series 2019-03-27 08:00:39.000000000 +0000
@@ -1,3 +1,4 @@
 no-py-ext
 python3compat.patch
 spelling
+controldir
diff -Nru cnvkit-0.9.5/debian/upstream/metadata cnvkit-0.9.5/debian/upstream/metadata
--- cnvkit-0.9.5/debian/upstream/metadata 2018-06-19 21:48:37.000000000 +0000
+++ cnvkit-0.9.5/debian/upstream/metadata 2019-03-27 08:00:39.000000000 +0000
@@ -19,6 +19,6 @@
  - Name: OMICtools
    Entry: OMICS_11538
  - Name: bio.tools
-   Entry: NA
- - Name: bio.tools
+   Entry: cnvkit
+ - Name: SciCrunch
    Entry: NA



-- 
gpg key id: 4096R/326D8438  (keyring.debian.org)
Key fingerprint = 5FB4 6F83 D3B9 5204 6335  D26D 78DC 68DB 326D 8438

--- End Message ---
--- Begin Message --- 
Hi Olivier,

On 28-03-2019 09:01, olivier sallou wrote:
> This upload fixes bug #925568 about build reproducibility (failing). It
> simply add a small patch to fix the issue adds a metadata entry.
> Waiting for a *go* to upload package to unstable.

I am glad you didn't, otherwise I couldn't unblock it :). Next time,
during a freeze, please be more verbose in your changelog and ALSO
mention you added yourself to the uploaders and you updated the metadata.

unblocked, thanks.

Paul

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
Reply to: