[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#925352: marked as done (unblock: lxqt-config/0.14.1-2)



Your message dated Sat, 23 Mar 2019 17:16:40 +0000
with message-id <20190323171640.GA7508@powdarrmonkey.net>
and subject line Re: Bug#925352: unblock: lxqt-config/0.14.1-2
has caused the Debian Bug report #925352,
regarding unblock: lxqt-config/0.14.1-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
925352: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925352
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package lxqt-config

there was a regression with keyboard layout shortcut handling that make using
different keyboard layouts/models hard for people who need this functionality.

Source diff:

diff --git a/debian/changelog b/debian/changelog
index 712d526..eec2f8b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+lxqt-config (0.14.1-2) unstable; urgency=medium
+
+  * Fixed keyboard layout switch shortcut (Closes: #925346)
+
+ -- Alf Gaida <agaida@siduction.org>  Sat, 23 Mar 2019 15:40:43 +0100
+
 lxqt-config (0.14.1-1) unstable; urgency=medium
 
   * Cherry-picking new upstream version 0.14.1.
diff --git a/debian/patches/fix-keybord-layout-shortcut.patch b/debian/patches/fix-keybord-layout-shortcut.patch
new file mode 100644
index 0000000..d94ce4c
--- /dev/null

+++ b/debian/patches/fix-keybord-layout-shortcut.patch
@@ -0,0 +1,32 @@
+From dfe9a2b27aab40262b9186672fad480a406d5c4a Mon Sep 17 00:00:00 2001
+From: Tsu Jan <tsujan2000@gmail.com>
+Date: Fri, 22 Mar 2019 19:55:32 +0430
+Subject: [PATCH] Fixed changing keyboard layout switch shortcut and model
+
+Fixes https://github.com/lxqt/lxqt-config/issues/445
+---
+ lxqt-config-input/keyboardlayoutconfig.cpp | 10 ++++++++--
+ 1 file changed, 8 insertions(+), 2 deletions(-)
+
+diff --git a/lxqt-config-input/keyboardlayoutconfig.cpp b/lxqt-config-input/keyboardlayoutconfig.cpp
+index f5a7f24..bc6c369 100644
+--- a/lxqt-config-input/keyboardlayoutconfig.cpp
++++ b/lxqt-config-input/keyboardlayoutconfig.cpp
+@@ -40,8 +40,14 @@ KeyboardLayoutConfig::KeyboardLayoutConfig(LXQt::Settings* _settings, QWidget* p
+   connect(ui.removeLayout, &QAbstractButton::clicked, this, &KeyboardLayoutConfig::onRemoveLayout);
+   connect(ui.moveUp, &QAbstractButton::clicked, this, &KeyboardLayoutConfig::onMoveUp);
+   connect(ui.moveDown, &QAbstractButton::clicked, this, &KeyboardLayoutConfig::onMoveDown);
+-  connect(ui.keyboardModel, QOverload<int>::of(&QComboBox::activated), this, &KeyboardLayoutConfig::settingsChanged);
+-  connect(ui.switchKey, QOverload<int>::of(&QComboBox::activated), this, &KeyboardLayoutConfig::settingsChanged);
++  connect(ui.keyboardModel, QOverload<int>::of(&QComboBox::activated), [this](int /*index*/) {
++    applyConfig_ = true;
++    Q_EMIT settingsChanged();
++  });
++  connect(ui.switchKey, QOverload<int>::of(&QComboBox::activated), [this](int /*index*/) {
++    applyConfig_ = true;
++    Q_EMIT settingsChanged();
++  });
+ }
+ 
+ KeyboardLayoutConfig::~KeyboardLayoutConfig() {
+
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..006086d
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+fix-keybord-layout-shortcut.patch

unblock lxqt-config/0.14.1-2

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.0.3-towo.1-siduction-amd64 (SMP w/8 CPU cores; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), LANGUAGE= (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

--- End Message ---
--- Begin Message ---
On Sat, Mar 23, 2019 at 04:48:30PM +0100, Alf Gaida wrote:
> Please unblock package lxqt-config
> 
> there was a regression with keyboard layout shortcut handling that make using
> different keyboard layouts/models hard for people who need this functionality.

Unblocked; thanks.

-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

--- End Message ---

Reply to: