[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#925189: marked as done (unblock: netrek-client-cow/3.3.1-2)

Your message dated Thu, 21 Mar 2019 12:57:27 +0000
with message-id <E1h6xGB-0003mT-Co@respighi.debian.org>
and subject line unblock netrek-client-cow
has caused the Debian Bug report #925189,
regarding unblock: netrek-client-cow/3.3.1-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
925189: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925189
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package netrek-client-cow

There was a possible infinite loop in netrek-client-cow when
generating the mkkey at build-time. This potential issue was resolved
by limiting the execution to create the key to 32 attempts.

This is Debian bug #924291.

Please find attached the debdiff.

unblock netrek-client-cow/3.3.1-2

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-8-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

diff -Nru netrek-client-cow-3.3.1/debian/changelog netrek-client-cow-3.3.1/debian/changelog
--- netrek-client-cow-3.3.1/debian/changelog	2016-09-16 00:08:44.000000000 +0200
+++ netrek-client-cow-3.3.1/debian/changelog	2019-03-20 21:31:57.000000000 +0100
@@ -1,3 +1,11 @@
+netrek-client-cow (3.3.1-2) unstable; urgency=medium
+
+  * Team upload.
+  * Fix possible infinite loop. (Closes: #924291)
+  * Move the package to salsa.debian.org.
+
+ -- Markus Koschany <apo@debian.org>  Wed, 20 Mar 2019 21:31:57 +0100
+
 netrek-client-cow (3.3.1-1) unstable; urgency=medium
 
   * Team upload.
diff -Nru netrek-client-cow-3.3.1/debian/control netrek-client-cow-3.3.1/debian/control
--- netrek-client-cow-3.3.1/debian/control	2016-09-16 00:08:44.000000000 +0200
+++ netrek-client-cow-3.3.1/debian/control	2019-03-20 21:31:57.000000000 +0100
@@ -15,8 +15,8 @@
  libxxf86vm-dev
 Standards-Version: 3.9.8
 Homepage: http://www.netrek.org
-Vcs-Svn: svn://anonscm.debian.org/pkg-games/packages/trunk/netrek-client-cow/
-Vcs-Browser: https://anonscm.debian.org/viewvc/pkg-games/packages/trunk/netrek-client-cow/
+Vcs-Git: https://salsa.debian.org/games-team/netrek-client-cow.git
+Vcs-Browser: https://salsa.debian.org/games-team/netrek-client-cow
 
 Package: netrek-client-cow
 Architecture: any
diff -Nru netrek-client-cow-3.3.1/debian/patches/possible-infinite-loop.patch netrek-client-cow-3.3.1/debian/patches/possible-infinite-loop.patch
--- netrek-client-cow-3.3.1/debian/patches/possible-infinite-loop.patch	1970-01-01 01:00:00.000000000 +0100
+++ netrek-client-cow-3.3.1/debian/patches/possible-infinite-loop.patch	2019-03-20 21:31:57.000000000 +0100
@@ -0,0 +1,22 @@
+From: Markus Koschany <apo@debian.org>
+Date: Wed, 20 Mar 2019 21:29:25 +0100
+Subject: possible infinite loop
+
+Bug-Debian: https://bugs.debian.org/924291
+---
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index efb02ba..131f5af 100644
+--- a/Makefile
++++ b/Makefile
+@@ -31,7 +31,7 @@ convert: mkkey $(KEYFILE) $(KEYSH)
+ 	$(DESC) $(MAKER) $(COMMENT)
+ 
+ newkey: mkkey
+-	until ./mkkey $(KEYFILE) "Client Of Win" $(DESC) $(MAKER) $(COMMENT) "inl,standard2"; do sleep 1; done
++	attempts=32; until ./mkkey $(KEYFILE) "Client Of Win" $(DESC) $(MAKER) $(COMMENT) "inl,standard2"; do attempts=$(attempts - 1); test $(attempts) -le 0 && exit 1; sleep 1; done
+ 
+ mkkey: system.mk
+ 	$(MAKE) -f system.mk KEYDEF=$(KEYDEF) mkkey
diff -Nru netrek-client-cow-3.3.1/debian/patches/series netrek-client-cow-3.3.1/debian/patches/series
--- netrek-client-cow-3.3.1/debian/patches/series	2016-09-16 00:08:44.000000000 +0200
+++ netrek-client-cow-3.3.1/debian/patches/series	2019-03-20 21:31:57.000000000 +0100
@@ -1 +1,2 @@
 gcc5.patch
+possible-infinite-loop.patch

--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: