[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#924875: marked as done (unblock: nodm/0.13-5)

Your message dated Mon, 18 Mar 2019 07:18:00 +0000
with message-id <9d83110d-d883-ed94-10a0-d123f4969bf2@thykier.net>
and subject line Re: Bug#924875: unblock: nodm/0.13-5
has caused the Debian Bug report #924875,
regarding unblock: nodm/0.13-5
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
924875: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924875
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package nodm

+  [ Simon McVittie ]
+  * Non-maintainer upload

Well, yeah... this is not true. (I forgot to remove this line before uploading).

+  * d/rules: Don't restart nodm, fixing regressions from the move to
+    debhelper compat level 12 (Closes: #853016)

Simon was so kind to help out with #853016. The nodm display manager,
after having switched to DH compat level 12, started restarting nodm
itself during postinst and thus crashing the graphical session where the
APT upgrade process was running in.

+  * d/control: Add missing ${misc:Pre-Depends} needed in compat level 12

Quoting smcv:
In compat level 12, dh_installsystemd uses this substitution to generate
its required Pre-Depends on init-system-helpers (>= 1.54~).

+  * postinst: Create reboot-required flag file to notify apt frontends
+    that the user should reboot when convenient

Copying over DBus's mechanism of recommending a system reboot after nodm
package upgrade.

A big thanks to Simon McVittie for helping out on this.

unblock nodm/0.13-5

-- System Information:
Debian Release: 9.8
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-8-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru nodm-0.13/debian/changelog nodm-0.13/debian/changelog
--- nodm-0.13/debian/changelog	2019-03-02 09:38:38.000000000 +0100
+++ nodm-0.13/debian/changelog	2019-03-17 22:18:29.000000000 +0100
@@ -1,3 +1,15 @@
+nodm (0.13-5) unstable; urgency=medium
+
+  [ Simon McVittie ]
+  * Non-maintainer upload
+  * d/rules: Don't restart nodm, fixing regressions from the move to
+    debhelper compat level 12 (Closes: #853016)
+  * d/control: Add missing ${misc:Pre-Depends} needed in compat level 12
+  * postinst: Create reboot-required flag file to notify apt frontends
+    that the user should reboot when convenient
+
+ -- Mike Gabriel <sunweaver@debian.org>  Sun, 17 Mar 2019 22:18:29 +0100
+
 nodm (0.13-4) unstable; urgency=medium
 
   * debian/po:
diff -Nru nodm-0.13/debian/control nodm-0.13/debian/control
--- nodm-0.13/debian/control	2019-01-20 22:41:15.000000000 +0100
+++ nodm-0.13/debian/control	2019-03-17 22:15:50.000000000 +0100
@@ -22,6 +22,8 @@
 
 Package: nodm
 Architecture: linux-any
+Pre-Depends:
+ ${misc:Pre-Depends},
 Depends:
  lsb-base,
  x11-common,
diff -Nru nodm-0.13/debian/nodm.postinst nodm-0.13/debian/nodm.postinst
--- nodm-0.13/debian/nodm.postinst	2019-01-20 23:05:35.000000000 +0100
+++ nodm-0.13/debian/nodm.postinst	2019-03-17 22:15:50.000000000 +0100
@@ -133,4 +133,8 @@
 # tell debconf we are done. otherwise, it hangs waiting for the daemon.
 db_stop;
 
+if [ "$1" = configure ] && [ -n "$2" ]; then
+	touch /var/run/reboot-required || true
+fi
+
 exit 0
diff -Nru nodm-0.13/debian/rules nodm-0.13/debian/rules
--- nodm-0.13/debian/rules	2019-01-20 23:05:35.000000000 +0100
+++ nodm-0.13/debian/rules	2019-03-17 22:15:50.000000000 +0100
@@ -21,7 +21,10 @@
 	#make check
 
 override_dh_installinit:
-	dh_installinit -r -- defaults
+	dh_installinit -r --no-restart-after-upgrade -- defaults
+
+override_dh_installsystemd:
+	dh_installsystemd -r --no-restart-after-upgrade
 
 get-orig-source:
 	uscan --noconf --force-download --rename --download-current-version --destdir=..

--- End Message ---
--- Begin Message --- 
Mike Gabriel:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package nodm
> 
> +  [ Simon McVittie ]
> +  * Non-maintainer upload
> 
> Well, yeah... this is not true. (I forgot to remove this line before uploading).
> 
> +  * d/rules: Don't restart nodm, fixing regressions from the move to
> +    debhelper compat level 12 (Closes: #853016)
> 
> Simon was so kind to help out with #853016. The nodm display manager,
> after having switched to DH compat level 12, started restarting nodm
> itself during postinst and thus crashing the graphical session where the
> APT upgrade process was running in.
> 
> +  * d/control: Add missing ${misc:Pre-Depends} needed in compat level 12
> 
> Quoting smcv:
> In compat level 12, dh_installsystemd uses this substitution to generate
> its required Pre-Depends on init-system-helpers (>= 1.54~).
> 
> +  * postinst: Create reboot-required flag file to notify apt frontends
> +    that the user should reboot when convenient
> 
> Copying over DBus's mechanism of recommending a system reboot after nodm
> package upgrade.
> 
> A big thanks to Simon McVittie for helping out on this.
> 
> unblock nodm/0.13-5
> 
> [...]

Unblocked, thanks.
~Niels

--- End Message ---
Reply to: