[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#924871: marked as done (unblock: eom/1.20.2-2)

Your message dated Sun, 17 Mar 2019 21:24:00 +0000
with message-id <dd451524-1f19-1dc6-9764-5d175e4607d6@thykier.net>
and subject line Re: Bug#924871: unblock: eom/1.20.2-2
has caused the Debian Bug report #924871,
regarding unblock: eom/1.20.2-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
924871: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924871
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package eom

+  * debian/patches:
+    + Add 0001_use-persistent-page-setup.patch. Remember printer setting's page
+      setup. (Closes: #921842).

The added patch teaches eom to remember the page size et al. when
printing images repeatedly to the same printer via eom.

Without this patch, page size is always set to A4 (even if the printer's
default e.g. is letter).

unblock eom/1.20.2-2

-- System Information:
Debian Release: 9.8
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-8-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru eom-1.20.2/debian/changelog eom-1.20.2/debian/changelog
--- eom-1.20.2/debian/changelog	2019-01-04 19:33:04.000000000 +0100
+++ eom-1.20.2/debian/changelog	2019-03-17 21:50:17.000000000 +0100
@@ -1,3 +1,11 @@
+eom (1.20.2-2) unstable; urgency=medium
+
+  * debian/patches:
+    + Add 0001_use-persistent-page-setup.patch. Remember printer setting's page
+      setup. (Closes: #921842).
+
+ -- Mike Gabriel <sunweaver@debian.org>  Sun, 17 Mar 2019 21:50:17 +0100
+
 eom (1.20.2-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru eom-1.20.2/debian/patches/0001_use-persistent-page-setup.patch eom-1.20.2/debian/patches/0001_use-persistent-page-setup.patch
--- eom-1.20.2/debian/patches/0001_use-persistent-page-setup.patch	1970-01-01 01:00:00.000000000 +0100
+++ eom-1.20.2/debian/patches/0001_use-persistent-page-setup.patch	2019-03-10 22:06:33.000000000 +0100
@@ -0,0 +1,35 @@
+From 96b1b4d465f5fdb727938d36f3a9027cb8581384 Mon Sep 17 00:00:00 2001
+From: Victor Kareh <vkareh@redhat.com>
+Date: Wed, 20 Feb 2019 14:38:41 -0500
+Subject: [PATCH] Use persistent page setup
+
+---
+ src/eom-window.c | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/src/eom-window.c b/src/eom-window.c
+index 593a894..5b21202 100644
+--- a/src/eom-window.c
++++ b/src/eom-window.c
+@@ -2146,10 +2146,10 @@ eom_window_print (EomWindow *window)
+ 	/* Make sure the window stays valid while printing */
+ 	g_object_ref (window);
+ 
+-	if (window->priv->page_setup !=NULL)
++	if (window->priv->page_setup != NULL)
+ 		page_setup = g_object_ref (window->priv->page_setup);
+ 	else
+-		page_setup = NULL;
++		page_setup = eom_print_get_page_setup ();
+ 
+ 	print = eom_print_operation_new (window->priv->image,
+ 					 print_settings,
+@@ -2183,6 +2183,7 @@ eom_window_print (EomWindow *window)
+ 		if (window->priv->page_setup != NULL)
+ 			g_object_unref (window->priv->page_setup);
+ 		window->priv->page_setup = g_object_ref (new_page_setup);
++		eom_print_set_page_setup (window->priv->page_setup);
+ 	}
+ 
+ 	if (page_setup != NULL)
+
diff -Nru eom-1.20.2/debian/patches/series eom-1.20.2/debian/patches/series
--- eom-1.20.2/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ eom-1.20.2/debian/patches/series	2019-03-10 22:06:37.000000000 +0100
@@ -0,0 +1 @@
+0001_use-persistent-page-setup.patch

--- End Message ---
--- Begin Message --- 
Mike Gabriel:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package eom
> 
> +  * debian/patches:
> +    + Add 0001_use-persistent-page-setup.patch. Remember printer setting's page
> +      setup. (Closes: #921842).
> 
> The added patch teaches eom to remember the page size et al. when
> printing images repeatedly to the same printer via eom.
> 
> Without this patch, page size is always set to A4 (even if the printer's
> default e.g. is letter).
> 
> unblock eom/1.20.2-2
> 
> [...]

Unblocked, thanks.
~Niels

--- End Message ---
Reply to: