[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#924649: unblock: node-formidable/1.2.1-1



On 15/03/2019 13:41, Xavier Guimard wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package node-formidable
> 
> Hello,
> 
> node-formidable hasn't been updated for years. Testing version isn't
> compatible with our nodejs but this was not seen since there was no
> real tests (see https://bugs.debian.org/924589).
> 
> I upgraded it and added full tests (build and autopkgtest).
> 
> node-formidable reverse dependencies:
>  - node-superagent:
>    +- node-multiparty (no reverse dependencies)

Do you mean node-supertest ? node-multiparty seems unrelated.

> node-formidable bug does not affect these packages since the failing
> functions are not used in it, that's why I decrease bug severity to
> important. I tested the 2 reverse dependencies with both old and new
> node-formidable with success (sbuild and autopkgtest).
> 
> debdiff is big since I embedded some node modules (only for tests, they
> are not installed). Upstream changes are not so big. I updated also
> debian/* files and added examples (and tests of course).
> 
> I think it's not risky to update node-formidable. However I leave you
> appreciate if it is opportune.

I don't think this is suitable really, but the current package doesn't look
suitable either. Since there are no rdeps, is there a reason to ship these
modules in stable atm?

One other option would be to cherry-pick the needed changes if they are small.
Not sure if that'd be feasible.

Emilio


Reply to: