[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#924394: unblock: libqmi/1.22.0-1.2



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package libqmi

The current version in Buster has incorrect "client id" tracking
and thus breaks things like ModemManagers ability to receive SMS
(and who known what else).

Upstream has released a one-line fix which is what I cherry-picked:
https://gitlab.freedesktop.org/mobile-broadband/libqmi/commit/78986d4df7865bb889e18a129a5f0f01ed7f3806

Debdiff attached.

unblock libqmi/1.22.0-1.2

-- System Information:
Debian Release: buster/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing'), (400, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armhf

Kernel: Linux 4.19.0-2-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru libqmi-1.22.0/debian/changelog libqmi-1.22.0/debian/changelog
--- libqmi-1.22.0/debian/changelog	2019-02-08 00:22:46.000000000 +0100
+++ libqmi-1.22.0/debian/changelog	2019-03-12 14:19:35.000000000 +0100
@@ -1,3 +1,11 @@
+libqmi (1.22.0-1.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Add debian/patches/git_reset-offset-before-2nd-call.patch from upstream.
+    - equivalent to 1.22.2 release except the broken manpages in that release.
+
+ -- Andreas Henriksson <andreas@fatal.se>  Tue, 12 Mar 2019 14:19:35 +0100
+
 libqmi (1.22.0-1.1) unstable; urgency=medium
 
   * Non-maintainer upload
diff -Nru libqmi-1.22.0/debian/patches/git_reset-offset-before-2nd-call.patch libqmi-1.22.0/debian/patches/git_reset-offset-before-2nd-call.patch
--- libqmi-1.22.0/debian/patches/git_reset-offset-before-2nd-call.patch	1970-01-01 01:00:00.000000000 +0100
+++ libqmi-1.22.0/debian/patches/git_reset-offset-before-2nd-call.patch	2019-03-12 14:19:22.000000000 +0100
@@ -0,0 +1,25 @@
+From 78986d4df7865bb889e18a129a5f0f01ed7f3806 Mon Sep 17 00:00:00 2001
+From: Valentin Blot <freedesktop-devel@valentinblot.org>
+Date: Thu, 28 Feb 2019 13:08:50 +0000
+Subject: [PATCH] libqmi-glib,proxy: reset offset before 2nd call to
+ qmi_message_tlv_read_init
+
+---
+ src/libqmi-glib/qmi-proxy.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/libqmi-glib/qmi-proxy.c b/src/libqmi-glib/qmi-proxy.c
+index 00a1847..63e2ec1 100644
+--- a/src/libqmi-glib/qmi-proxy.c
++++ b/src/libqmi-glib/qmi-proxy.c
+@@ -489,6 +489,7 @@ track_cid (Client *client,
+     if ((error_status != 0x00) || (error_code != QMI_PROTOCOL_ERROR_NONE))
+         return;
+ 
++    offset = 0;
+     if (((init_offset = qmi_message_tlv_read_init (message, QMI_MESSAGE_OUTPUT_TLV_ALLOCATION_INFO, NULL, &error)) == 0) ||
+         !qmi_message_tlv_read_guint8 (message, init_offset, &offset, &service_tmp, &error) ||
+         !qmi_message_tlv_read_guint8 (message, init_offset, &offset, &(info.cid), &error)) {
+-- 
+2.18.1
+
diff -Nru libqmi-1.22.0/debian/patches/series libqmi-1.22.0/debian/patches/series
--- libqmi-1.22.0/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ libqmi-1.22.0/debian/patches/series	2019-03-12 14:19:28.000000000 +0100
@@ -0,0 +1 @@
+git_reset-offset-before-2nd-call.patch

Reply to: