Bug#924161: unblock: lirc/0.10.1-5.1
On Sun, 10 Mar 2019 18:07:57 +0100 Nicolas Braud-Santoni
<nicoo@debian.org> wrote:
> Control: tags -1 - moreinfo
>
> On Sun, Mar 10, 2019 at 08:58:00AM +0000, Niels Thykier wrote:
> > --link-doc requires dir-to-symlink migration via dpkg-maintscript-helper
> > in the maintscript. I do not see that in the debdiff, so I assume the
> > proposed changes will trigger a new bug (as I recall, an RC bug).
>
> Yes indeed!
> Thanks for catching this, here is the debdiff for the updated package.
>
> I also fixed some other issues, like #924158.
This needs a lot of more work :-(
* is this usage of --link-doc valid? the packages don't have a strictly
versioned Depends: lirc (= ${binary:version}), so I can install *only*
liblirc0 and have a dangling /usr/share/doc/liblirc0 and e.g. no
copyright file
* in all the *.maintscript files, add 0.10.1-5.1~ as 'prior-version'
argument - you don't want to run this stuff again on *every* upgrade
* lirc.maintscript has typos: /etx/...
* does the override_dh_installdocs target work with
dpkg-buildpackage -A/-B (i.e. building arch and indep packages separately)
* lirc.postinst: using wildcards looks very fragile
* lirc.posztrm: why do you manually delete conffiles on purge? dpkg does
that already. (If they are not conffiles, you can't use
dpkg-maintscript-helper on them.)
Andreas
PS: I hate cleaning up after misuse of --link-doc. Save brain cycles,
not bits on disks. Right now I'm afraid that you are turning a mess into
a greater mess.
PPS: I only looked at the debdiff, not at the package itself
Reply to: