--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Dear Release Team,
Please advise about the situation with Pacemaker.
At the moment pacemaker_2.0.1~rc5-1 is 6 days old in unstable (it was
uploaded on the day following its release) and now that it finally built
on all architectures (it triggered a linker bug on amd64) I expect it to
migrate to testing this week, well before the full freeze.
However, Pacemaker 2.0.1 final was released today and includes a single
code change only, with the following commit message (the change itself
is the deletion of lines at the end of the debdiff below):
High: libcrmcommon: complete interrupted live migrations correctly
8435966 (2.0.0) got the sense of compare_version() wrong when
attempting to remove the old behavior for recording partial live
migrations, instead re-introducing it.
This causes a regression in behavior when a transition containing a
live migration is aborted after the migrate_to has been initiated
but before the migrate_from has been initiated. In that case, it
would schedule a full start on the destination node rather than a
migrate_from.
I think we should release buster with Pacemaker 2.0.1, thus with this
fix and the small documentation fixes also bundled with it. The added
include directives just make previously indirect includes explicit, and
our build doesn't use the abi-check script, so that change is a no-op.
Full debdiff from 2.0.1~rc5-1 (which is on its way to testing):
diff -Nru pacemaker-2.0.1~rc5/abi-check pacemaker-2.0.1/abi-check
--- pacemaker-2.0.1~rc5/abi-check 2019-02-25 22:35:40.000000000 +0100
+++ pacemaker-2.0.1/abi-check 2019-03-04 20:55:07.000000000 +0100
@@ -76,7 +76,8 @@
</descriptor>
EOF
- abi-compliance-checker -l $PACKAGE -dump_abi $DESC
+ abi-compliance-checker -l $PACKAGE -dump_abi $DESC \
+ -dump-path abi_dumps/${PACKAGE}/${PACKAGE}_${VERSION}.abi.tar.gz
rm -rf $BUILD_ROOT
}
diff -Nru pacemaker-2.0.1~rc5/ChangeLog pacemaker-2.0.1/ChangeLog
--- pacemaker-2.0.1~rc5/ChangeLog 2019-02-25 22:35:40.000000000 +0100
+++ pacemaker-2.0.1/ChangeLog 2019-03-04 20:55:07.000000000 +0100
@@ -1,103 +1,75 @@
-* Mon Feb 25 2019 Ken Gaillot <kgaillot@redhat.com> Pacemaker-2.0.1-rc5
-- Changesets: 17
-- Diff: 15 files changed, 1037 insertions(+), 677 deletions(-)
-
-- Changes since Pacemaker-2.0.1-rc4
- + scheduler: regression test compatibility with glib 2.59.0
-
-* Tue Jan 29 2019 Ken Gaillot <kgaillot@redhat.com> Pacemaker-2.0.1-rc4
-- Changesets: 42
- 15 files changed, 216 insertions(+), 137 deletions(-)
-
-- Changes since Pacemaker-2.0.1-rc3
- + attrd: clear election dampening when the writer leaves
- + controller: clear election dampening when DC is lost
- + scheduler: don't order non-DC shutdowns before DC fencing
- + libcrmservice: cancel DBus call when cancelling systemd/upstart actions
- + tools: remove duplicate fence history state in crm_mon XML output
- + build: offer configure option to disable tests broken with glib 2.59.0
- + build: minor logging fixes to allow compatibility with GCC 9 -Werror
-
-* Thu Jan 10 2019 Ken Gaillot <kgaillot@redhat.com> Pacemaker-2.0.1-rc3
-- Changesets: 27
-- Diff: 20 files changed, 375 insertions(+), 195 deletions(-)
-
-- Changes since Pacemaker-2.0.1-rc2
- + attrd: start new election immediately if writer is lost
- + attrd: detect alert configuration changes when CIB is entirely replaced
- + controller: avoid transition timeout if resource cleaned while operation
- is in-flight (regression in 2.0.1-rc1)
- + libstonithd: restore C++ compatibility (regression in 2.0.1-rc1)
- + tools: fix crm_resource --clear when lifetime was used with ban/move
- + tools: fix crm_resource --move when lifetime was used with previous move
-
-* Wed Dec 19 2018 Ken Gaillot <kgaillot@redhat.com> Pacemaker-2.0.1-rc2
-- Changesets: 12
-- Diff: 2 files changed, 6 insertions(+), 2 deletions(-)
-
-- Changes since Pacemaker-2.0.1-rc1
- + libpe_status: avoid double free of stop_needed list (regression in 2.0.1-rc1)
- + tools: stonith_admin -I doesn't require an agent (regression in 2.0.1-rc1)
-
-* Wed Dec 12 2018 Ken Gaillot <kgaillot@redhat.com> Pacemaker-2.0.1-rc1
-- Changesets: 481
- 164 files changed, 7717 insertions(+), 4398 deletions(-)
+* Mon Mar 4 2019 Ken Gaillot <kgaillot@redhat.com> Pacemaker-2.0.1-1
+- Changesets: 592
+ 173 files changed, 9268 insertions(+), 5344 deletions(-)
- Features added since Pacemaker-2.0.0
- + Pacemaker bundles now support podman container management
- + fencing: SBD may now be used in a cluster that has guest nodes or bundles
- + fencing: synchronize fencing history among all nodes
- + fencing: stonith_admin now has option to clear fence history
- + tools: crm_mon now supports showing fencing action failures and history
+ + Pacemaker bundles support podman for container management
+ + fencing: SBD may be used in a cluster that has guest nodes or bundles
+ + fencing: fencing history is synchronized among all nodes
+ + fencing: stonith_admin has option to clear fence history
+ + tools: crm_mon can show fencing action failures and history
+ tools: crm_resource --clear supports new --expired option
- + Pacemaker Remote: option to restrict TLS Diffie-Hellman prime length
+ + Pacemaker Remote: new options to restrict TLS Diffie-Hellman prime length
- Changes since Pacemaker-2.0.0
- + tools: restore stonith_admin ability to confirm unseen nodes are down
- (regression since 1.1.12)
- + Pacemaker Remote: avoid unnecessary downtime when moving resource to
- Pacemaker Remote node that fails to come up (regression since 1.1.18)
+ scheduler: clone notifications could be scheduled for a stopped
Pacemaker Remote node and block all further cluster actions
(regression since 2.0.0)
+ + libcrmcommon: correct behavior for completing interrupted live migrations
+ (regression since 2.0.0)
+ tools: crm_resource -C could fail to clean up all failures in one run
(regression since 2.0.0)
+ + Pacemaker Remote: avoid unnecessary downtime when moving resource to
+ Pacemaker Remote node that fails to come up (regression since 1.1.18)
+ + tools: restore stonith_admin ability to confirm unseen nodes are down
+ (regression since 1.1.12)
+ + build: minor logging fixes to allow compatibility with GCC 9 -Werror
+ build: spec file now puts XML schemas in new pacemaker-schemas package
+ build: spec file now provides virtual pcmk-cluster-manager package
+ pacemaker-attrd: wait a short time before re-attempting failed writes
+ pacemaker-attrd: ignore attribute delays when writing after node (re-)join
+ + pacemaker-attrd: start new election immediately if writer is lost
+ + pacemaker-attrd: clear election dampening when the writer leaves
+ + pacemaker-attrd: detect alert configuration changes when CIB is replaced
+ CIB: inform originator of CIB upgrade failure
+ controller: support resource agents that require node name even for meta-data
+ controller: don't record pending clone notifications in CIB
+ controller: DC detects completion of another node's shutdown more accurately
+ controller: shut down DC if unable to update node attributes
+ controller: handle corosync peer/join notifications for new node in any order
+ + controller: clear election dampening when DC is lost
+ executor: cancel recurring monitors if fence device registration is lost
+ fencing: check for fence device update when resource defaults change
- + fencing: fix possible pacemaker-fenced crash with stonith_admin misuse
+ + fencing: avoid pacemaker-fenced crash possible with stonith_admin misuse
+ fencing: limit fencing history to 500 entries
+ fencing: stonith_admin now complains if no action option is specified
- + pacemakerd: Linux kernel.sysrq is no longer modified
+ + pacemakerd: do not modify kernel.sysrq on Linux
+ + scheduler: regression test compatibility with glib 2.59.0
+ scheduler: avoid unnecessary recovery of cleaned guest nodes and bundles
- + scheduler: ensure failures that cause fencing are not expired until fencing completes
+ + scheduler: ensure failures causing fencing not expired until fencing done
+ scheduler: start unique clone instances in numerical order
- + scheduler: convert unique clones to anonymous clones if not supported by standard
+ + scheduler: convert unique clones to anonymous clones when not supported
+ scheduler: associate pending tasks with correct clone instance
+ scheduler: ensure bundle clone notifications are directed to correct host
- + scheduler: avoid improper monitor rescheduling or fail count clearing for bundles
+ + scheduler: avoid improper bundle monitor rescheduling or fail count clearing
+ scheduler: honor asymmetric orderings even when restarting
+ + scheduler: don't order non-DC shutdowns before DC fencing
+ ACLs: assume unprivileged ACL user if can't get user info
+ Pacemaker Remote: get Diffie-Hellman prime bit length from GnuTLS API
+ + libcrmservice: cancel DBus call when cancelling systemd/upstart actions
+ libcrmservice: order systemd resources relative to pacemaker_remote
+ libpe_status: add public API constructor/destructor for pe_working_set_t
+ + tools: fix crm_resource --clear when lifetime was used with ban/move
+ + tools: fix crm_resource --move when lifetime was used with previous move
+ tools: make crm_mon CIB connection errors non-fatal if previously successful
+ tools: improve crm_mon messages when generating HTML output
+ tools: crm_mon cluster connection failure is now "critical" in nagios mode
- + tools: crm_mon listing of standby nodes now shows if they still have active resources
+ + tools: crm_mon listing of standby nodes shows if they have active resources
+ tools: crm_diff now ignores attribute ordering when comparing in CIB mode
- + tools: improve crm_report detection of logs, CIB directory, running processes
+ + tools: improve crm_report detection of logs, CIB directory, and processes
+ tools: crm_verify returns reliable exit codes
- + tools: crm_simulate simulated resource history uses same name as live cluster would
+ + tools: crm_simulate resource history uses same name as live cluster would
+
* Fri Jul 6 2018 Ken Gaillot <kgaillot@redhat.com> Pacemaker-2.0.0-1
- Changesets: 885
diff -Nru pacemaker-2.0.1~rc5/configure.ac pacemaker-2.0.1/configure.ac
--- pacemaker-2.0.1~rc5/configure.ac 2019-02-25 22:35:40.000000000 +0100
+++ pacemaker-2.0.1/configure.ac 2019-03-04 20:55:07.000000000 +0100
@@ -1075,7 +1075,7 @@
AC_PATH_PROGS(GIT, git false)
AC_MSG_CHECKING(build version)
-BUILD_VERSION=22ee9a769e
+BUILD_VERSION=9e909a5bdd
if test $BUILD_VERSION != ":%h$"; then
AC_MSG_RESULT(archive hash: $BUILD_VERSION)
elif test -x $GIT -a -d .git; then
diff -Nru pacemaker-2.0.1~rc5/debian/changelog pacemaker-2.0.1/debian/changelog
--- pacemaker-2.0.1~rc5/debian/changelog 2019-02-26 09:52:21.000000000 +0100
+++ pacemaker-2.0.1/debian/changelog 2019-03-04 21:34:46.000000000 +0100
@@ -1,3 +1,9 @@
+pacemaker (2.0.1-1) unstable; urgency=medium
+
+ * [7d6ff2e] New upstream release (2.0.1)
+
+ -- Ferenc Wágner <wferi@debian.org> Mon, 04 Mar 2019 21:34:46 +0100
+
pacemaker (2.0.1~rc5-1) unstable; urgency=medium
* [79e9089] Drop duplicate external library linkages
diff -Nru pacemaker-2.0.1~rc5/doc/Pacemaker_Development/en-US/Ch-Coding.txt pacemaker-2.0.1/doc/Pacemaker_Development/en-US/Ch-Coding.txt
--- pacemaker-2.0.1~rc5/doc/Pacemaker_Development/en-US/Ch-Coding.txt 2019-02-25 22:35:40.000000000 +0100
+++ pacemaker-2.0.1/doc/Pacemaker_Development/en-US/Ch-Coding.txt 2019-03-04 20:55:07.000000000 +0100
@@ -243,7 +243,7 @@
should be documented with Doxygen comment blocks, as Pacemaker's
http://clusterlabs.org/pacemaker/doxygen/[online API documentation]
is automatically generated via Doxygen. It is helpful to document
-private symols in the same way, with an +\internal+ tag in the
+private symbols in the same way, with an +\internal+ tag in the
Doxygen comment.
=== Symbol Naming ===
diff -Nru pacemaker-2.0.1~rc5/doc/Pacemaker_Explained/en-US/Ch-Multi-site-Clusters.txt pacemaker-2.0.1/doc/Pacemaker_Explained/en-US/Ch-Multi-site-Clusters.txt
--- pacemaker-2.0.1~rc5/doc/Pacemaker_Explained/en-US/Ch-Multi-site-Clusters.txt 2019-02-25 22:35:40.000000000 +0100
+++ pacemaker-2.0.1/doc/Pacemaker_Explained/en-US/Ch-Multi-site-Clusters.txt 2019-03-04 20:55:07.000000000 +0100
@@ -208,7 +208,7 @@
////
These commands will actually just print a message telling the user that they
-requre '--force'. That is probably a good exercise rather than letting novice
+require '--force'. That is probably a good exercise rather than letting novice
users cut and paste '--force' here.
////
diff -Nru pacemaker-2.0.1~rc5/doc/Pacemaker_Explained/en-US/Ch-Resources.txt pacemaker-2.0.1/doc/Pacemaker_Explained/en-US/Ch-Resources.txt
--- pacemaker-2.0.1~rc5/doc/Pacemaker_Explained/en-US/Ch-Resources.txt 2019-02-25 22:35:40.000000000 +0100
+++ pacemaker-2.0.1/doc/Pacemaker_Explained/en-US/Ch-Resources.txt 2019-03-04 20:55:07.000000000 +0100
@@ -685,7 +685,7 @@
indexterm:[Action,Property,enabled]
|record-pending
-|FALSE
+|TRUE
|If +true+, the intention to perform the operation is recorded so that
GUIs and CLI tools can indicate that an operation is in progress.
This is best set as an _operation default_ (see <<s-operation-defaults>>).
diff -Nru pacemaker-2.0.1~rc5/include/crm/cib/util.h pacemaker-2.0.1/include/crm/cib/util.h
--- pacemaker-2.0.1~rc5/include/crm/cib/util.h 2019-02-25 22:35:40.000000000 +0100
+++ pacemaker-2.0.1/include/crm/cib/util.h 2019-03-04 20:55:07.000000000 +0100
@@ -1,23 +1,17 @@
-/*
- * Copyright (C) 2004 Andrew Beekhof <andrew@beekhof.net>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This software is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+/*
+ * Copyright 2004-2019 Andrew Beekhof <andrew@beekhof.net>
+ *
+ * This source code is licensed under the GNU Lesser General Public License
+ * version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
*/
+
#ifndef CIB_UTIL__H
# define CIB_UTIL__H
+#include <glib.h> // gboolean
+#include <crm/cib.h> // cib_t
+#include <libxml/tree.h> // xmlNode
+
#ifdef __cplusplus
extern "C" {
#endif
diff -Nru pacemaker-2.0.1~rc5/include/crm/cib.h pacemaker-2.0.1/include/crm/cib.h
--- pacemaker-2.0.1~rc5/include/crm/cib.h 2019-02-25 22:35:40.000000000 +0100
+++ pacemaker-2.0.1/include/crm/cib.h 2019-03-04 20:55:07.000000000 +0100
@@ -1,5 +1,5 @@
/*
- * Copyright 2004-2018 Andrew Beekhof <andrew@beekhof.net>
+ * Copyright 2004-2019 Andrew Beekhof <andrew@beekhof.net>
*
* This source code is licensed under the GNU Lesser General Public License
* version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
@@ -18,6 +18,8 @@
* \ingroup cib
*/
+# include <glib.h> // gboolean, GList
+# include <libxml/tree.h> // xmlNode
# include <crm/common/ipc.h>
# include <crm/common/xml.h>
diff -Nru pacemaker-2.0.1~rc5/include/crm/pengine/complex.h pacemaker-2.0.1/include/crm/pengine/complex.h
--- pacemaker-2.0.1~rc5/include/crm/pengine/complex.h 2019-02-25 22:35:40.000000000 +0100
+++ pacemaker-2.0.1/include/crm/pengine/complex.h 2019-03-04 20:55:07.000000000 +0100
@@ -1,5 +1,5 @@
/*
- * Copyright 2004-2018 Andrew Beekhof <andrew@beekhof.net>
+ * Copyright 2004-2019 Andrew Beekhof <andrew@beekhof.net>
*
* This source code is licensed under the GNU Lesser General Public License
* version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
@@ -12,6 +12,10 @@
extern "C" {
#endif
+#include <glib.h> // gboolean, GList, GHashTable
+#include <libxml/tree.h> // xmlNode
+#include <crm/pengine/status.h>
+
enum pe_obj_types {
pe_unknown = -1,
pe_native = 0,
diff -Nru pacemaker-2.0.1~rc5/include/crm/pengine/remote.h pacemaker-2.0.1/include/crm/pengine/remote.h
--- pacemaker-2.0.1~rc5/include/crm/pengine/remote.h 2019-02-25 22:35:40.000000000 +0100
+++ pacemaker-2.0.1/include/crm/pengine/remote.h 2019-03-04 20:55:07.000000000 +0100
@@ -1,20 +1,10 @@
/*
- * Copyright (C) 2013 Andrew Beekhof <andrew@beekhof.net>
+ * Copyright 2013-2019 Andrew Beekhof <andrew@beekhof.net>
*
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This software is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ * This source code is licensed under the GNU Lesser General Public License
+ * version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
*/
+
#ifndef PE_REMOTE__H
# define PE_REMOTE__H
@@ -22,6 +12,10 @@
extern "C" {
#endif
+#include <glib.h> // gboolean
+#include <libxml/tree.h> // xmlNode
+#include <crm/pengine/status.h>
+
gboolean xml_contains_remote_node(xmlNode *xml);
gboolean is_baremetal_remote_node(node_t *node);
gboolean is_container_remote_node(node_t *node);
diff -Nru pacemaker-2.0.1~rc5/include/crm/pengine/status.h pacemaker-2.0.1/include/crm/pengine/status.h
--- pacemaker-2.0.1~rc5/include/crm/pengine/status.h 2019-02-25 22:35:40.000000000 +0100
+++ pacemaker-2.0.1/include/crm/pengine/status.h 2019-03-04 20:55:07.000000000 +0100
@@ -1,5 +1,5 @@
/*
- * Copyright 2004-2018 Andrew Beekhof <andrew@beekhof.net>
+ * Copyright 2004-2019 Andrew Beekhof <andrew@beekhof.net>
*
* This source code is licensed under the GNU Lesser General Public License
* version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
diff -Nru pacemaker-2.0.1~rc5/lib/common/operations.c pacemaker-2.0.1/lib/common/operations.c
--- pacemaker-2.0.1~rc5/lib/common/operations.c 2019-02-25 22:35:40.000000000 +0100
+++ pacemaker-2.0.1/lib/common/operations.c 2019-03-04 20:55:07.000000000 +0100
@@ -396,8 +396,8 @@
task = op->op_type;
- /* Remap the task name under various scenarios, to make life easier for the
- * PE when determining the current state.
+ /* Record a successful reload as a start, and a failed reload as a monitor,
+ * to make life easier for the scheduler when determining the current state.
*/
if (crm_str_eq(task, "reload", TRUE)) {
if (op->op_status == PCMK_LRM_OP_DONE) {
@@ -405,18 +405,6 @@
} else {
task = CRMD_ACTION_STATUS;
}
-
- } else if (crm_str_eq(task, CRMD_ACTION_MIGRATE, TRUE)) {
- /* if the migrate_from fails it will have enough info to do the right thing */
- if (op->op_status == PCMK_LRM_OP_DONE) {
- task = CRMD_ACTION_STOP;
- } else {
- task = CRMD_ACTION_STATUS;
- }
-
- } else if ((op->op_status == PCMK_LRM_OP_DONE)
- && crm_str_eq(task, CRMD_ACTION_MIGRATED, TRUE)) {
- task = CRMD_ACTION_START;
}
key = generate_op_key(op->rsc_id, task, op->interval_ms);
Even if I uploaded 2.0.1-1 now, it would miss the freeze date by a day,
kicking out 2.0.1~rc5-1 as well, which would be quite a shame,
considering that it's almost as good as the final, and definitely better
than 2.0.1~rc4-1 currently in testing. Could you please provide a way
for 2.0.1-1 final (not uploaded yet) to reach buster?
Thanks,
Feri.
unblock pacemaker/2.0.1-1
--- End Message ---